[Bug fortran/40451] New: procedure-pointer assignment rejected

[Bug fortran/40451] New: procedure-pointer assignment rejected

[burnus at gcc dot gnu dot org]

The following program is rejected with:

    f => sin
         1
Error: Interfaces don't match in procedure pointer assignment at (1)

However, if one removes the "module m; contains" it is accepted


module m
contains
  function f()
    intrinsic :: sin
    procedure(sin), pointer :: f
    f => sin
  end function f
end module m


-- 
           Summary: procedure-pointer assignment rejected
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40451

[Bug fortran/40451] procedure-pointer assignment rejected

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2009-06-15 21:10 -------
Post script: With your current patch, the error message is:

Error: Interface mismatch in procedure pointer assignment at (1): 'sin' has the
wrong number of arguments


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40451

[Bug fortran/40451] procedure-pointer assignment rejected

[janus at gcc dot gnu dot org]

------- Comment #2 from janus at gcc dot gnu dot org  2009-06-17 08:33 -------
The test case is also rejected without being inside a module:

contains
  function f()
    intrinsic :: sin
    procedure(sin), pointer :: f
    f => sin
  end function f
end

However, if the 'contains' is removed, it is accepted.


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-06-17 08:33:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40451

[Bug fortran/40451] [F03] procedure pointer assignment rejected

[janus at gcc dot gnu dot org]

------- Comment #3 from janus at gcc dot gnu dot org  2009-06-17 08:54 -------
The error also goes away if 'implicit none' is inserted.


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|procedure-pointer assignment|[F03] procedure pointer
                   |rejected                    |assignment rejected


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40451

[Bug fortran/40451] [F03] procedure pointer assignment rejected

[janus at gcc dot gnu dot org]

------- Comment #4 from janus at gcc dot gnu dot org  2009-06-17 09:26 -------
Mine. Here's a patch:

Index: gcc/fortran/symbol.c
===================================================================
--- gcc/fortran/symbol.c        (revision 148518)
+++ gcc/fortran/symbol.c        (working copy)
@@ -317,7 +317,7 @@ gfc_check_function_type (gfc_namespace *
   if (!proc->attr.contained || proc->result->attr.implicit_type)
     return;

-  if (proc->result->ts.type == BT_UNKNOWN)
+  if (proc->result->ts.type == BT_UNKNOWN && proc->result->ts.interface ==
NULL)
     {
       if (gfc_set_default_type (proc->result, 0, gfc_current_ns)
                == SUCCESS)
Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c       (revision 148519)
+++ gcc/fortran/resolve.c       (working copy)
@@ -347,7 +347,7 @@ resolve_contained_fntype (gfc_symbol *sy
     return;

   /* Try to find out of what the return type is.  */
-  if (sym->result->ts.type == BT_UNKNOWN)
+  if (sym->result->ts.type == BT_UNKNOWN && sym->result->ts.interface == NULL)
     {
       t = gfc_set_default_type (sym->result, 0, ns);


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |janus at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-06-17 08:33:58         |2009-06-17 09:26:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40451

[Bug fortran/40451] [F03] procedure pointer assignment rejected

[janus at gcc dot gnu dot org]

------- Comment #5 from janus at gcc dot gnu dot org  2009-06-18 08:09 -------
Subject: Bug 40451

Author: janus
Date: Thu Jun 18 08:09:40 2009
New Revision: 148652

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=148652
Log:
2009-06-18  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/40451
        * resolve.c (resolve_contained_fntype): Prevent implicit typing for
        procedures with explicit interface.
        * symbol.c (gfc_check_function_type): Ditto.

2009-06-18  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/40451
        * gfortran.dg/proc_ptr_result_4.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/proc_ptr_result_4.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/symbol.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40451

[Bug fortran/40451] [F03] procedure pointer assignment rejected

[janus at gcc dot gnu dot org]

------- Comment #6 from janus at gcc dot gnu dot org  2009-06-18 08:13 -------
Fixed with r148652. Closing.


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40451