public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/40588] New: Small bug in match_charkind_name
@ 2009-06-29 14:24 philippe dot marguinaud at meteo dot fr
2009-06-29 15:18 ` [Bug fortran/40588] " burnus at gcc dot gnu dot org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: philippe dot marguinaud at meteo dot fr @ 2009-06-29 14:24 UTC (permalink / raw)
To: gcc-bugs
Looking at the code, I think that the following lines from match_charkind_name
(primary.c:830):
if (!ISALNUM (c)
&& c != '_'
&& (gfc_option.flag_dollar_ok && c != '$'))
break;
should be changed to:
if (!ISALNUM (c)
&& c != '_'
&& !(gfc_option.flag_dollar_ok && c == '$'))
break;
--
Summary: Small bug in match_charkind_name
Product: gcc
Version: 4.5.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: philippe dot marguinaud at meteo dot fr
GCC build triplet: any
GCC host triplet: any
GCC target triplet: any
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40588
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/40588] Small bug in match_charkind_name
2009-06-29 14:24 [Bug fortran/40588] New: Small bug in match_charkind_name philippe dot marguinaud at meteo dot fr
@ 2009-06-29 15:18 ` burnus at gcc dot gnu dot org
2009-07-05 9:14 ` fxcoudert at gcc dot gnu dot org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu dot org @ 2009-06-29 15:18 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from burnus at gcc dot gnu dot org 2009-06-29 15:17 -------
I agree that
&& (gfc_option.flag_dollar_ok && c != '$'))
is wrong and is should either be
&& !(gfc_option.flag_dollar_ok && c == '$'))
^^^ ^^
or equivalently
&& (!gfc_option.flag_dollar_ok || c != '$'))
^^^ ^^
The current version accepts with -fno-dollar-ok all characters '$', '@" etc.
while for -fdollar-ok only '$' is allowed. However, those lines are in
match_charkind_name. As the variable_"string" is parsed before (in
gfc_match_name), the invalid character is noted before correctly.
Thus
if (!ISALNUM (c) && c != '_' && c != '$')
is equivalent, taking the previous gfc_match_name into account.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40588
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/40588] Small bug in match_charkind_name
2009-06-29 14:24 [Bug fortran/40588] New: Small bug in match_charkind_name philippe dot marguinaud at meteo dot fr
2009-06-29 15:18 ` [Bug fortran/40588] " burnus at gcc dot gnu dot org
@ 2009-07-05 9:14 ` fxcoudert at gcc dot gnu dot org
2009-07-13 6:27 ` burnus at gcc dot gnu dot org
2009-07-13 6:29 ` burnus at gcc dot gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2009-07-05 9:14 UTC (permalink / raw)
To: gcc-bugs
--
fxcoudert at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
GCC build triplet|any |
GCC host triplet|any |
GCC target triplet|any |
Keywords| |patch
Last reconfirmed|0000-00-00 00:00:00 |2009-07-05 09:14:39
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40588
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/40588] Small bug in match_charkind_name
2009-06-29 14:24 [Bug fortran/40588] New: Small bug in match_charkind_name philippe dot marguinaud at meteo dot fr
2009-06-29 15:18 ` [Bug fortran/40588] " burnus at gcc dot gnu dot org
2009-07-05 9:14 ` fxcoudert at gcc dot gnu dot org
@ 2009-07-13 6:27 ` burnus at gcc dot gnu dot org
2009-07-13 6:29 ` burnus at gcc dot gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu dot org @ 2009-07-13 6:27 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from burnus at gcc dot gnu dot org 2009-07-13 06:26 -------
Subject: Bug 40588
Author: burnus
Date: Mon Jul 13 06:26:38 2009
New Revision: 149545
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=149545
Log:
2009-07-12 Tobias Burnus <burnus@net-b.de>
Philippe Marguinaud <philippe.marguinaud@meteo.fr>
PR fortran/40588
* primary.c (match_charkind_name): Fix condition for $ matching.
PR libfortran/22423
* libgfortran.h: Typedef the GFC_DTYPE_* enum.
2009-07-12 Tobias Burnus <burnus@net-b.de>
PR libfortran/22423
* io/io.h (namelist_type): Use the proper enum for GFC_DTYPE_*.
* intrinsics/iso_c_binding.c (c_f_pointer_u0): Make sure
variable is initialized to silence warning.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/libgfortran.h
trunk/gcc/fortran/primary.c
trunk/libgfortran/ChangeLog
trunk/libgfortran/intrinsics/iso_c_binding.c
trunk/libgfortran/io/io.h
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40588
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/40588] Small bug in match_charkind_name
2009-06-29 14:24 [Bug fortran/40588] New: Small bug in match_charkind_name philippe dot marguinaud at meteo dot fr
` (2 preceding siblings ...)
2009-07-13 6:27 ` burnus at gcc dot gnu dot org
@ 2009-07-13 6:29 ` burnus at gcc dot gnu dot org
3 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu dot org @ 2009-07-13 6:29 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from burnus at gcc dot gnu dot org 2009-07-13 06:28 -------
FIXED on the trunk (4.5). Thanks for the report and patch!
--
burnus at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40588
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-07-13 6:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-29 14:24 [Bug fortran/40588] New: Small bug in match_charkind_name philippe dot marguinaud at meteo dot fr
2009-06-29 15:18 ` [Bug fortran/40588] " burnus at gcc dot gnu dot org
2009-07-05 9:14 ` fxcoudert at gcc dot gnu dot org
2009-07-13 6:27 ` burnus at gcc dot gnu dot org
2009-07-13 6:29 ` burnus at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).