[Bug c++/40749] New: g++ doesnt report missing return if return is of type const <type>

[Bug c++/40749] New: g++ doesnt report missing return if return is of type const <type>

[mfribeiro at gmail dot com]

This code below wont generate a warning for function a(). Compiled with -Wall.
If you remove the const from the return, it will work.

<code>
class A {
public:
};

const A a() {
}

int main() {
  A b = a();
}
</code>


-- 
           Summary: g++ doesnt report missing return if return is of type
                    const <type>
           Product: gcc
           Version: 4.3.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: mfribeiro at gmail dot com
 GCC build triplet: x86_64 GNU/Linux
  GCC host triplet: x86_64 GNU/Linux
GCC target triplet: x86_64 GNU/Linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3/4.4/4.5 Regression] g++ doesnt report missing return if return is of type const <type>

[rguenth at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]



------- Comment #1 from rguenth at gcc dot gnu dot org  2009-07-15 09:37 -------
Confirmed.  4.2 reports

g++-4.2 -Wall t.C 
t.C: In function ‘const A a()’:
t.C:6: warning: control reaches end of non-void function


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |diagnostic
      Known to fail|                            |4.3.3 4.4.0 4.5.0
      Known to work|                            |4.2.4
   Last reconfirmed|0000-00-00 00:00:00         |2009-07-15 09:37:13
               date|                            |
            Summary|g++ doesnt report missing   |[4.3/4.4/4.5 Regression] g++
                   |return if return is of type |doesnt report missing return
                   |const <type>                |if return is of type const
                   |                            |<type>
   Target Milestone|---                         |4.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3/4.4/4.5 Regression] g++ doesnt report missing return if return is of type const <type>

[simartin at gcc dot gnu dot org]

------- Comment #2 from simartin at gcc dot gnu dot org  2009-07-17 19:57 -------
It seems to be caused by the fix for PR#18313. I am testing the following:

Index: gcc/cp/decl.c
===================================================================
--- gcc/cp/decl.c       (revision 149752)
+++ gcc/cp/decl.c       (working copy)
@@ -8314,12 +8314,14 @@
            if (type_quals != TYPE_UNQUALIFIED)
              {
                if (SCALAR_TYPE_P (type) || VOID_TYPE_P (type))
-                 warning (OPT_Wignored_qualifiers,
-                          "type qualifiers ignored on function return type");
+                 {
+                   warning (OPT_Wignored_qualifiers,
+                            "type qualifiers ignored on function return
type");
+                   set_no_warning = true;
+                 }
                /* We now know that the TYPE_QUALS don't apply to the
                   decl, but to its return type.  */
                type_quals = TYPE_UNQUALIFIED;
-               set_no_warning = true;
              }
            errmsg = targetm.invalid_return_type (type);
            if (errmsg)


-- 

simartin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simartin at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3/4.4/4.5 Regression] g++ doesnt report missing return if return is of type const <type>

[simartin at gcc dot gnu dot org]

------- Comment #3 from simartin at gcc dot gnu dot org  2009-07-17 22:03 -------
Updated patch submitted here:
  http://gcc.gnu.org/ml/gcc-patches/2009-07/msg01043.html


-- 

simartin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |simartin at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-07-15 09:37:13         |2009-07-17 22:03:33
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3/4.4/4.5 Regression] g++ doesnt report missing return if return is of type const <type>

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3/4.4/4.5 Regression] g++ doesnt report missing return if return is of type const <type>

[simartin at gcc dot gnu dot org]

------- Comment #4 from simartin at gcc dot gnu dot org  2009-07-26 08:16 -------
Subject: Bug 40749

Author: simartin
Date: Sun Jul 26 08:16:41 2009
New Revision: 150097

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=150097
Log:
gcc/cp/

2009-07-26  Simon Martin  <simartin@users.sourceforge.net>

        PR c++/40749
        * decl.c (grokdeclarator): Do not set TREE_NO_WARNING for functions
        with a qualified return type.

gcc/testsuite/

2007-07-26  Simon Martin  <simartin@users.sourceforge.net>

        PR c++/40749
        * g++.dg/warn/Wreturn-type-6.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/warn/Wreturn-type-6.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3/4.4/4.5 Regression] g++ doesnt report missing return if return is of type const <type>

[simartin at gcc dot gnu dot org]

------- Comment #5 from simartin at gcc dot gnu dot org  2009-07-26 16:05 -------
Subject: Bug 40749

Author: simartin
Date: Sun Jul 26 16:05:22 2009
New Revision: 150099

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=150099
Log:
gcc/cp/

2009-07-26  Simon Martin  <simartin@users.sourceforge.net>

        PR c++/40749
        * decl.c (grokdeclarator): Do not set TREE_NO_WARNING for functions
        with a qualified return type.

gcc/testsuite/

2007-07-26  Simon Martin  <simartin@users.sourceforge.net>

        PR c++/40749
        * g++.dg/warn/Wreturn-type-6.C: New test.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/warn/Wreturn-type-6.C
Modified:
    branches/gcc-4_4-branch/gcc/cp/ChangeLog
    branches/gcc-4_4-branch/gcc/cp/decl.c
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3 Regression] g++ doesnt report missing return if return is of type const <type>

[simartin at gcc dot gnu dot org]

------- Comment #6 from simartin at gcc dot gnu dot org  2009-07-26 16:11 -------
Fixed in 4.5 and 4.4. I don't plan to commit this to 4.3.


-- 

simartin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|simartin at gcc dot gnu dot |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW
      Known to fail|4.3.3 4.4.0 4.5.0           |4.3.3 4.4.0
      Known to work|4.2.4                       |4.2.4 4.4.2 4.5.0
            Summary|[4.3/4.4/4.5 Regression] g++|[4.3 Regression] g++ doesnt
                   |doesnt report missing return|report missing return if
                   |if return is of type const  |return is of type const
                   |<type>                      |<type>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3 Regression] g++ doesnt report missing return if return is of type const <type>

[rguenth at gcc dot gnu dot org]

------- Comment #7 from rguenth at gcc dot gnu dot org  2009-08-04 12:30 -------
GCC 4.3.4 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.4                       |4.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3 Regression] g++ doesnt report missing return if return is of type const <type>

[paolo dot carlini at oracle dot com]

------- Comment #8 from paolo dot carlini at oracle dot com  2009-12-26 13:53 -------
Will not be fixed in 4_3-branch.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.3.5                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749

[Bug c++/40749] [4.3 Regression] g++ doesnt report missing return if return is of type const <type>

[paolo dot carlini at oracle dot com]

-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.4.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40749