[Bug lto/40758] New: [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[Bug lto/40758] New: [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rmansfield at qnx dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

I found this one testing arm but it is reproducible with i686-pc-linux-gnu as
well.

ryan@ryan:~/gcc/lto/x86-build/gcc$ ./xgcc -v
Using built-in specs.
COLLECT_GCC=./xgcc
Target: i686-pc-linux-gnu
Configured with: ../configure --enable-languages=c --enable-lto
--disable-bootstrap
Thread model: posix
gcc version 4.5.0 20090714 (experimental) [lto revision 149644] (lto merged
with rev 149625)
ryan@ryan:~/gcc/lto/x86-build/gcc$ ./xgcc -B. ice.i -c -O -flto
ryan@ryan:~/gcc/lto/x86-build/gcc$ ./xgcc -B.  -shared  ice.o  -flto
In file included from :441:0:
ice.i: In function âffb_ctx_scaled_blitâ:
ice.i:4515:1: internal compiler error: in partition_view_bitmap, at
tree-ssa-live.c:331
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
lto-wrapper: ././xgcc returned 1 exit status
collect2: lto-wrapper returned 1 exit status


-- 
           Summary: [LTO] ICE in partition_view_bitmap, at tree-ssa-
                    live.c:331
           Product: gcc
           Version: lto
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rmansfield at qnx dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rmansfield at qnx dot com]

------- Comment #1 from rmansfield at qnx dot com  2009-07-15 02:30 -------
Created an attachment (id=18197)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18197&action=view)
preprocessed source


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2009-07-15 10:54 -------
For me

./xgcc -B.  -shared  ice.o  -flto

takes ages because iterative_hash_gimple_type seems to be exponential in time!?
Called from gimple_register_type on

 <pointer_type 0xb7becb60
    type <function_type 0xb7becbd0
        type <void_type 0xb7cb69a0 VOID
            align 8 symtab 0 alias set -1 canonical type 0xb7cb69a0
            pointer_to_this <pointer_type 0xb7cb6a10>>
        QI
        size <integer_cst 0xb7ca9310 constant 8>
        unit size <integer_cst 0xb7ca932c constant 1>
        align 8 symtab 0 alias set -1 canonical type 0xb7becc40
        arg-types <tree_list 0xb7be99a0 value <pointer_type 0xb7bec000>
            chain <tree_list 0xb7be99bc value <integer_type 0xb7bd50e0
disp_color_t>
                chain <tree_list 0xb7be99d8 value <integer_type 0xb7bd50e0
disp_color_t>
                    chain <tree_list 0xb7be99f4 value <integer_type 0xb7cb6310>
                        chain <tree_list 0xb7be9a10 value <integer_type
0xb7cb6310> chain <tree_list 0xb7be9a2c>>>>>>
        pointer_to_this <pointer_type 0xb7becb60>>
    unsigned SI
    size <integer_cst 0xb7ca9498 type <integer_type 0xb7cb6070 bit_size_type>
constant 32>
    unit size <integer_cst 0xb7ca9284 type <integer_type 0xb7cb6000> constant
4>
    align 32 symtab 0 alias set -1 canonical type 0xb7beccb0>

I guess we should try hashing without duplicates or store the hash somewhere...

I cannot reproduce the ICE btw.  A patch to fix the slowness would be

Index: gimple.c
===================================================================
--- gimple.c    (revision 149668)
+++ gimple.c    (working copy)
@@ -3537,13 +3537,17 @@ gimple_types_compatible_p (tree t1, tree
   return same_p;
 }

-
 /* Returning a hash value for gimple type TYPE combined with VAL.  */

 static hashval_t
 iterative_hash_gimple_type (const_tree type, hashval_t val, unsigned level)
 {
   hashval_t v;
+  void **slot;
+
+  if ((slot = pointer_map_contains (type_hash_cache, type)) != NULL)
+    return iterative_hash_hashval_t (TREE_ADDRESSABLE (type),
+                                    (hashval_t) (size_t) *slot);

   /* Combine a few common features of types so that types are grouped into
      smaller sets; when searching for existing matching types to merge,
@@ -3604,6 +3608,8 @@ iterative_hash_gimple_type (const_tree t
       v = iterative_hash_hashval_t (nf, v);
     }

+  *pointer_map_insert (type_hash_cache, type) = (void *) (size_t) v;
+
   return v;
 }

@@ -3620,28 +3626,13 @@ static hashval_t
 gimple_type_hash (const void *p)
 {
   const_tree type;
-  void **slot;
-  hashval_t v;

   type = (const_tree) p;

   if (type_hash_cache == NULL)
-    {
-      type_hash_cache = pointer_map_create ();
-      slot = NULL;
-    }
-  else
-    slot = pointer_map_contains (type_hash_cache, type);
+    type_hash_cache = pointer_map_create ();

-  if (slot)
-    v = (hashval_t) (size_t) *slot;
-  else
-    {
-      v = iterative_hash_gimple_type (type, 0, 0);
-      *pointer_map_insert (type_hash_cache, type) = (void *) (size_t) v;
-    }
-
-  return v;
+  return iterative_hash_gimple_type (type, 0, 0);
 }


I am going to bootstrap and test a variant of that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rmansfield at qnx dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]



------- Comment #3 from rmansfield at qnx dot com  2009-07-15 12:58 -------
I was able to the ICE using different source. Same usage:

ryan@ryan:~/gcc/lto/x86-build/gcc$ ./xgcc -B. ice2.i -O -flto -c
ryan@ryan:~/gcc/lto/x86-build/gcc$ ./xgcc -B. ice2.o -flto -shared
In file included from :935:0:
ice2.i: In function âvpl_process_verticesâ:
ice2.i:7594:1: internal compiler error: in partition_view_bitmap, at
tree-ssa-live.c:331
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
lto-wrapper: ././xgcc returned 1 exit status
collect2: lto-wrapper returned 1 exit status

I can attach the obj files if it will help reproduce the issue.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rmansfield at qnx dot com]

------- Comment #4 from rmansfield at qnx dot com  2009-07-15 13:02 -------
Created an attachment (id=18202)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18202&action=view)
2nd preprocessed source


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2009-07-15 15:17 -------
Confirmed.  (even with the first testcase, I messed things up)

Maybe non-LTO related.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-07-15 15:17:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2009-07-17 14:52 -------
I'm reducing the first testcase.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rguenth at gcc dot gnu dot org]

------- Comment #7 from rguenth at gcc dot gnu dot org  2009-07-17 15:12 -------
Reduced testcase:

typedef struct disp_surface { unsigned char *vidptr; } disp_surface_t;
void 
ffb_ctx_scaled_blit(disp_surface_t *src, unsigned char *srcwork, int scopy)
{
  unsigned char *sptr = sptr;
  sptr = src->vidptr;
  __builtin_memcpy(srcwork, sptr, scopy);
}

> ./xgcc -B. -c ice.3.i -flto -O -m32
> ./xgcc -B. -shared ice.3.o -flto -m32
In file included from :2:0:
ice.3.i: In function 'ffb_ctx_scaled_blit':
ice.3.i:3:1: internal compiler error: in partition_view_bitmap, at
tree-ssa-live.c:331
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2009-08-26 10:54 -------
The issue here is that during linking we do not optimize which triggers the
path in out-of-ssa coalescing that assumes no overlapping life-ranges are
present.  Which is obviously not true if we optimized during lto generation.

So this is really a middle-end problem.  Honza - what do you suggest to do
here?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[matz at gcc dot gnu dot org]

------- Comment #9 from matz at gcc dot gnu dot org  2009-09-26 01:35 -------
Mine, have patch.  http://gcc.gnu.org/ml/gcc-patches/2009-09/msg01841.html


-- 

matz at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |matz at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-07-15 15:17:35         |2009-09-26 01:35:45
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[matz at gcc dot gnu dot org]

------- Comment #10 from matz at gcc dot gnu dot org  2009-09-26 16:47 -------
Subject: Bug 40758

Author: matz
Date: Sat Sep 26 16:46:43 2009
New Revision: 152203

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=152203
Log:
        PR lto/40758
        PR middle-end/41470
        * tree-ssa-coalesce.c (coalesce_ssa_name): Add only SSA names
        that are mentioned in the body.

testsuite/
        * gcc.dg/pr41470.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr41470.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-coalesce.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[hjl at gcc dot gnu dot org]

------- Comment #11 from hjl at gcc dot gnu dot org  2009-09-28 20:39 -------
Subject: Bug 40758

Author: hjl
Date: Mon Sep 28 20:38:53 2009
New Revision: 152250

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=152250
Log:
2009-09-28  H.J. Lu  <hongjiu.lu@intel.com>

        Backport from mainline:
        2009-09-26  Andreas Schwab  <schwab@linux-m68k.org>

        PR c/41476
        * gcc.dg/cond-constqual-1.c: New test.

        2009-09-26  Michael Matz  <matz@suse.de>

        PR lto/40758
        PR middle-end/41470
        * gcc.dg/pr41470.c: New test.

        2009-09-23  Alexandre Oliva  <aoliva@redhat.com>

        PR debug/41248
        * gcc.dg/pr41248.c: New.

        2009-09-22  Alexandre Oliva  <aoliva@redhat.com>

        PR debug/41295
        * gcc.dg/pr41295.c: New.

        2009-09-20  Andrew Pinski  <pinskia@gcc.gnu.org>

        PR middle-end/40642
        * g++.dg/torture/pr40642.C: New testcase.

        2009-09-17  Michael Matz  <matz@suse.de>

        PR middle-end/41347
        * gfortran.dg/pr41347.f90: New test.

        2009-09-16  Michael Matz  <matz@suse.de>

        PR fortran/41212
        * gfortran.dg/pr41212.f90: New test.

        2009-09-11  Michael Matz  <matz@suse.de>

        PR middle-end/41275
        * g++.dg/tree-ssa/pr41275.C: New test.

        2009-09-11  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/41242
        * gfortran.dg/proc_ptr_comp_21.f90: New.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/torture/pr40642.C
      - copied unchanged from r152249,
trunk/gcc/testsuite/g++.dg/torture/pr40642.C
    branches/gcc-4_4-branch/gcc/testsuite/g++.dg/tree-ssa/pr41275.C
      - copied unchanged from r152249,
trunk/gcc/testsuite/g++.dg/tree-ssa/pr41275.C
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/cond-constqual-1.c
      - copied unchanged from r152248,
trunk/gcc/testsuite/gcc.dg/cond-constqual-1.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr41248.c
      - copied unchanged from r152248, trunk/gcc/testsuite/gcc.dg/pr41248.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr41295.c
      - copied unchanged from r152249, trunk/gcc/testsuite/gcc.dg/pr41295.c
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr41470.c
      - copied unchanged from r152248, trunk/gcc/testsuite/gcc.dg/pr41470.c
    branches/gcc-4_4-branch/gcc/testsuite/gfortran.dg/pr41212.f90
      - copied unchanged from r152249,
trunk/gcc/testsuite/gfortran.dg/pr41212.f90
    branches/gcc-4_4-branch/gcc/testsuite/gfortran.dg/pr41347.f90
      - copied unchanged from r152249,
trunk/gcc/testsuite/gfortran.dg/pr41347.f90
    branches/gcc-4_4-branch/gcc/testsuite/gfortran.dg/proc_ptr_comp_21.f90
      - copied unchanged from r152249,
trunk/gcc/testsuite/gfortran.dg/proc_ptr_comp_21.f90
Modified:
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758

[Bug lto/40758] [LTO] ICE in partition_view_bitmap, at tree-ssa-live.c:331

[rguenth at gcc dot gnu dot org]

------- Comment #12 from rguenth at gcc dot gnu dot org  2009-09-30 15:26 -------
Fixed by merging the patch from trunk.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40758