public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
@ 2010-12-16 13:07 ` rguenth at gcc dot gnu.org
2011-04-28 14:59 ` [Bug libmudflap/40778] [4.5/4.6/4.7 " rguenth at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu.org @ 2010-12-16 13:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.5.2 |4.5.3
--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-12-16 13:02:59 UTC ---
GCC 4.5.2 is being released, adjusting target milestone.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
2010-12-16 13:07 ` [Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function rguenth at gcc dot gnu.org
@ 2011-04-28 14:59 ` rguenth at gcc dot gnu.org
2012-01-13 20:27 ` steven at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-04-28 14:59 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.5.3 |4.5.4
--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-04-28 14:51:14 UTC ---
GCC 4.5.3 is being released, adjusting target milestone.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
2010-12-16 13:07 ` [Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function rguenth at gcc dot gnu.org
2011-04-28 14:59 ` [Bug libmudflap/40778] [4.5/4.6/4.7 " rguenth at gcc dot gnu.org
@ 2012-01-13 20:27 ` steven at gcc dot gnu.org
2012-01-17 11:39 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: steven at gcc dot gnu.org @ 2012-01-13 20:27 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
Steven Bosscher <steven at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING
CC| |steven at gcc dot gnu.org
--- Comment #9 from Steven Bosscher <steven at gcc dot gnu.org> 2012-01-13 20:23:54 UTC ---
I am not seeing these mudflap failures, and it seems I'm not the only one
(http://gcc.gnu.org/ml/gcc-testresults/2012-01/msg01301.html,
http://gcc.gnu.org/ml/gcc-testresults/2012-01/msg01300.html).
Is there a test case that actually fails?
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2012-01-13 20:27 ` steven at gcc dot gnu.org
@ 2012-01-17 11:39 ` jakub at gcc dot gnu.org
2012-01-17 17:02 ` fche at redhat dot com
` (5 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-01-17 11:39 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fche at redhat dot com,
| |jakub at gcc dot gnu.org
--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-17 11:15:34 UTC ---
A fix has been posted but richi wants to do it differently:
http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01331.html
Frank, do you remember why you don't want to instrument DECL_ARTIFICIAL
functions?
Would just DECL_STATIC_CONSTRUCTOR/DECL_STATIC_DESTRUCTOR test be sufficient
instead?
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2012-01-17 11:39 ` jakub at gcc dot gnu.org
@ 2012-01-17 17:02 ` fche at redhat dot com
2012-01-19 19:33 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: fche at redhat dot com @ 2012-01-17 17:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
--- Comment #11 from Frank Ch. Eigler <fche at redhat dot com> 2012-01-17 16:23:15 UTC ---
Jakub's patch makes sense to me in the sense that it's the least modification
over what's there.
Unfortunately, I do not recall what other problems there were with
instrumenting general DECL_ARTIFICIAL !mf_marked_p functions. Perhaps
at the time, there was a problem propagating the mf_marked_p flag.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2012-01-17 17:02 ` fche at redhat dot com
@ 2012-01-19 19:33 ` jakub at gcc dot gnu.org
2012-01-19 19:43 ` [Bug libmudflap/40778] [4.5/4.6 " jakub at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-01-19 19:33 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-19 18:58:06 UTC ---
Author: jakub
Date: Thu Jan 19 18:58:02 2012
New Revision: 183307
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183307
Log:
PR libmudflap/40778
* tree-mudflap.c (mf_artificial): New function.
(execute_mudflap_function_ops, execute_mudflap_function_decls,
mx_register_decls, mudflap_enqueue_decl): Use it.
* testsuite/libmudflap.c/fail68-frag.c: New test.
Added:
trunk/libmudflap/testsuite/libmudflap.c/fail68-frag.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/tree-mudflap.c
trunk/libmudflap/ChangeLog
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2012-01-19 19:33 ` jakub at gcc dot gnu.org
@ 2012-01-19 19:43 ` jakub at gcc dot gnu.org
2012-02-09 17:25 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-01-19 19:43 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |ASSIGNED
Summary|[4.5/4.6/4.7 Regression] |[4.5/4.6 Regression]
|Mudflap instrumentation |Mudflap instrumentation
|missing in cloned function. |missing in cloned function.
--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-19 19:01:30 UTC ---
Fixed on the trunk (so far).
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2012-01-19 19:43 ` [Bug libmudflap/40778] [4.5/4.6 " jakub at gcc dot gnu.org
@ 2012-02-09 17:25 ` jakub at gcc dot gnu.org
2012-02-09 21:40 ` [Bug libmudflap/40778] [4.5 " jakub at gcc dot gnu.org
2012-02-09 21:49 ` jakub at gcc dot gnu.org
9 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-02-09 17:25 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-09 17:24:57 UTC ---
Author: jakub
Date: Thu Feb 9 17:24:47 2012
New Revision: 184056
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184056
Log:
Backported from mainline
2012-01-19 Jakub Jelinek <jakub@redhat.com>
PR libmudflap/40778
* tree-mudflap.c (mf_artificial): New function.
(execute_mudflap_function_ops, execute_mudflap_function_decls,
mx_register_decls, mudflap_enqueue_decl): Use it.
* testsuite/libmudflap.c/fail68-frag.c: New test.
Added:
branches/gcc-4_6-branch/libmudflap/testsuite/libmudflap.c/fail68-frag.c
Modified:
branches/gcc-4_6-branch/gcc/ChangeLog
branches/gcc-4_6-branch/gcc/tree-mudflap.c
branches/gcc-4_6-branch/libmudflap/ChangeLog
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2012-02-09 17:25 ` jakub at gcc dot gnu.org
@ 2012-02-09 21:40 ` jakub at gcc dot gnu.org
2012-02-09 21:49 ` jakub at gcc dot gnu.org
9 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-02-09 21:40 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
--- Comment #15 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-09 21:38:16 UTC ---
Author: jakub
Date: Thu Feb 9 21:38:13 2012
New Revision: 184073
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184073
Log:
Backported from mainline
2012-01-19 Jakub Jelinek <jakub@redhat.com>
PR libmudflap/40778
* tree-mudflap.c (mf_artificial): New function.
(execute_mudflap_function_ops, execute_mudflap_function_decls,
mx_register_decls, mudflap_enqueue_decl): Use it.
* testsuite/libmudflap.c/fail68-frag.c: New test.
Added:
branches/gcc-4_5-branch/libmudflap/testsuite/libmudflap.c/fail68-frag.c
Modified:
branches/gcc-4_5-branch/gcc/ChangeLog
branches/gcc-4_5-branch/gcc/tree-mudflap.c
branches/gcc-4_5-branch/libmudflap/ChangeLog
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2012-02-09 21:40 ` [Bug libmudflap/40778] [4.5 " jakub at gcc dot gnu.org
@ 2012-02-09 21:49 ` jakub at gcc dot gnu.org
9 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-02-09 21:49 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #16 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-09 21:48:50 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
2009-07-16 19:05 [Bug libmudflap/40778] New: " tjruwase at google dot com
` (5 preceding siblings ...)
2010-01-29 14:33 ` hubicka at gcc dot gnu dot org
@ 2010-04-06 11:28 ` rguenth at gcc dot gnu dot org
6 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2010-04-06 11:28 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from rguenth at gcc dot gnu dot org 2010-04-06 11:20 -------
GCC 4.5.0 is being released. Deferring to 4.5.1.
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.5.0 |4.5.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
2009-07-16 19:05 [Bug libmudflap/40778] New: " tjruwase at google dot com
` (4 preceding siblings ...)
2009-08-24 1:04 ` mmitchel at gcc dot gnu dot org
@ 2010-01-29 14:33 ` hubicka at gcc dot gnu dot org
2010-04-06 11:28 ` rguenth at gcc dot gnu dot org
6 siblings, 0 replies; 17+ messages in thread
From: hubicka at gcc dot gnu dot org @ 2010-01-29 14:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from hubicka at gcc dot gnu dot org 2010-01-29 14:33 -------
Yes, the clone_of and similar datastructures are cleared because function is no
longer a virtual clone. Probably best way to get to original function is via
DECL_ABSTRACT_ORIGIN same way as debug info does. Is that sufficient here? (We
can always add some extra flags, but I think we should have enough of them
already. All the other synthetic functions we do not want to instrument won't
have DECL_ABSTRACT_ORIGIN set, right?)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
2009-07-16 19:05 [Bug libmudflap/40778] New: " tjruwase at google dot com
` (3 preceding siblings ...)
2009-08-21 18:33 ` danglin at gcc dot gnu dot org
@ 2009-08-24 1:04 ` mmitchel at gcc dot gnu dot org
2010-01-29 14:33 ` hubicka at gcc dot gnu dot org
2010-04-06 11:28 ` rguenth at gcc dot gnu dot org
6 siblings, 0 replies; 17+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2009-08-24 1:04 UTC (permalink / raw)
To: gcc-bugs
--
mmitchel at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
2009-07-16 19:05 [Bug libmudflap/40778] New: " tjruwase at google dot com
` (2 preceding siblings ...)
2009-07-17 9:44 ` rguenth at gcc dot gnu dot org
@ 2009-08-21 18:33 ` danglin at gcc dot gnu dot org
2009-08-24 1:04 ` mmitchel at gcc dot gnu dot org
` (2 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: danglin at gcc dot gnu dot org @ 2009-08-21 18:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from danglin at gcc dot gnu dot org 2009-08-21 18:33 -------
Also seen on hppa-unknown-linux-gnu.
--
danglin at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |danglin at gcc dot gnu dot
| |org
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2009-08-21 18:33:17
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
2009-07-16 19:05 [Bug libmudflap/40778] New: " tjruwase at google dot com
2009-07-16 19:24 ` [Bug libmudflap/40778] " tjruwase at google dot com
2009-07-17 9:44 ` rguenth at gcc dot gnu dot org
@ 2009-07-17 9:44 ` rguenth at gcc dot gnu dot org
2009-08-21 18:33 ` danglin at gcc dot gnu dot org
` (3 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2009-07-17 9:44 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from rguenth at gcc dot gnu dot org 2009-07-17 09:44 -------
*** Bug 40755 has been marked as a duplicate of this bug. ***
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
2009-07-16 19:05 [Bug libmudflap/40778] New: " tjruwase at google dot com
2009-07-16 19:24 ` [Bug libmudflap/40778] " tjruwase at google dot com
@ 2009-07-17 9:44 ` rguenth at gcc dot gnu dot org
2009-07-17 9:44 ` rguenth at gcc dot gnu dot org
` (4 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2009-07-17 9:44 UTC (permalink / raw)
To: gcc-bugs
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.5.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.
2009-07-16 19:05 [Bug libmudflap/40778] New: " tjruwase at google dot com
@ 2009-07-16 19:24 ` tjruwase at google dot com
2009-07-17 9:44 ` rguenth at gcc dot gnu dot org
` (5 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: tjruwase at google dot com @ 2009-07-16 19:24 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from tjruwase at google dot com 2009-07-16 19:24 -------
The problem is that mudflap avoids instrumenting synthetic functions, i.e
DECL_ARTIFICIAL(decl) . Since cloned functions are synthetic functions, they
are
not instrumented by the 2nd mudflap pass.
A possible fix would be for mudflap to determine that a synthetic function is
actually a clone of a non synthetic function. Unfortunately it is not obvious
to me how to obtain this information, since the relevant field is cleared
immediately after use. For example, cgraph_node(fndecl)->clone_of which points
to the cgraph_node of the original function is cleared once the clone is
materialized in cgraph_materialize_clone() and save_inline_function_body().
Is there a way to identified cloned functions after materialization ?.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2012-02-09 21:49 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-40778-4@http.gcc.gnu.org/bugzilla/>
2010-12-16 13:07 ` [Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function rguenth at gcc dot gnu.org
2011-04-28 14:59 ` [Bug libmudflap/40778] [4.5/4.6/4.7 " rguenth at gcc dot gnu.org
2012-01-13 20:27 ` steven at gcc dot gnu.org
2012-01-17 11:39 ` jakub at gcc dot gnu.org
2012-01-17 17:02 ` fche at redhat dot com
2012-01-19 19:33 ` jakub at gcc dot gnu.org
2012-01-19 19:43 ` [Bug libmudflap/40778] [4.5/4.6 " jakub at gcc dot gnu.org
2012-02-09 17:25 ` jakub at gcc dot gnu.org
2012-02-09 21:40 ` [Bug libmudflap/40778] [4.5 " jakub at gcc dot gnu.org
2012-02-09 21:49 ` jakub at gcc dot gnu.org
2009-07-16 19:05 [Bug libmudflap/40778] New: " tjruwase at google dot com
2009-07-16 19:24 ` [Bug libmudflap/40778] " tjruwase at google dot com
2009-07-17 9:44 ` rguenth at gcc dot gnu dot org
2009-07-17 9:44 ` rguenth at gcc dot gnu dot org
2009-08-21 18:33 ` danglin at gcc dot gnu dot org
2009-08-24 1:04 ` mmitchel at gcc dot gnu dot org
2010-01-29 14:33 ` hubicka at gcc dot gnu dot org
2010-04-06 11:28 ` rguenth at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).