[Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function.

[Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function.

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.2                       |4.5.3

--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-12-16 13:02:59 UTC ---
GCC 4.5.2 is being released, adjusting target milestone.

[Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.3                       |4.5.4

--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-04-28 14:51:14 UTC ---
GCC 4.5.3 is being released, adjusting target milestone.

[Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
                 CC|                            |steven at gcc dot gnu.org

--- Comment #9 from Steven Bosscher <steven at gcc dot gnu.org> 2012-01-13 20:23:54 UTC ---
I am not seeing these mudflap failures, and it seems I'm not the only one 
(http://gcc.gnu.org/ml/gcc-testresults/2012-01/msg01301.html,
http://gcc.gnu.org/ml/gcc-testresults/2012-01/msg01300.html).

Is there a test case that actually fails?

[Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com,
                   |                            |jakub at gcc dot gnu.org

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-17 11:15:34 UTC ---
A fix has been posted but richi wants to do it differently:
http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01331.html
Frank, do you remember why you don't want to instrument DECL_ARTIFICIAL
functions?
Would just DECL_STATIC_CONSTRUCTOR/DECL_STATIC_DESTRUCTOR test be sufficient
instead?

[Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.

[fche at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

--- Comment #11 from Frank Ch. Eigler <fche at redhat dot com> 2012-01-17 16:23:15 UTC ---
Jakub's patch makes sense to me in the sense that it's the least modification
over what's there.  

Unfortunately, I do not recall what other problems there were with
instrumenting general DECL_ARTIFICIAL !mf_marked_p functions.  Perhaps
at the time, there was a problem propagating the mf_marked_p flag.

[Bug libmudflap/40778] [4.5/4.6/4.7 Regression] Mudflap instrumentation missing in cloned function.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-19 18:58:06 UTC ---
Author: jakub
Date: Thu Jan 19 18:58:02 2012
New Revision: 183307

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183307
Log:
    PR libmudflap/40778
    * tree-mudflap.c (mf_artificial): New function.
    (execute_mudflap_function_ops, execute_mudflap_function_decls,
    mx_register_decls, mudflap_enqueue_decl): Use it.

    * testsuite/libmudflap.c/fail68-frag.c: New test.

Added:
    trunk/libmudflap/testsuite/libmudflap.c/fail68-frag.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-mudflap.c
    trunk/libmudflap/ChangeLog

[Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |ASSIGNED
            Summary|[4.5/4.6/4.7 Regression]    |[4.5/4.6 Regression]
                   |Mudflap instrumentation     |Mudflap instrumentation
                   |missing in cloned function. |missing in cloned function.

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-19 19:01:30 UTC ---
Fixed on the trunk (so far).

[Bug libmudflap/40778] [4.5/4.6 Regression] Mudflap instrumentation missing in cloned function.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-09 17:24:57 UTC ---
Author: jakub
Date: Thu Feb  9 17:24:47 2012
New Revision: 184056

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184056
Log:
    Backported from mainline
    2012-01-19  Jakub Jelinek  <jakub@redhat.com>

    PR libmudflap/40778
    * tree-mudflap.c (mf_artificial): New function.
    (execute_mudflap_function_ops, execute_mudflap_function_decls,
    mx_register_decls, mudflap_enqueue_decl): Use it.

    * testsuite/libmudflap.c/fail68-frag.c: New test.

Added:
    branches/gcc-4_6-branch/libmudflap/testsuite/libmudflap.c/fail68-frag.c
Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/tree-mudflap.c
    branches/gcc-4_6-branch/libmudflap/ChangeLog

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

--- Comment #15 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-09 21:38:16 UTC ---
Author: jakub
Date: Thu Feb  9 21:38:13 2012
New Revision: 184073

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184073
Log:
    Backported from mainline
    2012-01-19  Jakub Jelinek  <jakub@redhat.com>

    PR libmudflap/40778
    * tree-mudflap.c (mf_artificial): New function.
    (execute_mudflap_function_ops, execute_mudflap_function_decls,
    mx_register_decls, mudflap_enqueue_decl): Use it.

    * testsuite/libmudflap.c/fail68-frag.c: New test.

Added:
    branches/gcc-4_5-branch/libmudflap/testsuite/libmudflap.c/fail68-frag.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/tree-mudflap.c
    branches/gcc-4_5-branch/libmudflap/ChangeLog

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-09 21:48:50 UTC ---
Fixed.

[Bug libmudflap/40778] New: [4.5 Regression] Mudflap instrumentation missing in cloned function.

[tjruwase at google dot com]

Cloned functions appear not to be properly instrumented by mudflap e.g alloca
is not instrumented.  
This is responsible for the recent regressions in libmudflap testsuite. 
(pass45-frag.c,fail31-frag.c)


-- 
           Summary: [4.5 Regression] Mudflap instrumentation missing in
                    cloned function.
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libmudflap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tjruwase at google dot com
  GCC host triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[tjruwase at google dot com]

------- Comment #1 from tjruwase at google dot com  2009-07-16 19:24 -------
The problem is that mudflap avoids instrumenting synthetic functions, i.e
DECL_ARTIFICIAL(decl) . Since cloned functions are synthetic functions, they
are 
not instrumented by the 2nd mudflap pass.

A possible fix would be for mudflap to determine that a synthetic function is
actually a clone of a non synthetic function. Unfortunately it is not obvious
to me how to obtain this information, since the relevant field is cleared
immediately after use. For example, cgraph_node(fndecl)->clone_of which points
to the cgraph_node of the original function is cleared once the clone is
materialized in cgraph_materialize_clone() and save_inline_function_body(). 

Is there a way to identified cloned functions after materialization ?. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2009-07-17 09:44 -------
*** Bug 40755 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[danglin at gcc dot gnu dot org]

------- Comment #3 from danglin at gcc dot gnu dot org  2009-08-21 18:33 -------
Also seen on hppa-unknown-linux-gnu.


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-08-21 18:33:17
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[hubicka at gcc dot gnu dot org]

------- Comment #4 from hubicka at gcc dot gnu dot org  2010-01-29 14:33 -------
Yes, the clone_of and similar datastructures are cleared because function is no
longer a virtual clone.  Probably best way to get to original function is via
DECL_ABSTRACT_ORIGIN same way as debug info does.  Is that sufficient here? (We
can always add some extra flags, but I think we should have enough of them
already.  All the other synthetic functions we do not want to instrument won't
have DECL_ABSTRACT_ORIGIN set, right?)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778

[Bug libmudflap/40778] [4.5 Regression] Mudflap instrumentation missing in cloned function.

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2010-04-06 11:20 -------
GCC 4.5.0 is being released.  Deferring to 4.5.1.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.0                       |4.5.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40778