[Bug fortran/40941] New: gfc_typespec: put derived, cl and interface into union

[Bug fortran/40941] New: gfc_typespec: put derived, cl and interface into union

[janus at gcc dot gnu dot org]

FIXME item from gfortran.h:

/* Type specification structure.  FIXME: derived and cl could be union???  */
typedef struct
{
  bt type;
  int kind;
  struct gfc_symbol *derived;
  gfc_charlen *cl;      /* For character types only.  */
  struct gfc_symbol *interface; /* For PROCEDURE declarations.  */
  int is_c_interop;
  int is_iso_c;
  bt f90_type; 
}
gfc_typespec;


-- 
           Summary: gfc_typespec: put derived, cl and interface into union
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40941

[Bug fortran/40941] gfc_typespec: put derived, cl and interface into union

[janus at gcc dot gnu dot org]

------- Comment #1 from janus at gcc dot gnu dot org  2009-08-02 13:06 -------
Note: I'm not sure if 'interface' can go into the union too. This might be
problematic if we have a PROCEDURE with an interface whose return value is
CHARACTER or TYPE. (?)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40941

[Bug fortran/40941] gfc_typespec: put derived, cl and interface into union

[janus at gcc dot gnu dot org]

-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |janus at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-08-03 08:07:56
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40941

[Bug fortran/40941] gfc_typespec: put derived and cl into union

[janus at gcc dot gnu dot org]

------- Comment #2 from janus at gcc dot gnu dot org  2009-08-13 19:47 -------
Subject: Bug 40941

Author: janus
Date: Thu Aug 13 19:46:46 2009
New Revision: 150725

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=150725
Log:
2009-08-13  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/40941
        * gfortran.h (gfc_typespec): Put 'derived' and 'cl' into union.
        * decl.c (build_struct): Make sure 'cl' is only used
        if type is BT_CHARACTER.
        * symbol.c (gfc_set_default_type): Ditto.
        * resolve.c (resolve_symbol, resolve_fl_derived): Ditto.
        (resolve_equivalence,resolve_equivalence_derived): Make sure 'derived'
        is only used if type is BT_DERIVED.
        * trans-io.c (transfer_expr): Make sure 'derived' is only used if type
        is BT_DERIVED or BT_INTEGER (special case: C_PTR/C_FUNPTR).
        * array.c: Mechanical replacements to accomodate union in gfc_typespec.
        * check.c: Ditto.
        * data.c: Ditto.
        * decl.c: Ditto.
        * dump-parse-tree.c: Ditto.
        * expr.c: Ditto.
        * interface.c: Ditto.
        * iresolve.c: Ditto.
        * match.c: Ditto.
        * misc.c: Ditto.
        * module.c: Ditto.
        * openmp.c: Ditto.
        * parse.c: Ditto.
        * primary.c: Ditto.
        * resolve.c: Ditto.
        * simplify.c: Ditto.
        * symbol.c: Ditto.
        * target-memory.c: Ditto.
        * trans-array.c: Ditto.
        * trans-common.c: Ditto.
        * trans-const.c: Ditto.
        * trans-decl.c: Ditto.
        * trans-expr.c: Ditto.
        * trans-intrinsic.c: Ditto.
        * trans-io.c: Ditto.
        * trans-stmt.c: Ditto.
        * trans-types.c: Ditto.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/array.c
    trunk/gcc/fortran/check.c
    trunk/gcc/fortran/data.c
    trunk/gcc/fortran/decl.c
    trunk/gcc/fortran/dump-parse-tree.c
    trunk/gcc/fortran/expr.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/iresolve.c
    trunk/gcc/fortran/match.c
    trunk/gcc/fortran/misc.c
    trunk/gcc/fortran/module.c
    trunk/gcc/fortran/openmp.c
    trunk/gcc/fortran/parse.c
    trunk/gcc/fortran/primary.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/simplify.c
    trunk/gcc/fortran/symbol.c
    trunk/gcc/fortran/target-memory.c
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/fortran/trans-common.c
    trunk/gcc/fortran/trans-const.c
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans-intrinsic.c
    trunk/gcc/fortran/trans-io.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans-types.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40941

[Bug fortran/40941] gfc_typespec: put derived and cl into union

[janus at gcc dot gnu dot org]

------- Comment #3 from janus at gcc dot gnu dot org  2009-08-13 19:49 -------
Fixed with r150725. I don't think ts.interface can be incorporated into the
union easily. Therefore I'll close the PR.


-- 

janus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40941