[Bug libgomp/41418] New: Can't build libgomp without --enable-languages=fortran

[Bug libgomp/41418] New: Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

[ ref: http://gcc.gnu.org/ml/gcc/2009-08/msg00085.html ]

> libtool: link: /opt/gcc-tools/i686-pc-cygwin/bin/ar rc .libs/libgomp.lib  alloc.
> o barrier.o critical.o env.o error.o iter.o iter_ull.o loop.o loop_ull.o ordered
> .o parallel.o sections.o single.o task.o team.o work.o lock.o mutex.o proc.o sem
> .o bar.o ptrlock.o time.o fortran.o affinity.o
> /opt/gcc-tools/i686-pc-cygwin/bin/ar: .libs/libgomp.lib: File format not recogni
> zed
> make[4]: *** [libgomp.la] Error 1
> 
> $ file i686-pc-cygwin/libgomp/.libs/libgomp.lib
> i686-pc-cygwin/libgomp/.libs/libgomp.lib: symbolic link to `libgomp-1.dll'

  There's one immediately obvious difference in the generated makefiles between
a bad and a good build:

> -#nodist_finclude_HEADERS = omp_lib.h omp_lib.f90 omp_lib.mod omp_lib_kinds.mod
> +nodist_finclude_HEADERS = omp_lib.h omp_lib.f90 omp_lib.mod omp_lib_kinds.mod

  The good file has the nodist_finclude_HEADERS defined (makes sense), this
adds extra dependencies in the build, and because these files are generated by
running config.status I wonder if there's some kind of either parallel build
missing dependency problem or just a consequence of invoking config.status at a
different time during the build sequence.

  In connection with that, I found an interesting difference when comparing two
config.log files (both from successful builds, as it happens):

@@ -1498,3 +1500,21 @@ toolexeclibdir='$(toolexecdir)/$(gcc_ver
 #define HAVE_SYNC_BUILTINS 1

 configure: exit 0
+
+## ---------------------- ##
+## Running config.status. ##
+## ---------------------- ##
+
+This file was extended by GNU OpenMP Runtime Library config.status 1.0, which
w
as
+generated by GNU Autoconf 2.64.  Invocation command line was
+
+  CONFIG_FILES    =
+  CONFIG_HEADERS  =
+  CONFIG_LINKS    =
+  CONFIG_COMMANDS =
+  $ ./config.status Makefile depfiles
+
+on ubik
+
+config.status:1233: creating Makefile
+config.status:1446: executing depfiles commands

  This also makes me think that there's some uncertainty in exactly how and
where config.status is getting run.


-- 
           Summary: Can't build libgomp without --enable-languages=fortran
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: davek at gcc dot gnu dot org
 GCC build triplet: i686-pc-cygwin
  GCC host triplet: i686-pc-cygwin
GCC target triplet: i686-pc-cygwin


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #1 from davek at gcc dot gnu dot org  2009-09-20 14:57 -------
Created an attachment (id=18616)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18616&action=view)
diffs in generated libtool files

This looks like it might be informative.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #2 from davek at gcc dot gnu dot org  2009-09-20 14:59 -------
Perhaps the two single most salient points from that diff:

 # Is the compiler the GNU compiler?
-with_gcc=no
+with_gcc=yes

 # Whether we are building with GNU ld or not.
-with_gnu_ld="no"
+with_gnu_ld="yes"

Did not having fortran in the mix maybe cause some basic tests of the build
tools/environment to be omitted?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[rwild at gcc dot gnu dot org]

------- Comment #3 from rwild at gcc dot gnu dot org  2009-09-21 07:46 -------
First off, do you happen to know whether this is a regression?
Then, please show more of the build output of the failing build:
everything starting from toplevel target 'configure-target-libgomp'.
You can recreate that with:
  rm -rf i686-pc-cygwin/libgomp
  make configure-target-libgomp all-target-libgomp

The issue is probably some of the configure tests done in libgomp
coming from Libtool and using the Fortran compiler rather than the C
compiler.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #4 from davek at gcc dot gnu dot org  2009-09-21 07:53 -------
(In reply to comment #3)
> First off, do you happen to know whether this is a regression?

  'fraid not, I never thought to try this before.

> Then, please show more of the build output of the failing build:
> everything starting from toplevel target 'configure-target-libgomp'.
> You can recreate that with:
>   rm -rf i686-pc-cygwin/libgomp
>   make configure-target-libgomp all-target-libgomp

  Yep, will have to, I only have "make -j" output around right now.

> The issue is probably some of the configure tests done in libgomp
> coming from Libtool and using the Fortran compiler rather than the C
> compiler.

  I'll get you good-vs-bad logs of configuring and rebuilding target-libgomp
and get back to you later today. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #5 from davek at gcc dot gnu dot org  2009-09-21 17:44 -------
Created an attachment (id=18624)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18624&action=view)
good rebuild log


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #6 from davek at gcc dot gnu dot org  2009-09-21 17:44 -------
Created an attachment (id=18625)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18625&action=view)
bad rebuild log


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[Ralf dot Wildenhues at gmx dot de]

------- Comment #7 from Ralf dot Wildenhues at gmx dot de  2009-09-21 17:51 -------
Subject: Re:  Can't build libgomp without
 --enable-languages=fortran

* davek at gcc dot gnu dot org wrote on Mon, Sep 21, 2009 at 07:44:49PM CEST:
> Created an attachment (id=18625)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18625&action=view)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18625&action=view)
> bad rebuild log

Can you attach the two respective config.log files, too, please?
Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #8 from davek at gcc dot gnu dot org  2009-09-21 17:57 -------
Created an attachment (id=18626)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18626&action=view)
good config log


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #9 from davek at gcc dot gnu dot org  2009-09-21 17:57 -------
Created an attachment (id=18627)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18627&action=view)
bad config log


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[rwild at gcc dot gnu dot org]

------- Comment #10 from rwild at gcc dot gnu dot org  2009-09-21 20:15 -------
Created an attachment (id=18629)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18629&action=view)
proposed patch

Please try out this patch.  The problem is, libtool turns off language compiler
detection reliably only if the variable ($FC) is set to "no" or empty.  But
toplevel sets $GFORTRAN to empty plus then adds all the -B paths.  So this is
kind of a hack.  I'm not sure about a better fix though, and this should be
fairly safe.

I'll submit to gcc-patches if you can confirm that it works.  Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #11 from davek at gcc dot gnu dot org  2009-09-22 11:54 -------
I'll try and get to testing it today, but it'll be late tonight before I can
start, I've got to spend the day doing some binutils stuff.  Will be back in
touch when I know something, thanks for the patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #12 from davek at gcc dot gnu dot org  2009-09-30 21:25 -------

  Bad news: the patch doesn't work.  I edited the generated config.status so
that it would use "bash -x" when reinvoking configure as part of --recheck, and
it seems that although the code goes through the switch and clears FC as you
intended, FC is then reinitialised moments later, during the execution of
AC_PROG_FC(gfortran):

+ MAINT='#'
+ case $GFORTRAN in
+ FC=
+ ac_ext=f
+ ac_compile='$FC -c $FCFLAGS $ac_fcflags_srcext conftest.$ac_ext >&5'
+ ac_link='$FC -o conftest$ac_exeext $FCFLAGS $LDFLAGS $ac_fcflags_srcext
conftest.$ac_ext $LIBS >&5'
+ ac_compiler_gnu=no
+ test -n i686-pc-cygwin-
+ for ac_prog in gfortran
+ set dummy i686-pc-cygwin-gfortran
+ ac_word=i686-pc-cygwin-gfortran
+ printf '%s\n' 'configure:11358: checking for i686-pc-cygwin-gfortran'
+ printf %s 'checking for i686-pc-cygwin-gfortran... '
checking for i686-pc-cygwin-gfortran... + test set = set
+ :
+ printf %s '(cached) '
(cached) + FC=' -B/opt/gcc-tools/i686-pc-cygwin/bin/
-B/opt/gcc-tools/i686-pc-cygwin/lib/ -isystem
/opt/gcc-tools/i686-pc-cygwin/include -isystem
/opt/gcc-tools/i686-pc-cygwin/sys-include   '

and this is the value that FC ends up being assigned in the generated Makefile.

  I'll attach the full log file in a moment.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #13 from davek at gcc dot gnu dot org  2009-09-30 21:26 -------
Created an attachment (id=18680)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18680&action=view)
"bash -x" log of configure script run


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[Ralf dot Wildenhues at gmx dot de]

------- Comment #14 from Ralf dot Wildenhues at gmx dot de  2009-10-05 05:16 -------
Subject: Re:  Can't build libgomp without
 --enable-languages=fortran

* davek at gcc dot gnu dot org wrote on Wed, Sep 30, 2009 at 11:26:26PM CEST:
> ------- Comment #13 from davek at gcc dot gnu dot org  2009-09-30 21:26 -------
> Created an attachment (id=18680)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18680&action=view)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18680&action=view)
> "bash -x" log of configure script run

Hmm, from that I can't gather what $GFORTRAN was set to from the
toplevel.  Do you have a global log?  It should be sufficient to
  rm $target/libgomp/Makefile
  make configure-target-libgomp SHELL=/bin/sh\ -x

Thanks,
Ralf


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #15 from davek at gcc dot gnu dot org  2009-10-07 20:33 -------
Created an attachment (id=18745)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18745&action=view)
global log

(In reply to comment #14)
> Subject: Re:  Can't build libgomp without
>  --enable-languages=fortran
> 
> * davek at gcc dot gnu dot org wrote on Wed, Sep 30, 2009 at 11:26:26PM CEST:
> > ------- Comment #13 from davek at gcc dot gnu dot org  2009-09-30 21:26 -------
> > Created an attachment (id=18680)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18680&action=view) [edit]
> >  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18680&action=view)
> > "bash -x" log of configure script run
> 
> Hmm, from that I can't gather what $GFORTRAN was set to from the
> toplevel.  Do you have a global log?  It should be sufficient to
>   rm $target/libgomp/Makefile
>   make configure-target-libgomp SHELL=/bin/sh\ -x

  Attached.  Sorry about the delay.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[rwild at gcc dot gnu dot org]

------- Comment #16 from rwild at gcc dot gnu dot org  2009-10-08 19:06 -------
Created an attachment (id=18755)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18755&action=view)
(hopefully) better patch

Gah.  Initial white space isn't stripped from the case argument,
I should've known.

Can you try this patch instead?

Thanks,
Ralf


-- 

rwild at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18629|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #17 from davek at gcc dot gnu dot org  2009-10-08 19:37 -------
(In reply to comment #16)
> Created an attachment (id=18755)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18755&action=view) [edit]
> (hopefully) better patch
> 
> Gah.  Initial white space isn't stripped from the case argument,
> I should've known.
> 
> Can you try this patch instead?

ESAMEPATCH!

http://gcc.gnu.org/bugzilla/attachment.cgi?id=18629&action=view
commit 33c578ca6b47a47ecacae017e45fd796022dadc4

http://gcc.gnu.org/bugzilla/attachment.cgi?id=18755&action=view
commit 33c578ca6b47a47ecacae017e45fd796022dadc4

Will wait for you to dig up the correct one, I'm liable to get it wrong if I
try and come up with a properly portable way of stripping whitespace :-)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[rwild at gcc dot gnu dot org]

------- Comment #18 from rwild at gcc dot gnu dot org  2009-10-08 19:57 -------
Created an attachment (id=18756)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18756&action=view)
ditto, but without the d'oh factor

That's what you get when you name one pr-41418 and the other pr41418.
Sorry about that


-- 

rwild at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18755|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #19 from davek at gcc dot gnu dot org  2009-10-10 07:35 -------
(In reply to comment #18)
> Created an attachment (id=18756)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18756&action=view) [edit]
> ditto, but without the d'oh factor
> 
> That's what you get when you name one pr-41418 and the other pr41418.
> Sorry about that

Looks like it works :)  I applied it, rm'd $target/libgomp and then remade
configure-target-libgomp and all-target-libgomp successfully.  I'll set a full
bootstrap going now just for completeness' sake, but the patch looks good to
me, I think you should post it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[davek at gcc dot gnu dot org]

------- Comment #20 from davek at gcc dot gnu dot org  2009-10-10 17:46 -------
(In reply to comment #19)
> I'll set a full
> bootstrap going now just for completeness' sake, 

  Completed and passed check-target-libgomp without incident, by which I mean
it didn't try and run any fortran tests  :)  Thanks Ralf!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[rwild at gcc dot gnu dot org]

------- Comment #21 from rwild at gcc dot gnu dot org  2009-10-17 07:35 -------
Subject: Bug 41418

Author: rwild
Date: Sat Oct 17 07:34:47 2009
New Revision: 152931

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=152931
Log:
Fix libgomp without --enable-languages=fortran.

libgomp/:
        PR libgomp/41418
        * configure.ac: Set FC to "no" if $GFORTRAN starts with "no"
        or a hyphen (happens with fortran language disabled).
        * configure: Regenerate.

Modified:
    trunk/libgomp/ChangeLog
    trunk/libgomp/configure
    trunk/libgomp/configure.ac


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418

[Bug libgomp/41418] Can't build libgomp without --enable-languages=fortran

[rwild at gcc dot gnu dot org]

------- Comment #22 from rwild at gcc dot gnu dot org  2009-10-17 07:37 -------
Fixed.


-- 

rwild at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41418