[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|gcc-bugs at gcc dot gnu.org |

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-09-28 22:56:57 UTC ---
What happened to this? The gcc-patches mailing list is the proper place.

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-01-03 16:37:07 UTC ---
Iain, what's going on with this issue? Are there patches on the mailing list
waiting to be reviewed?

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596

--- Comment #7 from Iain Sandoe <iains at gcc dot gnu.org> 2012-01-03 16:49:25 UTC ---
(In reply to comment #6)
> Iain, what's going on with this issue? Are there patches on the mailing list
> waiting to be reviewed?

well .. I posted it (years?) ago .. and AFAIR,  it didn't get reviewed :-( .. 
... I guess I forgot to chase it.

Now, I think that Joseph would prefer some common code to handle this issue
(since it really affects all the drivers) .. this was discussed briefly when
someone was working on drivers for ObjC/ObjC++ ...

sorry, I don't have time to look at this right now ..

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Iain Sandoe <iains at gcc dot gnu.org> ---
this has been fixed by the improved handling of -static-libstdc++ in r13-4870 
(also in the D and M2 drivers).

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[davek at gcc dot gnu dot org]

------- Comment #4 from davek at gcc dot gnu dot org  2009-12-17 19:58 -------
(In reply to comment #2)
> Created an attachment (id=19339)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19339&action=view) [edit]
> updated patch to allow specification of -static-libstdc++ on the CL while
> generating PCH
> 

The maintainers will probably point out you've got a few bits of stray
formatting there (relative to the gcc coding standard); for example here:

-           {
-             library = library >= 0 ? 2 : library;
-             args[i] |= SKIPOPT;
-           }
+           {
+             library |= library >= 0 ? 2 : library;
+             args[i] |= SKIPOPT;
+           }

you've replaced a leading TAB by eight spaces, where the coding standard wants
all groups of 8 spaces at the start of a line to be real hard TABs.  That may
be something you'll have to fix elsewhere too, I guess your editor probably
gave you spaces for indentation throughout.  The only other nit I noticed was:

-         if (library == 0)
+         if ( library >= 0 && (library & 1) == 0)

an excess space before library there that you might as well tidy up while
you're at it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[developer at sandoe-acoustics dot co dot uk]

------- Comment #3 from developer at sandoe-acoustics dot co dot uk  2009-12-17 19:54 -------
the patch has been modified following the discussions in:
http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00862.html
http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00855.html

to re-write "-static-libstdc++" onto the command line even if the target
supports -BStatic/dynamic.
This allows such targets the option of spec substution.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[developer at sandoe-acoustics dot co dot uk]

------- Comment #2 from developer at sandoe-acoustics dot co dot uk  2009-12-17 19:51 -------
Created an attachment (id=19339)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19339&action=view)
updated patch to allow specification of -static-libstdc++ on the CL while
generating PCH


-- 

developer at sandoe-acoustics dot co dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18715|0                           |1
        is obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596

[Bug c++/41596] handling of library-related options by g++spec.c causes a failure when generating pch.

[developer at sandoe-acoustics dot co dot uk]

------- Comment #1 from developer at sandoe-acoustics dot co dot uk  2009-10-05 20:25 -------
Created an attachment (id=18715)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18715&action=view)
allow specification of -static-libstdc++ on the CL while generating PCH

this patch alters the behavior of g++spec.c such that it 
(a) notes if libstdc++ is needed
(b) notes if the user has requested static-libstdc++

It only outputs "-lstdc++" if the lib is needed- and when it does it decides on
the mechanism depending on the availability of static options. 

Finally, for platforms that don't have Bstatic/Bdynamic - it places
"static-libstdc++" back into the command line so that link specs can use it to
trigger substitution.

log:
      *gcc/cp/g++spec.c(lang_specific_driver): Do not insert -lstdc++ unless we
really need it.  
       Insert 'static-libstdc++' for platforms without Bstatic/Bdynamic to
allow link spec substitution.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596