[Bug tree-optimization/41881] [4.5/4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[Bug tree-optimization/41881] [4.5/4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.2                       |4.5.3

--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-12-16 13:03:20 UTC ---
GCC 4.5.2 is being released, adjusting target milestone.

[Bug tree-optimization/41881] [4.5/4.6/4.7 regression] Complete unrolling (inner) versus vectorization of reduction

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.3                       |4.5.4

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-04-28 14:51:36 UTC ---
GCC 4.5.3 is being released, adjusting target milestone.

[Bug tree-optimization/41881] [4.5/4.6/4.7 regression] Complete unrolling (inner) versus vectorization of reduction

[irar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

--- Comment #10 from irar at gcc dot gnu.org 2011-05-18 11:27:56 UTC ---
Author: irar
Date: Wed May 18 11:27:51 2011
New Revision: 173856

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=173856
Log:


        PR tree-optimization/41881
        * tree-vectorizer.h (struct _loop_vec_info): Add new field
        reduction_chains along with a macro for its access.
        * tree-vect-loop.c (new_loop_vec_info): Initialize
        reduction chains.
        (destroy_loop_vec_info): Free reduction chains.
        (vect_analyze_loop_2): Return false if
        vect_analyze_slp() returns false.
        (vect_is_slp_reduction): New function.
        (vect_is_simple_reduction_1): Call
        vect_is_slp_reduction.
        (vect_create_epilog_for_reduction): Support SLP
        reduction chains.
        * tree-vect-slp.c (vect_get_and_check_slp_defs): Allow
        different definition types for reduction chains.
        (vect_supported_load_permutation_p): Don't allow
        permutations for reduction chains.
        (vect_analyze_slp_instance): Support reduction chains.
        (vect_analyze_slp): Try to build SLP instance from
        reduction chains.
        (vect_get_constant_vectors):  Handle reduction chains.
        (vect_schedule_slp_instance): Mark the first statement
        of the reduction chain as reduction.


Added:
    trunk/gcc/testsuite/gcc.dg/vect/O3-pr41881.c
    trunk/gcc/testsuite/gcc.dg/vect/O3-slp-reduc-10.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-vect-loop.c
    trunk/gcc/tree-vect-slp.c
    trunk/gcc/tree-vectorizer.h

[Bug tree-optimization/41881] [4.5/4.6/4.7 regression] Complete unrolling (inner) versus vectorization of reduction

[irar at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

Ira Rosen <irar at il dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irar at il dot ibm.com

--- Comment #11 from Ira Rosen <irar at il dot ibm.com> 2011-05-18 11:51:41 UTC ---
This patch enables vectorization of reduction in SLP making the unrolled loop
in fun2 vectorizable.

[Bug tree-optimization/41881] [4.5/4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
            Summary|[4.5/4.6/4.7 regression]    |[4.5/4.6 regression]
                   |Complete unrolling (inner)  |Complete unrolling (inner)
                   |versus vectorization of     |versus vectorization of
                   |reduction                   |reduction

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-05 17:14:11 UTC ---
Fixed on the trunk, thanks.

[Bug tree-optimization/41881] [4.5/4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.4                       |4.6.4

--- Comment #13 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-07-02 11:37:51 UTC ---
The 4.5 branch is being closed, adjusting target milestone.

[Bug tree-optimization/41881] [4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.6.4                       |4.7.0

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-12 16:17:46 UTC ---
The 4.6 branch has been closed, fixed in GCC 4.7.0.

[Bug tree-optimization/41881] [4.5/4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

[Bug tree-optimization/41881] [4.5/4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[irar at il dot ibm dot com]

------- Comment #7 from irar at il dot ibm dot com  2010-08-11 10:24 -------
(In reply to comment #6)
> I think that SLP doesn't handle reduction.
> 

Not all kinds of reduction. We handle

#a1 = phi <a0, a2>
#b1 = phi <b0, b2>
...
a2 = a1 + x
b2 = b1 + y

Here we also have:
#a1 = phi <a0, a9>
...
a2 = a1 + x
...
a3 = a2 + y
...

a9 = a8 + z


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

[Bug tree-optimization/41881] [4.5/4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2010-08-11 09:28 -------
I think that SLP doesn't handle reduction.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881

[Bug tree-optimization/41881] [4.5/4.6 regression] Complete unrolling (inner) versus vectorization of reduction

[drow at gcc dot gnu dot org]

------- Comment #5 from drow at gcc dot gnu dot org  2010-08-10 16:01 -------
Verified on x86_64 using:

gcc-4.3 -O3 -o 43.s -S reduc.c -ftree-vectorizer-verbose=1
[two loops vectorized]
gcc-4.4 -O3 -o 43.s -S reduc.c -ftree-vectorizer-verbose=1
[one loop vectorized]


-- 

drow at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irar at gcc dot gnu dot org
      Known to fail|                            |4.4.4
      Known to work|                            |4.3.5
            Summary|Complete unrolling (inner)  |[4.5/4.6 regression]
                   |versus vectorization of     |Complete unrolling (inner)
                   |reduction                   |versus vectorization of
                   |                            |reduction


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41881