[Bug ada/41912] New: FAIL: gnat.dg/null_pointer_deref1.adb execution test

[Bug ada/41912] New: FAIL: gnat.dg/null_pointer_deref1.adb execution test

[danglin at gcc dot gnu dot org]

Executing on host: /home/dave/gnu/gcc-4.5/objdir/gcc/gnatmake
--GCC=/home/dave/g
nu/gcc-4.5/objdir/gcc/xgcc
--GNATBIND=/home/dave/gnu/gcc-4.5/objdir/gcc/gnatbind
 --GNATLINK=/home/dave/gnu/gcc-4.5/objdir/gcc/gnatlink -cargs
-B/home/dave/gnu/g
cc-4.5/objdir/gcc -largs --LINK=/home/dave/gnu/gcc-4.5/objdir/gcc/xgcc
-B/home/d
ave/gnu/gcc-4.5/objdir/gcc -margs
--RTS=/home/dave/gnu/gcc-4.5/objdir/hppa-linux
/./libada -q -f
/home/dave/gnu/gcc-4.5/gcc/gcc/testsuite/gnat.dg/null_pointer_de
ref1.adb   -gnatp  -lm   -o ./null_pointer_deref1.exe    (timeout = 300)
PASS: gnat.dg/null_pointer_deref1.adb (test for excess errors)
Setting LD_LIBRARY_PATH to
.:/home/dave/gnu/gcc-4.5/objdir/gcc::/home/dave/gnu/g
cc-4.5/objdir/gcc:/home/dave/gnu/gcc-4.5/objdir/hppa-linux/libstdc++-v3/.libs:/h
ome/dave/gnu/gcc-4.5/objdir/hppa-linux/libmudflap/.libs:/home/dave/gnu/gcc-4.5/o
bjdir/hppa-linux/libssp/.libs:/home/dave/gnu/gcc-4.5/objdir/hppa-linux/libgomp/.
libs:/home/dave/gnu/gcc-4.5/objdir/./gcc:/home/dave/gnu/gcc-4.5/objdir/./prev-gc
c
FAIL: gnat.dg/null_pointer_deref1.adb execution test

dave@hiauly6:~/gnu/gcc/objdir/gcc$ ./xgcc -B./ -v
Reading specs from ./specs
COLLECT_GCC=./xgcc
COLLECT_LTO_WRAPPER=./lto-wrapper
Target: hppa-linux
Configured with: ../gcc/configure --with-gnu-as --with-gnu-ld --enable-shared
--prefix=/home/dave/opt/gnu/gcc/gcc-4.5.0
--with-local-prefix=/home/dave/opt/gnu --enable-threads=posix
--enable-__cxa_atexit --build=hppa-linux --enable-clocale=gnu
--enable-java-gc=boehm --enable-java-awt=xlib
--enable-languages=c,c++,objc,fortran,obj-c++,java,ada
--with-libelf=/home/dave/opt/gnu
Thread model: posix
gcc version 4.5.0 20091102 (experimental) [trunk revision 153799] (GCC)


-- 
           Summary: FAIL: gnat.dg/null_pointer_deref1.adb execution test
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa-unknown-linux-gnu
  GCC host triplet: hppa-unknown-linux-gnu
GCC target triplet: hppa-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #1 from ebotcazou at gcc dot gnu dot org  2009-11-02 19:34 -------
Laurent is working on it.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurent at guerby dot net,
                   |                            |ebotcazou at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-11-02 19:34:21
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #2 from ebotcazou at gcc dot gnu dot org  2009-11-09 17:11 -------
I see that it fails on HP-UX as well.  That's probably because there is
something missing in the fallback routines in config/pa, namely:

  fs->signal_frame = 1;

just before

 return _URC_NO_REASON;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #3 from dave at hiauly1 dot hia dot nrc dot ca  2009-11-13 14:20 -------
Subject: Re:  FAIL: gnat.dg/null_pointer_deref1.adb execution test

> I see that it fails on HP-UX as well.  That's probably because there is
> something missing in the fallback routines in config/pa, namely:
> 
>   fs->signal_frame = 1;
> 
> just before
> 
>  return _URC_NO_REASON;

This is an interesting suggestion.  However, the results in doing
this are mixed.  It fixes the current testcase on hpux but not linux.
It fixes three libjava fails on linux.  However, it introduces four
fails on both hpux and linux.  For example,

Executing on host:
/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libjava/testsuite/
../libtool --silent --tag=GCJ --mode=link /test/gnu/gcc/objdir/./gcc/gcj
-B/test
/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libjava/ -B/test/gnu/gcc/objdir/./gcc/
-B/
opt/gnu/gcc/gcc-4.5.0/hppa2.0w-hp-hpux11.11/bin/
-B/opt/gnu/gcc/gcc-4.5.0/hppa2.
0w-hp-hpux11.11/lib/ -isystem
/opt/gnu/gcc/gcc-4.5.0/hppa2.0w-hp-hpux11.11/inclu
de -isystem /opt/gnu/gcc/gcc-4.5.0/hppa2.0w-hp-hpux11.11/sys-include   
--encodi
ng=UTF-8 -B/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libjava/testsuite/../
/tes
t/gnu/gcc/gcc/libjava/testsuite/libjava.lang/Array_3.jar  -w  -no-install
--main
=Array_3 -g  -L/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/./libjava/.libs -lm
-o /test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libjava/testsuite/Array_3.exe   
(
timeout = 300)
PASS: Array_3 compilation from source
set_ld_library_path_env_vars:
ld_library_path=.:/test/gnu/gcc/objdir/hppa2.0w-hp
-hpux11.11/./libjava/.libs
invoke:
/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libjava/testsuite/Array_3.exe

Setting LD_LIBRARY_PATH to
.:/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/./libjav
a/.libs:.:/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/./libjava/.libs
Exception in thread "main" java.lang.NullPointerException
   at Array_3.main(Array_3.java:30)
FAIL: Array_3 execution - source compiled test
UNTESTED: Array_3 output - source compiled test

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #4 from ebotcazou at gcc dot gnu dot org  2009-11-13 17:37 -------
> This is an interesting suggestion.  However, the results in doing
> this are mixed.  It fixes the current testcase on hpux but not linux.

Yes, you additionally need this for Linux:

2009-11-12  Eric Botcazou  <ebotcazou@adacore.com>
            Laurent GUERBY  <laurent@guerby.net>

        * init.c (GNU/Linux Section): Enable for all architectures.

> It fixes three libjava fails on linux.  However, it introduces four
> fails on both hpux and linux.  

Interesting.  gnat.dg/null_pointer_deref1.adb is the ultimate test for this
null pointer thing because the EH region contains exactly 1 instruction:

.LEHB1:
        stw %r19,0(%r28)
.LEHE1:

so the unwinder must be extremely accurate when comparing return addresses.
Setting fs->signal_frame = 1 will instruct it not to subtract 1 anymore to
determine whether the RA belongs to an active EH region.  See the very similar
code in libjava/exception.cc and ada/raise-gcc.c around _Unwind_GetIPInfo.

Not clear what is happening though.  Could you attach the assembly code for one
Java test that used to fail and now passes and for another Java test with the
opposite behavior?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #5 from ebotcazou at gcc dot gnu dot org  2009-11-13 17:55 -------
Investigating.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|ebotcazou at gcc dot gnu dot|
                   |org                         |
         AssignedTo|unassigned at gcc dot gnu   |ebotcazou at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-11-02 19:34:21         |2009-11-13 17:55:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #6 from ebotcazou at gcc dot gnu dot org  2009-12-03 18:53 -------
Dave, do you happen to have a java-enabled build around?  If so, could you
attach the assembly generated for libjava.lang/Array_3 since it's very likely
the problematic test?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #7 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-03 19:30 -------
Subject: Re:  FAIL: gnat.dg/null_pointer_deref1.adb execution test

> Dave, do you happen to have a java-enabled build around?  If so, could you
> attach the assembly generated for libjava.lang/Array_3 since it's very likely
> the problematic test?

I don't have one handy.  I was trying to debug this fail but started
a new build this morning.  I'll attach the assembly when available.

The catch for the first null pointer exception in libjava.lang/Array_3
is not caught but I don't know why.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #8 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-03 20:58 -------
Subject: Re:  FAIL: gnat.dg/null_pointer_deref1.adb
        execution test

Attached .s from hppa-unknown-linux-gnu target.


------- Comment #9 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-03 20:58 -------
Created an attachment (id=19220)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19220&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #10 from ebotcazou at gcc dot gnu dot org  2009-12-04 09:52 -------
> The catch for the first null pointer exception in libjava.lang/Array_3
> is not caught but I don't know why.

Very likely because of the adjustment made in libjava/pa-signal.h:

#define MAKE_THROW_FRAME(_exception)                            \
do                                                              \
{                                                               \
  struct ucontext *uc = (struct ucontext *)arg;                 \
  struct sigcontext *sc = &uc->uc_mcontext;                     \
  (void)_dummy;                                                 \
  (void)_info;                                                  \
  /* Advance the program counter so that it is after the start  \
     of the instruction:  the exception handler expects         \
     the PC to point to the instruction after a call. */        \
  sc->sc_iaoq[0] = sc->sc_iaoq[1];                              \
  sc->sc_iaoq[1] += 4;                                          \
}                                                               \
while (0)

That's not true if you set fs->signal_frame to 1 in the fallback routine.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #11 from ebotcazou at gcc dot gnu dot org  2009-12-04 09:58 -------
> Very likely because of the adjustment made in libjava/pa-signal.h:

libjava/hppa-signal contains a slight variant:

#define MAKE_THROW_FRAME(_exception)                                    \
do                                                                      \
{                                                                       \
  ucontext_t *_context = (ucontext_t *) arg;                            \
  (void)_dummy;                                                         \
  (void)_info;                                                          \
  mcontext_t *mc = &(_context->uc_mcontext);                            \
  SetSSReg (mc, ss_pcoq_head, GetSSReg (mc, ss_pcoq_tail));             \
  SetSSReg (mc, ss_pcsq_head, GetSSReg (mc, ss_pcsq_tail));             \
  /* This part is not quit right if the head pc was pointing            \
     at a branch.  The tail needs to be adjusted to the branch          \
     target if the branch is taken.  The tail space register            \
     may need adjustment as well if the branch is an interspace         \
     branch.  */                                                        \
  SetSSReg (mc, ss_pcoq_tail, (GetSSReg (mc, ss_pcoq_tail) + 4));       \
                                                                        \
 }                                                                      \
while (0)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #12 from ebotcazou at gcc dot gnu dot org  2009-12-04 10:18 -------
> That's not true if you set fs->signal_frame to 1 in the fallback routine.

And I need to do the same clean-up in include/dwarf2-signal.h and
include/sparc-signal.h for SPARC...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #13 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-04 23:45 -------
Subject: Re:  FAIL: gnat.dg/null_pointer_deref1.adb
        execution test

On Fri, 04 Dec 2009, ebotcazou at gcc dot gnu dot org wrote:

> 
> 
> ------- Comment #10 from ebotcazou at gcc dot gnu dot org  2009-12-04 09:52 -------
> > The catch for the first null pointer exception in libjava.lang/Array_3
> > is not caught but I don't know why.
> 
> Very likely because of the adjustment made in libjava/pa-signal.h:
> 
> #define MAKE_THROW_FRAME(_exception)                            \
> do                                                              \
> {                                                               \
>   struct ucontext *uc = (struct ucontext *)arg;                 \
>   struct sigcontext *sc = &uc->uc_mcontext;                     \
>   (void)_dummy;                                                 \
>   (void)_info;                                                  \
>   /* Advance the program counter so that it is after the start  \
>      of the instruction:  the exception handler expects         \
>      the PC to point to the instruction after a call. */        \
>   sc->sc_iaoq[0] = sc->sc_iaoq[1];                              \
>   sc->sc_iaoq[1] += 4;                                          \
> }                                                               \
> while (0)
> 
> That's not true if you set fs->signal_frame to 1 in the fallback routine.

The attached change seems to fix the Array_3 linux fail.  Testing a
similar change for hpux.  However, need to fix the following warnings:

../../../gcc/libjava/prims.cc:178:1: warning: unused parameter
'_dummy'../../../gcc/libjava/prims.cc:178:1: warning: unused parameter
'_info'../../../gcc/libjava/prims.cc:178:1: warning: unused parameter 'arg'

Dave


------- Comment #14 from dave at hiauly1 dot hia dot nrc dot ca  2009-12-04 23:45 -------
Created an attachment (id=19230)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19230&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #15 from ebotcazou at gcc dot gnu dot org  2009-12-05 11:34 -------
> The attached change seems to fix the Array_3 linux fail.  Testing a
> similar change for hpux.  However, need to fix the following warnings:
> 
> ../../../gcc/libjava/prims.cc:178:1: warning: unused parameter
> '_dummy'../../../gcc/libjava/prims.cc:178:1: warning: unused parameter
> '_info'../../../gcc/libjava/prims.cc:178:1: warning: unused parameter 'arg'

include/sparc-signal.h has:

#define SIGNAL_HANDLER(_name)                                           \
static void _name (int _dummy __attribute__ ((__unused__)), \
                   siginfo_t *_info __attribute__ ((__unused__)), \
                   void *arg __attribute__ ((__unused__)))


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[danglin at gcc dot gnu dot org]

------- Comment #16 from danglin at gcc dot gnu dot org  2009-12-05 17:46 -------
Subject: Bug 41912

Author: danglin
Date: Sat Dec  5 17:45:59 2009
New Revision: 155013

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155013
Log:
        PR ada/41912
        * pa/linux-unwind.h (pa32_fallback_frame_state): Set fs->signal_frame
        for signal frames.
        * pa/hpux-unwind.h (pa32_fallback_frame_state): Likewise.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/pa/hpux-unwind.h
    trunk/gcc/config/pa/linux-unwind.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[ebotcazou at gcc dot gnu dot org]

------- Comment #17 from ebotcazou at gcc dot gnu dot org  2009-12-05 18:32 -------
Patch installed.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2009-
                   |                            |12/msg00315.html
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[danglin at gcc dot gnu dot org]

------- Comment #18 from danglin at gcc dot gnu dot org  2010-04-09 01:41 -------
Subject: Bug 41912

Author: danglin
Date: Fri Apr  9 01:40:47 2010
New Revision: 158146

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158146
Log:
        Backport from mainline:
        2009-12-05  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>

        PR ada/41912
        * pa/linux-unwind.h (pa32_fallback_frame_state): Set fs->signal_frame
        for signal frames.
        * pa/hpux-unwind.h (pa32_fallback_frame_state): Likewise.


Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/config/pa/hpux-unwind.h
    branches/gcc-4_4-branch/gcc/config/pa/linux-unwind.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912

[Bug ada/41912] FAIL: gnat.dg/null_pointer_deref1.adb execution test

[danglin at gcc dot gnu dot org]

------- Comment #19 from danglin at gcc dot gnu dot org  2010-04-10 00:34 -------
Subject: Bug 41912

Author: danglin
Date: Sat Apr 10 00:34:05 2010
New Revision: 158183

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158183
Log:
        Backport from mainline:
        2009-12-05  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>

        PR ada/41912
        * pa/linux-unwind.h (pa32_fallback_frame_state): Set fs->signal_frame
        for signal frames.
        * pa/hpux-unwind.h (pa32_fallback_frame_state): Likewise.


Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/config/pa/hpux-unwind.h
    branches/gcc-4_3-branch/gcc/config/pa/linux-unwind.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41912