[Bug c++/42056] ICE with invalid use of auto in template

[Bug c++/42056] ICE with invalid use of auto in template

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-05-26 16:14:51 UTC ---
To summarize, in current 4.6 and mainline at least, a C++0x warning is emitted
in C++03 mode and then both snippets are simply accepted. Errors are then
produced at instantiation time. Indeed, cp_parser_simple_type_specifier does
just:

    case RID_AUTO:
      maybe_warn_cpp0x (CPP0X_AUTO);
      type = make_auto ();
      break;

thus, by design, no chances for hard errors at parsing time. Jason, do we want
to improve this?

[Bug c++/42056] ICE with invalid use of auto in template

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.05.26 16:23:02
     Ever Confirmed|0                           |1

--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> 2011-05-26 16:23:02 UTC ---
Sounds like build_functional_cast should check type_uses_auto.

[Bug c++/42056] ICE with invalid use of auto in template

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-05-26 16:48:01 UTC ---
Eh, I decided to ask when I saw your fix for 48599 involving type_uses_auto ;)
Anyway, the below indeed appears to work pretty well. Is the error message Ok
with you?


Index: typeck2.c
===================================================================
--- typeck2.c   (revision 174295)
+++ typeck2.c   (working copy)
@@ -1590,6 +1590,14 @@ build_functional_cast (tree exp, tree parms, tsubs
   else
     type = exp;

+  if (type_uses_auto (type))
+    {
+      if (complain & tf_error)
+       error ("expected an expression");
+      else
+       return error_mark_node;
+    }
+
   /* We need to check this explicitly, since value-initialization of
      arrays is allowed in other situations.  */
   if (TREE_CODE (type) == ARRAY_TYPE)

[Bug c++/42056] ICE with invalid use of auto in template

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|paolo.carlini at oracle dot |
                   |com                         |
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com

[Bug c++/42056] ICE with invalid use of auto in template

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-05-26 18:01:42 UTC ---
Actually, I can do better.

[Bug c++/42056] ICE with invalid use of auto in template

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

--- Comment #6 from Jason Merrill <jason at gcc dot gnu.org> 2011-05-26 18:25:40 UTC ---
(In reply to comment #4)
> +       error ("expected an expression");

That sounds like a parse error, when the real issue is a semantic constraint
violation: it would make perfect sense to write auto(1) except that 7.1.6.4
says we can't.

[Bug c++/42056] ICE with invalid use of auto in template

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-05-26 19:29:05 UTC ---
I see, agreed. Actual patch posted here:

  http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02081.html

[Bug c++/42056] ICE with invalid use of auto in template

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

--- Comment #8 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-05-27 14:21:39 UTC ---
Author: paolo
Date: Fri May 27 14:21:33 2011
New Revision: 174337

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=174337
Log:
/cp
2011-05-27  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/42056
    * typeck2.c (build_functional_cast): Complain early for invalid uses
    of 'auto' and set type to error_mark_node.

/testsuite
2011-05-27  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/42056
    * testsuite/g++.dg/cpp0x/auto25.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/auto25.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck2.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/42056] ICE with invalid use of auto in template

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-05-27 14:23:15 UTC ---
Fixed for 4.7.0.

[Bug c++/42056] ICE with invalid use of auto in template

[paolo dot carlini at oracle dot com]

------- Comment #1 from paolo dot carlini at oracle dot com  2010-05-04 16:32 -------
Apparently now *both* snippets are wrongly accepted, at least in mainline.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42056