[Bug bootstrap/42068] New: [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[Bug bootstrap/42068] New: [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[ro at gcc dot gnu dot org]

Between 20091106 and 20091113 (rev 154146), bootstrap of both alpha-dec-osf4.0f
and alpha-dec-osf5.1b failed in stage2 compiling ada/s-bitops.adb:

% /tmp_mnt/vol/gcc/obj/gcc-4.5.0-20091113/4.0f-gcc/./prev-gcc/xgcc
-B/tmp_mnt/vol/gcc/obj/gcc-4.5.0-20091113/4.0f-gcc/./prev-gcc/
-B/vol/gcc/alpha-dec-osf4.0f/bin/ -B/vol/gcc/alpha-dec-osf4.0f/bin/
-B/vol/gcc/alpha-dec-osf4.0f/lib/ -isystem /vol/gcc/alpha-dec-osf4.0f/include
-isystem /vol/gcc/alpha-dec-osf4.0f/sys-include    -c -g -O2  -gnatpg -gnata
-nostdinc -I- -I. -Iada -I/vol/gcc/src/gcc-dist/gcc/ada
-I/vol/gcc/src/gcc-dist/gcc/ada/gcc-interface
/vol/gcc/src/gcc-dist/gcc/ada/s-bitops.adb -o ada/s-bitops.o
+===========================GNAT BUG DETECTED==============================+
| 4.5.0 20091113 (experimental) [trunk revision 154146] (alpha-dec-osf4.0f) GCC
error:|
| in function_and_variable_visibility, at ipa.c:322                        |
| Error detected around /vol/gcc/src/gcc-dist/gcc/ada/s-bitops.adb:215:1   |
| Please submit a bug report; see http://gcc.gnu.org/bugs.html.            |
| Use a subject line meaningful to you and us to track the bug.            |
| Include the entire contents of this bug box in the report.               |
| Include the exact gcc or gnatmake command that you entered.              |
| Also include sources listed below in gnatchop format                     |
| (concatenated together with no headers between files).                   |
+==========================================================================+

Please include these source files with error report
Note that list may not be accurate in some cases,
so please double check that the problem can still
be reproduced with the set of files listed.
Consider also -gnatd.n switch (see debug.adb).

/vol/gcc/src/gcc-dist/gcc/ada/system.ads
/vol/gcc/src/gcc-dist/gcc/ada/s-bitops.adb
/vol/gcc/src/gcc-dist/gcc/ada/s-bitops.ads
/vol/gcc/src/gcc-dist/gcc/ada/s-unstyp.ads
/vol/gcc/src/gcc-dist/gcc/ada/ada.ads
/vol/gcc/src/gcc-dist/gcc/ada/a-unccon.ads


raised TYPES.UNRECOVERABLE_ERROR : comperr.adb:423
make[3]: *** [ada/s-bitops.o] Error 1

This is most likely due to one of Jan's recent commits.


-- 
           Summary: [4.5 regression] ICE in function_and_variable_visibility
                    breaks Tru64 UNIX Ada bootstrap
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ro at gcc dot gnu dot org
 GCC build triplet: alpha-dec-osf*
  GCC host triplet: alpha-dec-osf*
GCC target triplet: alpha-dec-osf*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug bootstrap/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
   Target Milestone|---                         |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug bootstrap/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #1 from ebotcazou at gcc dot gnu dot org  2009-11-19 12:26 -------
Created an attachment (id=19048)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19048&action=view)
Reduced testcase

To be gnatchop-ed and cross-compiled.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug bootstrap/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #2 from ebotcazou at gcc dot gnu dot org  2009-11-19 12:31 -------
> This is most likely due to one of Jan's recent commits.

Right, r154121 changed

      gcc_assert ((!DECL_WEAK (vnode->decl) || DECL_COMMON (vnode->decl))
                  || TREE_PUBLIC (vnode->decl) || DECL_EXTERNAL (node->decl));

to

      gcc_assert ((!DECL_WEAK (vnode->decl) && !DECL_COMMON (vnode->decl) &&
!DECL_COMDAT (vnode->decl))
                  || TREE_PUBLIC (vnode->decl) || DECL_EXTERNAL (node->decl));

and r154128 didn't really fix the "accidental commit":

      gcc_assert ((!DECL_WEAK (vnode->decl) && !DECL_COMMON (vnode->decl))
                 || TREE_PUBLIC (vnode->decl) || DECL_EXTERNAL (vnode->decl));

Please, Jan, fix the breakage ASAP.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-11-19 12:31:17
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug bootstrap/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2009-11-27 11:20 -------
Is this still an issue?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug bootstrap/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug bootstrap/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[ro at CeBiTec dot Uni-Bielefeld dot DE]

------- Comment #4 from ro at CeBiTec dot Uni-Bielefeld dot DE  2009-12-11 17:25 -------
Subject: Re:  [4.5 regression] ICE in function_and_variable_visibility breaks
Tru64 UNIX Ada bootstrap

> ------- Comment #3 from rguenth at gcc dot gnu dot org  2009-11-27 11:20 -------
> Is this still an issue?

Yes, the problem still exists on alpha-dec-osf4.0f as of 20091210.

     Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug bootstrap/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #5 from ebotcazou at gcc dot gnu dot org  2009-12-26 19:44 -------
Jan, you're responsible for fixing things you broke.  There is a reduced
testcase and the ICE can be reproduced with a cross on x86_64-linux.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2009-11-19 12:31:17         |2009-12-26 19:44:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug bootstrap/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[rupp at gnat dot com]

------- Comment #6 from rupp at gnat dot com  2009-12-26 21:18 -------
ICE on alpha64-dec-openvms* with 20091224 sources.


-- 

rupp at gnat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rupp at gnat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Tru64 UNIX Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #7 from ebotcazou at gcc dot gnu dot org  2010-01-06 22:43 -------
*** Bug 42627 has been marked as a duplicate of this bug. ***


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon at pushface dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #8 from ebotcazou at gcc dot gnu dot org  2010-01-06 22:45 -------
ICE on x86_64-apple-darwin10 too.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|alpha-dec-osf*              |
   GCC host triplet|alpha-dec-osf*              |
 GCC target triplet|alpha-dec-osf*              |
   Last reconfirmed|2010-01-06 07:13:28         |2010-01-06 22:45:21
               date|                            |
            Summary|[4.5 regression] ICE in     |[4.5 regression] ICE in
                   |function_and_variable_visibi|function_and_variable_visibi
                   |lity breaks Tru64 UNIX Ada  |lity breaks Ada bootstrap
                   |bootstrap                   |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|2010-01-06 22:46:02         |2010-01-06 22:48:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #9 from ebotcazou at gcc dot gnu dot org  2010-01-11 11:27 -------
Jan, are you there?


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at ucw dot cz


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[simon at pushface dot org]

------- Comment #10 from simon at pushface dot org  2010-01-11 22:12 -------
I have (locally!) rolled back the change to ipa.c in r154121 as suggested and
successfully built a compiler which successfully compiles the test case in
p.txt. Will that be an adequate basis for a patch to resolve this PR for 4.5.0?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #11 from ebotcazou at gcc dot gnu dot org  2010-01-13 08:45 -------
Jan, are you there?


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[ro at CeBiTec dot Uni-Bielefeld dot DE]

------- Comment #12 from ro at CeBiTec dot Uni-Bielefeld dot DE  2010-01-13 15:03 -------
Subject: Re:  [4.5 regression] ICE in function_and_variable_visibility breaks
Ada bootstrap

> ------- Comment #10 from simon at pushface dot org  2010-01-11 22:12 -------
> I have (locally!) rolled back the change to ipa.c in r154121 as suggested and
> successfully built a compiler which successfully compiles the test case in
> p.txt. Will that be an adequate basis for a patch to resolve this PR for 4.5.0?

I think so: I've just rolled back the broken checkins, which allowed a
all,ada bootstrap to succeed on alpha-dec-osf{4.0f, 5.1b}.  I've
submitted the patch at

        http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00572.html

        Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[hubicka at gcc dot gnu dot org]

------- Comment #13 from hubicka at gcc dot gnu dot org  2010-01-15 00:33 -------
Hi,
sorry for replying late, I was missed this problem somehow in my bugzilla
folder. The test in question verify that variables that are common or weak are
also etither public or external.

I will have time to try to reproduce the problem only tomorrow or during
weekend (it will be bit tricky as I know of no machine known to fail here I can
access easily), but it seems to me that if Ada produce variable failing this
test, it is frontend problem uncovered by the sanity check.  It would help me a
lot if we can just debug this. Would be possible to have debug_tree of the
variable in question so we can try to figure out reason Ada sets the flags this
way?

There was number of FE issues caught by this check - my way to debug them was
always the same.  First figure out offending vnode->decl, then put breakpoint
on "return result" of ggc_alloc with condition of result being the decl to work
out where fronetnd builds the node and then to try understand why flags end up
being the way they are.

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #14 from ebotcazou at gcc dot gnu dot org  2010-01-15 08:27 -------
> sorry for replying late, I was missed this problem somehow in my bugzilla
> folder. The test in question verify that variables that are common or weak are
> also either public or external.

No doubt about that.  The problem is, this was installed without mention in the
ChangeLog so looks quite unintentional.  If this is intentional, you should fix
the ChangeLog.

> I will have time to try to reproduce the problem only tomorrow or during
> weekend (it will be bit tricky as I know of no machine known to fail here I
> can access easily),

Please read comment #5.

> but it seems to me that if Ada produce variable failing this test, it is
> frontend problem uncovered by the sanity check.

See utils.c:create_var_decl_1

  /* Ada doesn't feature Fortran-like COMMON variables so we shouldn't
     try to fiddle with DECL_COMMON.  However, on platforms that don't
     support global BSS sections, uninitialized global variables would
     go in DATA instead, thus increasing the size of the executable.  */
  if (!flag_no_common
      && TREE_CODE (var_decl) == VAR_DECL
      && !have_global_bss_p ())
    DECL_COMMON (var_decl) = 1;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[hubicka at ucw dot cz]

------- Comment #15 from hubicka at ucw dot cz  2010-01-16 12:30 -------
Subject: Re:  [4.5 regression] ICE in function_and_variable_visibility breaks
Ada bootstrap

> No doubt about that.  The problem is, this was installed without mention in the
> ChangeLog so looks quite unintentional.  If this is intentional, you should fix
> the ChangeLog.

Will do, the earlier version of sanity check was wrong.  Actually
looking into DECL_COMMON implementation, it seems that even for static
variables this seems to work as intended at least on i386, so perhaps
the sanity check is overactive.  I am double checking that now.
> 
> > I will have time to try to reproduce the problem only tomorrow or during
> > weekend (it will be bit tricky as I know of no machine known to fail here I
> > can access easily),
> 
> Please read comment #5.

I am not questioning that. I have somewhat hectic time now and did not
notice situation earlier. I am finishing some papers and my thesis now.
My apologize for missing this.  Will finish patch today.

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[hubicka at gcc dot gnu dot org]

------- Comment #17 from hubicka at gcc dot gnu dot org  2010-01-16 14:54 -------
Hi,
strictly speaking, I would argue that Ada should not set COMMON flag for
!PUBLIC variables since it has no effect: all static variables that have no
initializer go to .common anyway.  However same ICE is possible to trigger via
static int a __attribute__ ((common)) and looking at varasm.c threre are
multitude of reasons why COMMON flag is disqualified later.
The checks are spred across the varasm.c and some of them are arguably late
since things should be finalized after make_decl_rtl.  So following patch moves
the logic into visibility pass so it will now clear the flag instead of ICEing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[hubicka at gcc dot gnu dot org]

------- Comment #16 from hubicka at gcc dot gnu dot org  2010-01-16 14:54 -------
Created an attachment (id=19623)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19623&action=view)
patch I am testing


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[ebotcazou at gcc dot gnu dot org]

------- Comment #18 from ebotcazou at gcc dot gnu dot org  2010-01-16 15:11 -------
> strictly speaking, I would argue that Ada should not set COMMON flag for
> !PUBLIC variables since it has no effect: all static variables that have no
> initializer go to .common anyway.

That seems reasonable.  The Ada part is OK if you write it:

  DECL_INITIAL  (var_decl) = var_init;
  TREE_READONLY (var_decl) = const_flag;
  DECL_EXTERNAL (var_decl) = extern_flag;
  TREE_PUBLIC   (var_decl) = public_flag || extern_flag;
  TREE_CONSTANT (var_decl) = constant_p;
  TREE_THIS_VOLATILE (var_decl) = TREE_SIDE_EFFECTS (var_decl)
    = TYPE_VOLATILE (type);

  /* Ada doesn't feature Fortran-like COMMON variables so we shouldn't
     try to fiddle with DECL_COMMON.  However, on platforms that don't
     support global BSS sections, uninitialized global variables would
     go in DATA instead, thus increasing the size of the executable.  */
  if (!flag_no_common
      && TREE_CODE (var_decl) == VAR_DECL
      && TREE_PUBLIC (var_decl)
      && !have_global_bss_p ())
    DECL_COMMON (var_decl) = 1;

Thanks for fixing the problem.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[ro at CeBiTec dot Uni-Bielefeld dot DE]

------- Comment #19 from ro at CeBiTec dot Uni-Bielefeld dot DE  2010-01-18 12:20 -------
Subject: Re:  [4.5 regression] ICE in function_and_variable_visibility breaks
Ada bootstrap

> ------- Comment #16 from hubicka at gcc dot gnu dot org  2010-01-16 14:54 -------
> Created an attachment (id=19623)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19623&action=view)
>  --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19623&action=view)
> patch I am testing

Unfortunately, this (together with Eric's addition) fails in
alpha-dec-osf testing:

% /vol/gcc/obj/gcc-4.5.0-20100111/4.0f-gcc/./prev-gcc/xgcc
-B/vol/gcc/obj/gcc-4.5.0-20100111/4.0f-gcc/./prev-gcc/
-B/vol/gcc/alpha-dec-osf4.0f/bin/ -B/vol/gcc/alpha-dec-osf4.0f/bin/
-B/vol/gcc/alpha-dec-osf4.0f/lib/ -isystem /vol/gcc/alpha-dec-osf4.0f/include
-isystem /vol/gcc/alpha-dec-osf4.0f/sys-include    -c -g -O2  -gnatpg -gnata -g
-O1 -fno-inline \
         -nostdinc -I- -I. -Iada -I/vol/gcc/src/hg/trunk/osf/gcc/ada
-I/vol/gcc/src/hg/trunk/osf/gcc/ada/gcc-interface
/vol/gcc/src/hg/trunk/osf/gcc/ada/a-except.adb -o ada/a-except.o

raised CONSTRAINT_ERROR : SIGSEGV

Both gdb 6.6 and 7.0 segv when loading gnat1 on Tru64 UNIX V4.0F, so
it's hard to debug from here.  On V5.1B, gdb doesn't work properly
either:

Reading symbols from /vol/gcc/obj/gcc-4.5.0-20100111/5.1b-gcc/gcc/gnat1...Error
reading symbol table: Memory exhausted
No symbol table is loaded.  Use the "file" command.

If I use ladebug instead, I miss the symbolic debug information (ladebug
cannot deal with stabs-in-ecoff), but at least I get a stack trace:

Thread received signal SEGV
stopped at [void _GLOBAL__FD_gnat1(void) 0x121847f58]
(ladebug) where
>0  0x121847f58 in _GLOBAL__FD_gnat1() in ./gnat1
#1  0x121848b20 in _GLOBAL__FD_gnat1() in ./gnat1
#2  0x12184adfc in _GLOBAL__FD_gnat1() in ./gnat1
#3  0x12184ba6c in _GLOBAL__FD_gnat1() in ./gnat1
#4  0x120cf8a30 in _GLOBAL__FD_gnat1() in ./gnat1
#5  0x12184be88 in _GLOBAL__FD_gnat1() in ./gnat1
#6  0x120cf8a30 in _GLOBAL__FD_gnat1() in ./gnat1
#7  0x120daed08 in _GLOBAL__FD_gnat1() in ./gnat1
#8  0x120dafa98 in _GLOBAL__FD_gnat1() in ./gnat1
#9  0x120dae470 in _GLOBAL__FD_gnat1() in ./gnat1
#10 0x120dafbc4 in _GLOBAL__FD_gnat1() in ./gnat1
#11 0x120dae470 in _GLOBAL__FD_gnat1() in ./gnat1
#12 0x120dafb10 in _GLOBAL__FD_gnat1() in ./gnat1
#13 0x120dae470 in _GLOBAL__FD_gnat1() in ./gnat1
#14 0x120dafb10 in _GLOBAL__FD_gnat1() in ./gnat1
#15 0x120dae470 in _GLOBAL__FD_gnat1() in ./gnat1
#16 0x12184a090 in _GLOBAL__FD_gnat1() in ./gnat1
#17 0x12184a104 in _GLOBAL__FD_gnat1() in ./gnat1
#18 0x12184a6d8 in _GLOBAL__FD_gnat1() in ./gnat1
#19 0x1218556c0 in _GLOBAL__FD_gnat1() in ./gnat1
#20 0x12144f8a0 in _GLOBAL__FD_gnat1() in ./gnat1
#21 0x121450dc0 in _GLOBAL__FD_gnat1() in ./gnat1
#22 0x121451510 in _GLOBAL__FD_gnat1() in ./gnat1
More (n if no)?  n
#23 0x121451b34 in _GLOBAL__FD_gnat1() in ./gnat1
#24 0x1204e5e68 in _GLOBAL__FD_gnat1() in ./gnat1
#25 0x120f52a74 in _GLOBAL__FD_gnat1() in ./gnat1
#26 0x120f55fe8 in _GLOBAL__FD_gnat1() in ./gnat1
#27 0x120f56138 in _GLOBAL__FD_gnat1() in ./gnat1
#28 0x120c156c4 in _GLOBAL__FD_gnat1() in ./gnat1
#29 0x120382b98 in __start(...) in ./gnat1

This is really messy: maybe I'll have some more luck with a cross
compiler.

        Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[hubicka at ucw dot cz]

------- Comment #20 from hubicka at ucw dot cz  2010-01-18 12:57 -------
Subject: Re:  [4.5 regression] ICE in
        function_and_variable_visibility breaks Ada bootstrap

> This is really messy: maybe I'll have some more luck with a cross
> compiler.
Indeed it is.  I will try, but I had problem building the cross because of
missing a.out headers.  Can you, please, try the change to ada directory
itself? That alone should be enough to cure the bootstrap failure (not the C
version of testcase).  So I am testing it now and intend to commit it ahead of
rest of changes.

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility breaks Ada bootstrap

[hubicka at gcc dot gnu dot org]

------- Comment #21 from hubicka at gcc dot gnu dot org  2010-01-18 15:42 -------
Subject: Bug 42068

Author: hubicka
Date: Mon Jan 18 15:42:05 2010
New Revision: 156010

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156010
Log:
        PR middle-end/42068
        (create_var_decl_1): Do not set COMMON flag for unit local variables.

Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/gcc-interface/utils.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[hubicka at gcc dot gnu dot org]

------- Comment #22 from hubicka at gcc dot gnu dot org  2010-01-18 15:47 -------
No longer bootstrap issue, but still ICE on valid.


-- 

hubicka at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |hubicka at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-01-06 22:48:22         |2010-01-18 15:47:12
               date|                            |
            Summary|[4.5 regression] ICE in     |[4.5 regression] ICE in
                   |function_and_variable_visibi|function_and_variable_visibi
                   |lity breaks Ada bootstrap   |lity with static common
                   |                            |vars.


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[rguenth at gcc dot gnu dot org]

------- Comment #23 from rguenth at gcc dot gnu dot org  2010-01-18 15:48 -------
If it's now middle-end then we need to adjust the priority.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|build                       |ice-on-valid-code
           Priority|P4                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[hubicka at gcc dot gnu dot org]

------- Comment #24 from hubicka at gcc dot gnu dot org  2010-01-18 17:19 -------
Subject: Bug 42068

Author: hubicka
Date: Mon Jan 18 17:19:13 2010
New Revision: 156016

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156016
Log:

        PR middle-end/42068
        * gcc-interface/utils.c (create_var_decl_1): Do not set COMMON flag for
        unit local variables.

Modified:
    trunk/gcc/ada/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[simon at pushface dot org]

------- Comment #25 from simon at pushface dot org  2010-01-18 20:41 -------
OK on i86_64-apple-darwin10.2, powerpc-wrs-vxworks (hosted on
i366-apple-darwin10.2).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[simon at pushface dot org]

------- Comment #26 from simon at pushface dot org  2010-01-18 20:54 -------
(In reply to comment #22)
> No longer bootstrap issue, but still ICE on valid.

The problem is that the ICE-on-valid occurs while building the Ada RTS, and
that is a bootstrap issue for Ada (what I mean is, a build configured with
"--enable-languages=foo,ada" will fail).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[hubicka at ucw dot cz]

------- Comment #27 from hubicka at ucw dot cz  2010-01-19 10:48 -------
Subject: Re:  [4.5 regression] ICE in
        function_and_variable_visibility with static common vars.

> The problem is that the ICE-on-valid occurs while building the Ada RTS, and
> that is a bootstrap issue for Ada (what I mean is, a build configured with
> "--enable-languages=foo,ada" will fail).
Does it happen also with the reduced version of the patch I comitted to
mainline?
I can't imagine how this one can trigger ICE, but it might be independent
change in
meantime as I was slow on fixing this bug :(
Does the reduced testcase also trigger it? (I will try it on cross, since
without
useful backtrace I can't do much).  I proofread the other part of patch but
don't
see anything obviously wrong here.

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[simon at pushface dot org]

------- Comment #28 from simon at pushface dot org  2010-01-19 12:36 -------
(In reply to comment #27)
I am sorry for spreading confusion & wasting time, I had a different
PR-resolution process in mind.

Now that the reduced patch is committed to mainline, there is no longer an ICE
during build of i86_64-apple-darwin10.2, powerpc-wrs-vxworks. So Richard is
right in comment #23.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[ro at CeBiTec dot Uni-Bielefeld dot DE]

------- Comment #29 from ro at CeBiTec dot Uni-Bielefeld dot DE  2010-01-20 16:37 -------
Subject: Re:  [4.5 regression] ICE in function_and_variable_visibility breaks
Ada bootstrap

> ------- Comment #20 from hubicka at ucw dot cz  2010-01-18 12:57 -------
> Subject: Re:  [4.5 regression] ICE in
>         function_and_variable_visibility breaks Ada bootstrap
>
>> This is really messy: maybe I'll have some more luck with a cross
>> compiler.
> Indeed it is.  I will try, but I had problem building the cross because of
> missing a.out headers.  Can you, please, try the change to ada directory
> itself? That alone should be enough to cure the bootstrap failure (not the C
> version of testcase).  So I am testing it now and intend to commit it ahead of
> rest of changes.

Indeed it does: with that chance, a full bootstrap on alpha-dec-osf4.0f
and alpha-dec-osf5.1b succeeded.

Thanks
        Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[hubicka at ucw dot cz]

------- Comment #30 from hubicka at ucw dot cz  2010-01-21 16:57 -------
Subject: Re:  [4.5 regression] ICE in function_and_variable_visibility with
static common vars.

> 
> Indeed it does: with that chance, a full bootstrap on alpha-dec-osf4.0f
> and alpha-dec-osf5.1b succeeded.

Thanks for confirmation!  I would however like to proceed with rest of
patch in order to fix the C testcase.  Unfortunately I was not able to
reproduce the ICE on my machine neither at cross or by bootstrapping at
random architectures available to me.
Do you think you can gather at least some data about the ICE? (i.e.
function name or so).  Looking through the patch I don't see any obvious
mistakes.  It might be side effect of moving RTL generation of
assembling alias, but that is needed to avoid RTL from being produced
too early before visibilities are set.

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[ro at CeBiTec dot Uni-Bielefeld dot DE]

------- Comment #31 from ro at CeBiTec dot Uni-Bielefeld dot DE  2010-01-21 17:11 -------
Subject: Re:  [4.5 regression] ICE in function_and_variable_visibility with
static common vars.

> ------- Comment #30 from hubicka at ucw dot cz  2010-01-21 16:57 -------
> Subject: Re:  [4.5 regression] ICE in function_and_variable_visibility with
> static common vars.
>
>> 
>> Indeed it does: with that chance, a full bootstrap on alpha-dec-osf4.0f
>> and alpha-dec-osf5.1b succeeded.
>
> Thanks for confirmation!  I would however like to proceed with rest of
> patch in order to fix the C testcase.  Unfortunately I was not able to
> reproduce the ICE on my machine neither at cross or by bootstrapping at
> random architectures available to me.
> Do you think you can gather at least some data about the ICE? (i.e.
> function name or so).  Looking through the patch I don't see any obvious
> mistakes.  It might be side effect of moving RTL generation of
> assembling alias, but that is needed to avoid RTL from being produced
> too early before visibilities are set.

Unfortunately, I've so far been unsuccessful in getting any debugger to
work properly on the gnat1 binary.  I've tried gdb mainline, but there's
the same error, and indeed gnat1 cannot properly be processed by either
objdump or stdump (a native Tru64 UNIX tool to dump symbolic debug
information).  This seems to partially be a problem with the bootstrap
compiler (gcc 4.4.2 in my case), though: the gnat1 from my last
successful bootstap can at least be processed by stdump, though gdb 7.0
still SEGVs on it ;-(

I could try another mainline bootstrap, though: maybe I'll be more lucky
this time or be able what causes gdb to crash.

Which patch exactly would you like me to test?  Are the ipa.c and
varasm.c changes here

        http://gcc.gnu.org/bugzilla/attachment.cgi?id=19623&action=view

still up to date?

        Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[rupp at gnat dot com]

------- Comment #32 from rupp at gnat dot com  2010-01-21 17:36 -------
I'm not sure what Jan is asking for exactly, but in an attempt to be helpful
here is a traceback using the 20091124 sources for the reduced testcase on
alpha-openvms. The debugging info is messed up for me too, but its just the
source line correlation records numbers, the call stack looks reasonable. If I
can be of further assistance please ask.

$ gdb ../../gnat1
(gdb) br fancy_abort
(gdb) r -quiet -I. p.adb
(gdb) bt
#0  0x084eee38 in fancy_abort (file=0x8b079b7 "../../gcc-head-src/gcc/ipa.c",
    line=417, function=0x8b07ae0 "function_and_variable_visibility")
    at ../../gcc-head-src/gcc/diagnostic.c:155
#1  0x088c8a52 in function_and_variable_visibility (whole_program=0 '\0')
    at ../../gcc-head-src/gcc/cgraph.h:270
#2  0x088c8d91 in local_function_and_variable_visibility ()
    at ../../gcc-head-src/gcc/cgraph.h:270
#3  0x08653c37 in execute_one_pass (pass=0x8b6b440)
    at ../../gcc-head-src/gcc/function.h:176
#4  0x08654352 in execute_ipa_pass_list (pass=0x8b6b440)
    at ../../gcc-head-src/gcc/function.h:176
#5  0x088a737e in ipa_passes () at ../../gcc-head-src/gcc/tree.h:182
#6  0x088a74f0 in cgraph_optimize () at ../../gcc-head-src/gcc/tree.h:182
#7  0x088a5d80 in cgraph_finalize_compilation_unit ()
    at ../../gcc-head-src/gcc/tree.h:182
#8  0x0815c6d1 in gnat_write_global_declarations ()
    at ../../gcc-head-src/gcc/tree.h:182
#9  0x0870e1bd in compile_file () at ../../gcc-head-src/gcc/toplev.h:198
#10 0x0870fe4a in do_compile () at ../../gcc-head-src/gcc/toplev.h:198
#11 0x0870ff0f in toplev_main (argc=4, argv=0xbfea58a4)
    at ../../gcc-head-src/gcc/toplev.h:198
#12 0x0847b33b in main (argc=4, argv=0xbfea58a4)
    at ../../gcc-head-src/gcc/main.c:35


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[hubicka at ucw dot cz]

------- Comment #33 from hubicka at ucw dot cz  2010-01-22 14:52 -------
Subject: Re:  [4.5 regression] ICE in
        function_and_variable_visibility with static common vars.

> I'm not sure what Jan is asking for exactly, but in an attempt to be helpful
> here is a traceback using the 20091124 sources for the reduced testcase on
> alpha-openvms. The debugging info is messed up for me too, but its just the
> source line correlation records numbers, the call stack looks reasonable. If I
> can be of further assistance please ask.
The backtrace should be definitely enough.  What I need is trace of the
setfault reported in comment #19.  It should happen on mainline with the
proposed patch (attached in the PR) minus changes to Ada directory (that
already was commited to mainline in modified form) applied.  There is still bug
in handling user defined comdat functions, so I would like to debug rest of the
patch for mainline.

Thanks,
Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[hubicka at gcc dot gnu dot org]

------- Comment #34 from hubicka at gcc dot gnu dot org  2010-03-07 20:49 -------
Hi,
since this is blocker for a release and I can't reproduce the problem myself,
if there any hope to get a backtrace?
We can also just silence the sanity check for 4.5 for time being, but the
proposed patch should solve the problem in proper way.

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[rguenth at gcc dot gnu dot org]

------- Comment #35 from rguenth at gcc dot gnu dot org  2010-03-08 11:56 -------
I find this bug mildly confusing.  As the bootstrap / ada issues are fixed
(are they?) I'll split out static int a __attribute__((common)) ICE to separate
PR.

Please close this bug if the bootstra / ada issues are indeed fixed.  They
are P4 (non-primary/secondary arch, and Ada).


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug middle-end/42068] [4.5 regression] ICE in function_and_variable_visibility with static common vars.

[rguenth at gcc dot gnu dot org]

------- Comment #36 from rguenth at gcc dot gnu dot org  2010-03-08 11:59 -------
(In reply to comment #35)
> I find this bug mildly confusing.  As the bootstrap / ada issues are fixed
> (are they?) I'll split out static int a __attribute__((common)) ICE to separate
> PR.

-> PR43288


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug ada/42068] [4.5 regression] ICE in function_and_variable_visibility

[ebotcazou at gcc dot gnu dot org]

------- Comment #37 from ebotcazou at gcc dot gnu dot org  2010-03-08 12:03 -------
The original bug is fixed.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
          Component|middle-end                  |ada
 GCC target triplet|alpha-openvms               |alpha-*-*
         Resolution|                            |FIXED
            Summary|[4.5 regression] ICE in     |[4.5 regression] ICE in
                   |function_and_variable_visibi|function_and_variable_visibi
                   |lity with static common     |lity
                   |vars.                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068

[Bug ada/42068] [4.5 regression] ICE in function_and_variable_visibility

[rupp at gnat dot com]

------- Comment #38 from rupp at gnat dot com  2010-03-09 05:20 -------
I patched gnatpro gcc-head snapshot from 20100307 with "ppa" (less ada bits) as
instructed in comment #33, and it bootstraps fine on alphaev67-dec-osf5.1b,
also compiles p.ad[bs] aka "p.txt"


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42068