public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "paolo dot carlini at oracle dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/42622] New: [C++0x] Improve std::ratio_less to not overflow Date: Tue, 05 Jan 2010 12:11:00 -0000 [thread overview] Message-ID: <bug-42622-16141@http.gcc.gnu.org/bugzilla/> (raw) This is just an internal reminder: we should implement the following suggestion from Howard on the library reflector. Maybe Chris is interested... ///////////////// I just recently became aware that it is possible to do this comparison without any chance of overflow. This is accomplished by converting each ratio to a continued fraction, term by term so that the memory used is O(1): stack based - not O(N): heap based. And then you compare the terms of the continued fractions, as they are created, and then forget them. This process does not involve multiplication, only / and %, thus no overflow. Boost rational uses this technique, and I have implemented it in a <ratio> example implementation. The complexity of it is approximately the same amount of code I used in my previous implementation which did go to great lengths to avoid overflow as much as I knew how at the time. Both my previous implementation and my current implementation are much more involved than simply evaluating R1::num * R2::den < R2::num * R1::den (on the order of 60 lines of code instead of 3 lines of code). All cost is incurred at compile time, not run time. For my money, the compile-time cost is worth it. Other implementations (or clients of those implementations) may or may not feel that way. Here is an algorithm for comparing continued fractions: http://perl.plover.com/yak/cftalk/TALK/slide045.html Algorithms for converting rationals to continued fractions are common and found elsewhere/everywhere. -- Summary: [C++0x] Improve std::ratio_less to not overflow Product: gcc Version: 4.5.0 Status: UNCONFIRMED Severity: enhancement Priority: P3 Component: libstdc++ AssignedTo: unassigned at gcc dot gnu dot org ReportedBy: paolo dot carlini at oracle dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42622
next reply other threads:[~2010-01-05 12:11 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-05 12:11 paolo dot carlini at oracle dot com [this message] 2010-01-09 22:53 ` [Bug libstdc++/42622] " paolo dot carlini at oracle dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-42622-16141@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).