[Bug fortran/42693] Missing gcc-internal-format on messages from gfc_arith_error

[Bug fortran/42693] Missing gcc-internal-format on messages from gfc_arith_error

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42693

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-01-24
                 CC|                            |burnus@net-b.de
     Ever Confirmed|0                           |1

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-01-24 10:55:06 UTC ---
> Confirm. One possibility would be to modify ...

Tobias,

Is it that simple?

[Bug fortran/42693] Missing gcc-internal-format on messages from gfc_arith_error

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42693

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
             Blocks|                            |52274
         Depends on|52274                       |

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-02-16 14:05:17 UTC ---
(In reply to comment #1)
> a simple hack would be to use:
> +      /* xgettext:gcc-internal-format */

I think the best would be to mark those lines with "%L" via G_() instead of _.
There are plenty such lines. (Cf. also PR 52279)

[Bug fortran/42693] Missing gcc-internal-format on messages from gfc_arith_error

[markeggleston at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42693

markeggleston at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markeggleston at gcc dot gnu.org

--- Comment #4 from markeggleston at gcc dot gnu.org ---
I note from the current code all the strings in gfc_arith_error are enclosed in
_(). Does this mean that this is fixed?

I don't know how to test for message translation so can not confirm.

[Bug fortran/42693] Missing gcc-internal-format on messages from gfc_arith_error

[goeran at uddeborg dot se]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42693

--- Comment #5 from Göran Uddeborg <goeran at uddeborg dot se> ---
(In reply to markeggleston from comment #4)
> Does this mean that this is fixed?

I don't think so.  The "_" define typically marks the string for translation,
but it doesn't add the information this is a format string using
"gcc-internal-format" rather than regular printf() style formatting.  According
to comment 3, that can be achieved by using the define "G_" rather than plain
"_" for those strings using "%L" or any other GCC specific formatting
directives..

[Bug fortran/42693] Missing gcc-internal-format on messages from gfc_arith_error

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42693

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mark Eggleston
<markeggleston@gcc.gnu.org>:

https://gcc.gnu.org/g:d57bf2315e024ada3393ad967e8f632121383c9c

commit r11-1583-gd57bf2315e024ada3393ad967e8f632121383c9c
Author: Mark Eggleston <markeggleston@gcc.gnu.org>
Date:   Wed Jun 10 11:41:56 2020 +0100

    Fortran  : Missing gcc-internal-format PR42693

    Messages in gfc_arith_error contain gcc internal format specifiers
    which should be enclosed in G_() in order to be correctly translated.

    2020-06-22  Mark Eggleston  <markeggleston@gcc.gnu.org>

    gcc/fortran/

            PR fortran/42693
            * arith.c (gfc_arith_error): Enclose strings in G_() instead
            of _().

[Bug fortran/42693] Missing gcc-internal-format on messages from gfc_arith_error

[markeggleston at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42693

markeggleston at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from markeggleston at gcc dot gnu.org ---
Committed to master.

[Bug fortran/42693] Missing gcc-internal-format on messages from gfc_arith_error

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2010-01-11 22:29 -------
Confirm. One possibility would be to modify
  gcc/po/exgettext
to recognize %L -- while a simple hack would be to use:

--- arith.c     (Revision 155812)
+++ arith.c
@@ -91,6 +91,7 @@
   switch (code)
     {
     case ARITH_OK:
+      /* xgettext:gcc-internal-format */
       p = _("Arithmetic OK at %L");
       break;
     case ARITH_OVERFLOW:

etc.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42693