[Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target
       [not found] <bug-43746-4@http.gcc.gnu.org/bugzilla/>
@ 2011-07-14  7:49 ` gjl at gcc dot gnu.org
  2011-07-14  7:53 ` gjl at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: gjl at gcc dot gnu.org @ 2011-07-14  7:49 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43746

--- Comment #4 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-07-14 07:49:19 UTC ---
Author: gjl
Date: Thu Jul 14 07:49:14 2011
New Revision: 176262

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176262
Log:
gcc/
    PR target/43746
    * config/avr/elf.h (TARGET_ASM_SELECT_SECTION): Remove,
    i.e. use default_elf_select_section.
    (TARGET_HAVE_SWITCHABLE_BSS_SECTIONS): Remove.
    (READONLY_DATA_SECTION_ASM_OP): Remove.
    (TARGET_ASM_NAMED_SECTION): Move from here...
    * config/avr/avr.c: ...to here.
    (avr_asm_init_sections): Set unnamed callback of
    readonly_data_section.
    (avr_asm_named_section): Make static.

testsuite/
    PR target/43746
    * gcc.dg/array-quals-1.c: Don't xfail on AVR.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr.c
    trunk/gcc/config/avr/elf.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/array-quals-1.c


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target
       [not found] <bug-43746-4@http.gcc.gnu.org/bugzilla/>
  2011-07-14  7:49 ` [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target gjl at gcc dot gnu.org
@ 2011-07-14  7:53 ` gjl at gcc dot gnu.org
  2011-08-03 19:40 ` gjl at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: gjl at gcc dot gnu.org @ 2011-07-14  7:53 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43746

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |missed-optimization
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.07.14 07:52:52
                 CC|                            |gjl at gcc dot gnu.org
   Target Milestone|---                         |4.7.0
     Ever Confirmed|0                           |1

--- Comment #5 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-07-14 07:52:52 UTC ---
Set the status to NEW.

The above patch fixes constant merging for constants in .rodata which is mapped
into RAM for AVR.

To make it work for .progmem (data in Flash) requires a seperate patch.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target
       [not found] <bug-43746-4@http.gcc.gnu.org/bugzilla/>
  2011-07-14  7:49 ` [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target gjl at gcc dot gnu.org
  2011-07-14  7:53 ` gjl at gcc dot gnu.org
@ 2011-08-03 19:40 ` gjl at gcc dot gnu.org
  2011-09-12 10:17 ` gjl at gcc dot gnu.org
  2011-09-12 11:00 ` gjl at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: gjl at gcc dot gnu.org @ 2011-08-03 19:40 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43746

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |schlie at comcast dot net

--- Comment #6 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-08-03 19:40:32 UTC ---
*** Bug 21018 has been marked as a duplicate of this bug. ***


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target
       [not found] <bug-43746-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2011-08-03 19:40 ` gjl at gcc dot gnu.org
@ 2011-09-12 10:17 ` gjl at gcc dot gnu.org
  2011-09-12 11:00 ` gjl at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: gjl at gcc dot gnu.org @ 2011-09-12 10:17 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43746

--- Comment #7 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-09-12 10:06:52 UTC ---
Author: gjl
Date: Mon Sep 12 10:06:46 2011
New Revision: 178779

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=178779
Log:
gcc/
    PR target/43746
    * config/avr/avr.c (AVR_SECTION_PROGMEM): New Define.
    (progmem_section): New Variable.
    (avr_asm_init_sections): Initialize it.
    (TARGET_ASM_SELECT_SECTION): Define to...
    (avr_asm_select_section): ... this new Function.
    (avr_replace_prefix): New Function.
    (avr_asm_function_rodata_section): Use it.
    (avr_insert_attributes): Don't add section attribute for PROGMEM.
    (avr_section_type_flags): Use avr_progmem_p instead of section
    name to detect if object is in PROGMEM.
    (avr_asm_named_section): Set section name prefix for objects in
    PROGMEM.

testsuite/
    PR target/43746
    * testsuite/gcc.target/avr/torture/avr-torture.exp
    (AVR_TORTURE_OPTIONS): Add test cases "-O2 -fdata-sections" and
    "-O2 -fmerge-all-constants".


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/avr/torture/avr-torture.exp


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target
       [not found] <bug-43746-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2011-09-12 10:17 ` gjl at gcc dot gnu.org
@ 2011-09-12 11:00 ` gjl at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: gjl at gcc dot gnu.org @ 2011-09-12 11:00 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43746

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-09-12 10:16:25 UTC ---
Closed as fixed for 4.7 Milestone.

Initially I intended to add a -fprogmem-sections command line option that works
similar but independent to -fdata-section.  That way data sections could be
used and strings in progmem merged.  However, I did not find a straight forward
way without cluttering avr BE with lots of code from varasm.c.  Thus, for now,
there is no -fprogmem-sections, i.e. progmem-sections are in sync with
data-sections and you have to decide wether you prefer string merging or fine
grained sections.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug c++/43746]  New: -fmerge-constants and -fmerge-all-constants don't work at AVR target
@ 2010-04-13  8:23 tfrancuz at mp dot pl
  2010-09-20 19:53 ` [Bug target/43746] " eric dot weddington at atmel dot com
  0 siblings, 1 reply; 6+ messages in thread
From: tfrancuz at mp dot pl @ 2010-04-13  8:23 UTC (permalink / raw)
  To: gcc-bugs

-fmerge-all-constants and &#8211;fmerge-constants don&#8217;t work at AVR
target.
Example:
const char text1[] PROGMEM=&#8221;Test&#8221;;
const char text2[] PROGMEM=&#8221;Test&#8221;;

will still produce duplicated &#8220;Test&#8221; string in generated code.


-- 
           Summary: -fmerge-constants and -fmerge-all-constants don't work
                    at AVR target
           Product: gcc
           Version: 4.3.5
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tfrancuz at mp dot pl


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43746


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target
  2010-04-13  8:23 [Bug c++/43746] New: " tfrancuz at mp dot pl
@ 2010-09-20 19:53 ` eric dot weddington at atmel dot com
  0 siblings, 0 replies; 6+ messages in thread
From: eric dot weddington at atmel dot com @ 2010-09-20 19:53 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from eric dot weddington at atmel dot com  2010-09-20 19:53 -------
Reopening this enhancement request. Bug #21018, which this was marked a
duplicate of, is now marked as WONTFIX.


-- 

eric dot weddington at atmel dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
          Component|c++                         |target
 GCC target triplet|                            |avr
         Resolution|DUPLICATE                   |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43746


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-09-12 10:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-43746-4@http.gcc.gnu.org/bugzilla/>
2011-07-14  7:49 ` [Bug target/43746] -fmerge-constants and -fmerge-all-constants don't work at AVR target gjl at gcc dot gnu.org
2011-07-14  7:53 ` gjl at gcc dot gnu.org
2011-08-03 19:40 ` gjl at gcc dot gnu.org
2011-09-12 10:17 ` gjl at gcc dot gnu.org
2011-09-12 11:00 ` gjl at gcc dot gnu.org
2010-04-13  8:23 [Bug c++/43746] New: " tfrancuz at mp dot pl
2010-09-20 19:53 ` [Bug target/43746] " eric dot weddington at atmel dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).