[Bug fortran/43849] Add _gfortran_finalize function to close down the library

[Bug fortran/43849] Add _gfortran_finalize function to close down the library

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43849

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jb at gcc dot gnu.org

--- Comment #3 from Janne Blomqvist <jb at gcc dot gnu.org> 2010-11-03 16:31:08 UTC ---
In runtime/main.c we have

static void __attribute__((destructor))
cleanup (void)
{
  close_units ();

  if (please_free_exe_path_when_done)
    free ((char *) exe_path);
}

As this function is marked with the destructor attribute, it will be called
when the library is unloaded during program shutdown. 


It might make sense to add 

fbuf_flush(u);
sflush(u);

to some appropriate place in unit.c(close_unit_1). That is, make sure to flush
the unit as part of the closing procedure.

[Bug fortran/43849] Add _gfortran_finalize function to close down the library

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43849

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2013-12-21
     Ever confirmed|0                           |1

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Is this PR still pertinent (2013-12-21)?

[Bug libfortran/43849] Add _gfortran_finalize function to close down the library

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43849

--- Comment #6 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #0)
> Currently, _gfortran_abort calls:
>   close_units ();
> Additionally, one should call:
>   flush_all_units ();

close_units() actually flushes all units when closing then.


(In reply to Janne Blomqvist from comment #3)
> cleanup() in runtime/main.c is marked with the destructor attribute, it will be
> called when the library is unloaded during program shutdown. 
> 
> It might make sense to add 
> 
> fbuf_flush(u);
> sflush(u);

Same reply: when we close units, we do flush them. This is already ensured in
the close functions of io/unix.c.


So, to summarize: we already have a finalization function, cleanup(). Should we
export it? I am not so sure, unless we have a real use case.

[Bug libfortran/43849] Add _gfortran_finalize function to close down the library

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43849

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |37336

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> So, to summarize: we already have a finalization function, cleanup().
> Should we export it? I am not so sure, unless we have a real use case.

Could someone answer the question?


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37336
[Bug 37336] [F03] Finish derived-type finalization

[Bug libfortran/43849] Add _gfortran_finalize function to close down the library

[jb at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43849

--- Comment #8 from Janne Blomqvist <jb at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #7)
> > So, to summarize: we already have a finalization function, cleanup().
> > Should we export it? I am not so sure, unless we have a real use case.
> 
> Could someone answer the question?

IMHO, no there isn't a real use case for exporting the cleanup() function.

[Bug libfortran/43849] Add _gfortran_finalize function to close down the library

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43849

--- Comment #9 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> IMHO, no there isn't a real use case for exporting the cleanup() function.

Does it mean that this PR could be closed? FIXED or WONTFIX?

[Bug libfortran/43849] Add _gfortran_finalize function to close down the library

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43849

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #10 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Closing as WONTFIX for now. If a real use case (for example co-open array
related) is raised, we can export cleanup() in the future.