[Bug c++/43906] missing warnings the comparison between an address with a null pointer constant

[Bug c++/43906] missing warnings the comparison between an address with a null pointer constant

[paolo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43906

--- Comment #2 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> ---
Author: paolo
Date: Wed Aug  6 19:09:08 2014
New Revision: 213682

URL: https://gcc.gnu.org/viewcvs?rev=213682&root=gcc&view=rev
Log:
/cp
2014-08-06  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/43906
    * typeck.c (cp_build_binary_op): Extend to more cases the
    -Waddress warning.

/testsuite
2014-08-06  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/43906
    * g++.dg/warn/Waddress-1.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/warn/Waddress-1.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/43906] missing warnings the comparison between an address with a null pointer constant

[paolo.carlini at oracle dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43906

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.10.0

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Fixed.

[Bug c++/43906] New: missing warnings the comparison between an address with a null pointer constant

[pzhao at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

As Manuel mentioned at http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01425.html.
C++ have the same problem as pr32207.

extern void z();
void f() { if ( z ) z(); }
void g() { if ( z != 0 ) z(); }
void h() { if ( z != (void*)0 ) z(); }

t.C: In function ‘void f()’:
t.C:2:19: warning: the address of ‘void z()’ will always evaluate as ‘true’
[-Waddress]
t.C: In function ‘void g()’:
t.C:3:22: warning: the address of ‘void z()’ will never be NULL [-Waddress]


-- 
           Summary: missing warnings the comparison between an address with
                    a null pointer constant
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pzhao at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43906

[Bug c++/43906] missing warnings the comparison between an address with a null pointer constant

[manu at gcc dot gnu dot org]

------- Comment #1 from manu at gcc dot gnu dot org  2010-04-27 07:27 -------
Bonus points if the C/C++ FE share most of the code related to this warning (so
we only have one place to fix in the future).


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-04-27 07:27:13
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43906