* [Bug target/43961] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
@ 2013-01-03 0:00 ` jsm28 at gcc dot gnu.org
2013-01-03 8:55 ` mikpe at it dot uu.se
` (7 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2013-01-03 0:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
--- Comment #8 from Joseph S. Myers <jsm28 at gcc dot gnu.org> 2013-01-03 00:00:08 UTC ---
Mikael, ping on this patch from June 2010 ... what happened in testing? And
shouldn't this bug be marked as a regression, given the identification of the
responsible revision?
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/43961] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
2013-01-03 0:00 ` [Bug target/43961] [ARM thumb] "branch out of range" with thumb1_output_casesi jsm28 at gcc dot gnu.org
@ 2013-01-03 8:55 ` mikpe at it dot uu.se
2013-01-03 16:20 ` [Bug target/43961] [4.6/4.7/4.8 Regression] " jsm28 at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: mikpe at it dot uu.se @ 2013-01-03 8:55 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
--- Comment #9 from Mikael Pettersson <mikpe at it dot uu.se> 2013-01-03 08:54:35 UTC ---
(In reply to comment #8)
> Mikael, ping on this patch from June 2010 ... what happened in testing?
I've included this patch in my local 4.6-based branch since June 2010, and it's
tested w/o regressions on armv5te ever since (configured w/o
--disable-multilib, so I assume the test suite will also test Thumb-1 not just
ARM mode).
The patch apparently didn't work in a 4.5-based compiler, but I don't have any
notes explaining what the issue was. 4.5 is EOL anyway.
Somehow I forgot to forward-port it to 4.7 so I haven't tested it yet in my
4.7-based branch. Will do that asap.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/43961] [4.6/4.7/4.8 Regression] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
2013-01-03 0:00 ` [Bug target/43961] [ARM thumb] "branch out of range" with thumb1_output_casesi jsm28 at gcc dot gnu.org
2013-01-03 8:55 ` mikpe at it dot uu.se
@ 2013-01-03 16:20 ` jsm28 at gcc dot gnu.org
2013-01-07 15:19 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2013-01-03 16:20 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
Joseph S. Myers <jsm28 at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[ARM thumb] "branch out of |[4.6/4.7/4.8 Regression]
|range" with |[ARM thumb] "branch out of
|thumb1_output_casesi |range" with
| |thumb1_output_casesi
--- Comment #10 from Joseph S. Myers <jsm28 at gcc dot gnu.org> 2013-01-03 16:19:42 UTC ---
If the patch works for mainline, please do send it to gcc-patches as usual.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/43961] [4.6/4.7/4.8 Regression] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2013-01-03 16:20 ` [Bug target/43961] [4.6/4.7/4.8 Regression] " jsm28 at gcc dot gnu.org
@ 2013-01-07 15:19 ` rguenth at gcc dot gnu.org
2013-01-09 21:55 ` jsm28 at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-01-07 15:19 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.6.4
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/43961] [4.6/4.7/4.8 Regression] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2013-01-07 15:19 ` rguenth at gcc dot gnu.org
@ 2013-01-09 21:55 ` jsm28 at gcc dot gnu.org
2013-01-15 16:18 ` jsm28 at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2013-01-09 21:55 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
--- Comment #11 from Joseph S. Myers <jsm28 at gcc dot gnu.org> 2013-01-09 21:55:08 UTC ---
Created attachment 29133
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29133
More complicated fix for 4.6
The previous proposed patch breaks Thumb-2, because alignments for labels get
set based on ADDR_VEC_ALIGN before jump tables get shortened from SImode to a
narrower mode, and not updated afterwards so there is spurious alignment
between a tbb instruction and a jump table. This patch adds code to
shorten_branches to allow for this issue. 4.6-based; I'll test for mainline.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/43961] [4.6/4.7/4.8 Regression] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2013-01-09 21:55 ` jsm28 at gcc dot gnu.org
@ 2013-01-15 16:18 ` jsm28 at gcc dot gnu.org
2013-01-15 16:22 ` [Bug target/43961] [4.6/4.7 " jsm28 at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2013-01-15 16:18 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
--- Comment #12 from Joseph S. Myers <jsm28 at gcc dot gnu.org> 2013-01-15 16:17:53 UTC ---
Author: jsm28
Date: Tue Jan 15 16:17:28 2013
New Revision: 195208
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195208
Log:
2013-01-15 Joseph Myers <joseph@codesourcery.com>
Mikael Pettersson <mikpe@it.uu.se>
PR target/43961
* config/arm/arm.h (ADDR_VEC_ALIGN): Align SImode jump tables for
Thumb.
(ASM_OUTPUT_CASE_LABEL): Remove.
(ASM_OUTPUT_BEFORE_CASE_LABEL): Define to empty.
* final.c (shorten_branches): Update alignment of labels before
jump tables if CASE_VECTOR_SHORTEN_MODE.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/arm/arm.h
trunk/gcc/final.c
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/43961] [4.6/4.7 Regression] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2013-01-15 16:18 ` jsm28 at gcc dot gnu.org
@ 2013-01-15 16:22 ` jsm28 at gcc dot gnu.org
2013-04-12 15:15 ` [Bug target/43961] [4.7 " jakub at gcc dot gnu.org
2014-06-12 12:56 ` rguenth at gcc dot gnu.org
8 siblings, 0 replies; 9+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2013-01-15 16:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
Joseph S. Myers <jsm28 at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.6/4.7/4.8 Regression] |[4.6/4.7 Regression] [ARM
|[ARM thumb] "branch out of |thumb] "branch out of
|range" with |range" with
|thumb1_output_casesi |thumb1_output_casesi
--- Comment #13 from Joseph S. Myers <jsm28 at gcc dot gnu.org> 2013-01-15 16:21:51 UTC ---
Fixed for 4.8.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/43961] [4.7 Regression] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2013-01-15 16:22 ` [Bug target/43961] [4.6/4.7 " jsm28 at gcc dot gnu.org
@ 2013-04-12 15:15 ` jakub at gcc dot gnu.org
2014-06-12 12:56 ` rguenth at gcc dot gnu.org
8 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-04-12 15:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.6.4 |4.7.4
--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-12 15:15:47 UTC ---
GCC 4.6.4 has been released and the branch has been closed.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug target/43961] [4.7 Regression] [ARM thumb] "branch out of range" with thumb1_output_casesi
[not found] <bug-43961-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2013-04-12 15:15 ` [Bug target/43961] [4.7 " jakub at gcc dot gnu.org
@ 2014-06-12 12:56 ` rguenth at gcc dot gnu.org
8 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-06-12 12:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43961
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Known to work| |4.8.0
Resolution|--- |FIXED
Target Milestone|4.7.4 |4.8.0
Known to fail| |4.7.4
--- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed for 4.8.0
^ permalink raw reply [flat|nested] 9+ messages in thread