public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
@ 2014-04-16 19:59 ` manu at gcc dot gnu.org
2014-04-21 15:19 ` [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color manu at gcc dot gnu.org
` (12 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-04-16 19:59 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Created attachment 32622
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32622&action=edit
proof of concept
The attached patch is a proof of concept. It gives the following output:
/home/manuel/test1/test-gfc-warning.f03:11:0:
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4)
at (1) [-Wconversion]
arr = (/ INTEGER(KIND=4) :: HUGE(0_8) /) ! { dg-warning "conversion from" }
^
This warning is controllable by -Wno-conversion, -Werror=conversion and the
#pragma GCC diagnostic. Also the diagnostic is in color (unfortunately it does
not show it here).
Contrary to what I said above, I think it is actually easier for Fortran to use
the common pretty printer rather than fake their own. It will also remove quite
a bit of duplicated code from the Fortran FE. The transition can be done in the
following steps (I chose the wrong warning to start with):
1. Warnings that don't use %L (so initially you don't have to deal with locus)
2. Warnings that use %C
3. Warnings that use one %L
4. Warnings that use two %L
If there is one or more willing Fortran developers that wants to tackle this
for the next release, I think the four steps are feasible within one release.
To fully match the current Fortran diagnostics, the common diagnostics
machinery needs the following features:
a. Make the printing of the caret line more customizable. For the C/C++ FE it
will be moved to the diagnostic_finalizer, whereas for Fortran it will go in
the diagnostic_starter, so it can be printed before the actual text.
b. A way to customize the caret symbol so Fortran can print '1' instead of '^'.
c. Pass down offsets relative to current location. This is anyway necessary for
printing more precise diagnostics for format strings, so it is a matter to add
an offset field to the diagnostic_info structure.
d. A way to print two locations in the caret line.
And that is all as far as I can see.
If a Fortran developer volunteers to tackle the Fortran bits, I will be happy
to implement the common diagnostics bits. From the above a) and b) are trivial.
c) is also trivial but requires writing a bit more of code. d) is a bit more
convoluted but it should work fine.
The Fortran transition can be incremental, that is, if Fortran disables colors
and -fdiagnostics-show-option by default, then the converted diagnostics will
be indistinguishable from the unconverted ones (except that -Wno-*, -Werror=
and the #pragmas will only work for the converted ones).
>From gcc-bugs-return-449195-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Apr 16 20:05:59 2014
Return-Path: <gcc-bugs-return-449195-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25156 invoked by alias); 16 Apr 2014 20:05:59 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25123 invoked by uid 48); 16 Apr 2014 20:05:56 -0000
From: "glisse at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/60852] [4.8/4.9/4.10 Regression] boost::has_complement of enum class does not compile
Date: Wed, 16 Apr 2014 20:05:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: glisse at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60852-4-Wum9UClui7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60852-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60852-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg01215.txt.bz2
Content-length: 287
http://gcc.gnu.org/bugzilla/show_bug.cgi?id`852
--- Comment #15 from Marc Glisse <glisse at gcc dot gnu.org> ---
Did someone file a corresponding PR for clang? It is useful for them, but also
for gcc because it gives them a chance to give a different interpretation of
the standard.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
2014-04-16 19:59 ` [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option manu at gcc dot gnu.org
@ 2014-04-21 15:19 ` manu at gcc dot gnu.org
2014-04-30 23:01 ` manu at gcc dot gnu.org
` (11 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-04-21 15:19 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #32622|0 |1
is obsolete| |
--- Comment #8 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Created attachment 32650
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32650&action=edit
proof of concept #2
Updated proof of concept. With this new version the output is:
/home/manuel/test1/test-gfc-warning.f03:11:0:
arr = (/ INTEGER(KIND=4) :: HUGE(0_8) /) ! { dg-warning "conversion from" }
1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4)
at (1) [-Wconversion]
(plus colors)
So the only remaining major issue is the offset.
It is not clear to me why Fortran needs an explicit offset, don't you track
locations when parsing using line-map.c ? So before implementing it I would
like to understand whether it is actually needed.
Also, is there any case where gcf_linebuf.file->filename !=
LOCATION_FILE(gcf_linebuf.location) ?
>From gcc-bugs-return-449414-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Apr 21 16:20:44 2014
Return-Path: <gcc-bugs-return-449414-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 18572 invoked by alias); 21 Apr 2014 16:20:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18040 invoked by uid 48); 21 Apr 2014 16:20:37 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/60909] ICE: in extract_insn, at recog.c:2202 (unrecognizable insn) with -mrdrnd and __builtin_ia32_rdrand32_step()
Date: Mon, 21 Apr 2014 16:20:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ubizjak at gmail dot com
X-Bugzilla-Target-Milestone: 4.7.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on assigned_to target_milestone everconfirmed
Message-ID: <bug-60909-4-Byc07hhOID@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60909-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60909-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg01434.txt.bz2
Content-length: 1643
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60909
Uroš Bizjak <ubizjak at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2014-04-21
Assignee|unassigned at gcc dot gnu.org |ubizjak at gmail dot com
Target Milestone|--- |4.7.4
Ever confirmed|0 |1
--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
I have a patch in testing (rdseed is affected by similar problem):
--cut here--
Index: i386.c
===================================================================
--- i386.c (revision 209544)
+++ i386.c (working copy)
@@ -35400,7 +35400,8 @@ rdrand_step:
else
op2 = gen_rtx_SUBREG (SImode, op0, 0);
- if (target == 0)
+ if (target == 0
+ || !register_operand (target, SImode))
target = gen_reg_rtx (SImode);
pat = gen_rtx_GEU (VOIDmode, gen_rtx_REG (CCCmode, FLAGS_REG),
@@ -35442,7 +35443,8 @@ rdseed_step:
const0_rtx);
emit_insn (gen_rtx_SET (VOIDmode, op2, pat));
- if (target == 0)
+ if (target == 0
+ || !register_operand (target, SImode))
target = gen_reg_rtx (SImode);
emit_insn (gen_zero_extendqisi2 (target, op2));
--cut here--
>From gcc-bugs-return-449415-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Apr 21 16:27:18 2014
Return-Path: <gcc-bugs-return-449415-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23422 invoked by alias); 21 Apr 2014 16:27:18 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23364 invoked by uid 48); 21 Apr 2014 16:27:13 -0000
From: "bernd.edlinger at hotmail dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/60830] [4.9 Regression] ICE on bootstrapping on cygwin
Date: Mon, 21 Apr 2014 16:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: bernd.edlinger at hotmail dot de
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60830-4-fjDnFQ1rh0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60830-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60830-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg01435.txt.bz2
Content-length: 212
http://gcc.gnu.org/bugzilla/show_bug.cgi?id`830
--- Comment #32 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
OK,
opened a binutils-bug at: https://sourceware.org/bugzilla/show_bug.cgi?id\x16858
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
2014-04-16 19:59 ` [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option manu at gcc dot gnu.org
2014-04-21 15:19 ` [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color manu at gcc dot gnu.org
@ 2014-04-30 23:01 ` manu at gcc dot gnu.org
2014-05-03 8:27 ` burnus at gcc dot gnu.org
` (10 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-04-30 23:01 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #9 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Fortran devs, is there any interest in this approach?
>From gcc-bugs-return-450306-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Apr 30 23:43:46 2014
Return-Path: <gcc-bugs-return-450306-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 11711 invoked by alias); 30 Apr 2014 23:43:45 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 11655 invoked by uid 48); 30 Apr 2014 23:43:40 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/54687] Use gcc option machinery for gfortran
Date: Wed, 30 Apr 2014 23:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-54687-4-GWbpBAgSgz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-54687-4@http.gcc.gnu.org/bugzilla/>
References: <bug-54687-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg02326.txt.bz2
Content-length: 4107
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54687
--- Comment #2 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Note that this is a repetitive but trivial task that consists mostly in
deleting code. Just take for example Wcompare-reals:
Index: gfortran.h
===================================================================
--- gfortran.h (revision 209347)
+++ gfortran.h (working copy)
@@ -2256,11 +2267,10 @@ typedef struct
int warn_real_q_constant;
int warn_unused_dummy_argument;
int warn_zerotrip;
int warn_realloc_lhs;
int warn_realloc_lhs_all;
- int warn_compare_reals;
int warn_target_lifetime;
int max_errors;
int flag_all_intrinsics;
int flag_default_double;
Index: lang.opt
===================================================================
--- lang.opt (revision 209347)
+++ lang.opt (working copy)
@@ -220,11 +220,11 @@ Fortran
Wcharacter-truncation
Fortran Warning
Warn about truncated character expressions
Wcompare-reals
-Fortran Warning
+Fortran Var(warn_compare_reals) Warning LangEnabledBy(Fortran,Wextra)
Warn about equality comparisons involving REAL or COMPLEX expressions
Wconversion
Fortran Warning
; Documented in C
Index: resolve.c
===================================================================
--- resolve.c (revision 209347)
+++ resolve.c (working copy)
@@ -3566,11 +3566,11 @@ resolve_operator (gfc_expr *e)
gfc_type_convert_binary (e, 1);
e->ts.type = BT_LOGICAL;
e->ts.kind = gfc_default_logical_kind;
- if (gfc_option.warn_compare_reals)
+ if (warn_compare_reals)
{
gfc_intrinsic_op op = e->value.op.op;
/* Type conversion has made sure that the types of op1 and op2
agree, so it is only necessary to check the first one. */
Index: options.c
===================================================================
--- options.c (revision 209347)
+++ options.c (working copy)
@@ -110,11 +110,10 @@ gfc_init_options (unsigned int decoded_o
gfc_option.warn_real_q_constant = 0;
gfc_option.warn_unused_dummy_argument = 0;
gfc_option.warn_zerotrip = 0;
gfc_option.warn_realloc_lhs = 0;
gfc_option.warn_realloc_lhs_all = 0;
- gfc_option.warn_compare_reals = 0;
gfc_option.warn_target_lifetime = 0;
gfc_option.max_errors = 25;
gfc_option.flag_all_intrinsics = 0;
gfc_option.flag_default_double = 0;
@@ -470,11 +461,5 @@
-/* Set the options for -Wextra. */
-
-static void
-set_Wextra (int setting)
-{
- gfc_option.warn_compare_reals = setting;
}
static void
gfc_handle_module_path_options (const char *arg)
{
@@ -659,31 +632,18 @@ gfc_handle_option (size_t scode, const c
case OPT_Wcharacter_truncation:
gfc_option.warn_character_truncation = value;
break;
- case OPT_Wcompare_reals:
- gfc_option.warn_compare_reals = value;
- break;
-
case OPT_Wconversion:
gfc_option.gfc_warn_conversion = value;
break;
case OPT_Wconversion_extra:
gfc_option.warn_conversion_extra = value;
break;
- case OPT_Wextra:
- handle_generated_option (&global_options, &global_options_set,
- OPT_Wunused_parameter, NULL, value,
- gfc_option_lang_mask (), kind, loc,
- handlers, global_dc);
- set_Wextra (value);
-
- break;
-
case OPT_Wfunction_elimination:
gfc_option.warn_function_elimination = value;
break;
case OPT_Wimplicit_interface:
>From gcc-bugs-return-450307-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Apr 30 23:47:39 2014
Return-Path: <gcc-bugs-return-450307-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16097 invoked by alias); 30 Apr 2014 23:47:38 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16011 invoked by uid 48); 30 Apr 2014 23:47:24 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/61023] set/map move assignment doesn't move (or copy) the comparator
Date: Wed, 30 Apr 2014 23:47:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61023-4-EyBEq3S5in@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61023-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61023-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg02327.txt.bz2
Content-length: 217
http://gcc.gnu.org/bugzilla/show_bug.cgi?ida023
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The standard forgot to say what should happen:
http://cplusplus.github.io/LWG/lwg-active.html#2227
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2014-04-30 23:01 ` manu at gcc dot gnu.org
@ 2014-05-03 8:27 ` burnus at gcc dot gnu.org
2014-05-03 9:47 ` manu at gcc dot gnu.org
` (9 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: burnus at gcc dot gnu.org @ 2014-05-03 8:27 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #10 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #8)
> /home/manuel/test1/test-gfc-warning.f03:11:0:
> arr = (/ INTEGER(KIND=4) :: HUGE(0_8) /) ! { dg-warning "conversion from"
> }
> 1
> Warning: Possible change of value in conversion from INTEGER(8) to
> INTEGER(4) at (1) [-Wconversion]
Looks good to me at a glance. However, I have not yet applied the patch and
played around with it.
Thanks for working on this!
> Also, is there any case where gcf_linebuf.file->filename !=
> LOCATION_FILE(gcf_linebuf.location) ?
Seemingly not. I tried to use:
a) include "some_file"
b) #include "some_file"
and the latter using both "-cpp" and using the pre-processed output as input.
And it always worked.
Also looking at the code in scanner.c, it seems as if it is always set to the
correct value:
get_file (const char *name, enum lc_reason reason ATTRIBUTE_UNUSED)
...
f->filename = xstrdup (name);
...
linemap_add (line_table, reason, false, f->filename, 1);
Thus, on terms of the linebuffer, there should be no reason of having
"filename" at all. It seems to get used in scanner.c itself - where some of the
diagnostic by-passes the default diagnostic. Either by constructing the
file/line numbers manually or even by calling "fprintf(stderr" directly.
[One probably should do some clean up there as well… But having the 'proper'
diagnostic for the rest would be a start.]
> So the only remaining major issue is the offset. It is not clear to me why
> Fortran needs an explicit offset, don't you track locations when parsing
> using line-map.c
Seemingly, we don't. The offset within a line is calculated using:
c1 = l1->nextc - l1->lb->line;
and in "next_char" one simply uses:
c = *gfc_current_locus.nextc++;
For the line map, we just use:
b->location
= linemap_line_start (line_table, current_file->line++, 120);
which gives the line but not the offset.
One might handle this in a more clever way, but can't you use in gfc_warning2,
gfortran's normal "locus" and use linemap_position_for_column() to map from the
offset to the column?
Another thing I wonder how to handle best is the case of having two locations
in the same line, e.g.
integer, allocatable :: v(:)
allocate (v(3), v(4))
end
that currently prints:
foo.f90:foo.f90:2.10-16:
allocate (v(3), v(4))
1 2
Error: Allocate-object at (1) also appears at (2)
or with line break (note the "&"):
allocate (v(3), &
v(4))
as
foo.f90:foo.f90:2.10:
allocate (v(3), &
1
foo.f90:foo.f90:3.10:
v(4))
2
Error: Allocate-object at (1) also appears at (2)
>From gcc-bugs-return-450429-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat May 03 09:08:53 2014
Return-Path: <gcc-bugs-return-450429-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2828 invoked by alias); 3 May 2014 09:08:53 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2802 invoked by uid 55); 3 May 2014 09:08:49 -0000
From: "dominiq at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/61025] [4.10 regression] FAIL: gfortran.dg/coarray_lib_this_image_1.f90
Date: Sat, 03 May 2014 09:08:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: burnus@net-b.de
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61025-4-eRCDv8opL6@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61025-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61025-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00121.txt.bz2
Content-length: 947
http://gcc.gnu.org/bugzilla/show_bug.cgi?ida025
--- Comment #2 from dominiq at gcc dot gnu.org ---
Author: dominiq
Date: Sat May 3 09:08:15 2014
New Revision: 210031
URL: http://gcc.gnu.org/viewcvs?rev!0031&root=gcc&view=rev
Log:
2014-05-03 Dominique d'Humieres <dominiq@lps.ens.fr>
PR fortran/61025
* gfortran.dg/coarray_lib_this_image_1.f90: Adjust the dg-final
regexps for -m32.
* gfortran.dg/coarray_lib_this_image_2.f90: Likewise.
* gfortran.dg/coarray_poly_7.f90: Likewise.
* gfortran.dg/coarray_poly_8.f90: Likewise.
* gfortran.dg/coarray_poly_9.f90: Likewise.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/coarray_lib_this_image_1.f90
trunk/gcc/testsuite/gfortran.dg/coarray_lib_this_image_2.f90
trunk/gcc/testsuite/gfortran.dg/coarray_poly_6.f90
trunk/gcc/testsuite/gfortran.dg/coarray_poly_7.f90
trunk/gcc/testsuite/gfortran.dg/coarray_poly_8.f90
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2014-05-03 8:27 ` burnus at gcc dot gnu.org
@ 2014-05-03 9:47 ` manu at gcc dot gnu.org
2014-08-15 15:11 ` manu at gcc dot gnu.org
` (8 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-05-03 9:47 UTC (permalink / raw)
To: gcc-bugs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 10143 bytes --]
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #11 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #10)
> Looks good to me at a glance. However, I have not yet applied the patch and
> played around with it.
>
> Thanks for working on this!
Thanks for looking at it. If you have a suggestion for a warning that doesn't
use %L, I could produce a simpler but more complete proof-of-concept.
> > Also, is there any case where gcf_linebuf.file->filename !=
> > LOCATION_FILE(gcf_linebuf.location) ?
>
> Seemingly not. I tried to use:
It would simplify the work on this PR to remove it and use LOCATION_FILE() in
gfortran.
> > So the only remaining major issue is the offset. It is not clear to me why
> > Fortran needs an explicit offset, don't you track locations when parsing
> > using line-map.c
>
> Seemingly, we don't. The offset within a line is calculated using:
> c1 = l1->nextc - l1->lb->line;
> and in "next_char" one simply uses:
> c = *gfc_current_locus.nextc++;
>
> For the line map, we just use:
> b->location
> = linemap_line_start (line_table, current_file->line++, 120);
> which gives the line but not the offset.
>
>
> One might handle this in a more clever way, but can't you use in
> gfc_warning2, gfortran's normal "locus" and use
> linemap_position_for_column() to map from the offset to the column?
You cannot insert new locations out of order in a line-map. Perhaps one could
create a dummy line-map, but it would be easier if the diagnostics machinery
handled arbitrary offsets, so I would favor that. Arbitrary offsets are useful
also to other FEs for some special cases anyway.
Of course, the two things are not incompatible: 1) gfortran could use the full
linemaps for tracking column numbers, thus removing another duplication of code
and 2) for particular cases, the diagnostic machinery could handle explicit
offsets passed by gfortran.
> Another thing I wonder how to handle best is the case of having two
> locations in the same line, e.g.
> integer, allocatable :: v(:)
> allocate (v(3), v(4))
> end
> that currently prints:
> foo.f90:foo.f90:2.10-16:
> allocate (v(3), v(4))
> 1 2
> Error: Allocate-object at (1) also appears at (2)
>
> or with line break (note the "&"):
> allocate (v(3), &
> v(4))
> as
> foo.f90:foo.f90:2.10:
> allocate (v(3), &
> 1
> foo.f90:foo.f90:3.10:
> v(4))
> 2
> Error: Allocate-object at (1) also appears at (2)
To implement this, the diagnostic machinery should be able to handle two
locations first. Then diagnostic_show_locus should handle two locations as
well. The particular format used by gfortran will be achieved by playing with
the prefix in gcf_diagnostic_starter. The major difficulty is in implementing
the one with the line break. A possible solution would be to make
diagnostic_build_prefix a hook that can be overriden by the FE and call it from
diagnostic_show_locus for each extra line shown. It doesn't seem a lot of work
in any case, so I think this is not a show-stopper. But I'd rather start with
the simplest cases (for example, those warnings that don't use any explicit
%L).
However, I don't want to spend a lot of effort on this if there is no interest
in the Fortran side. I'm happy to give guidance, to implement things in the
common diagnostic machinery and to implement proof-of-concept patches for the
Fortran side, but someone else needs to go over the list of Fortran warnings
and update them, build and test one by one. As I said, the work can be done
incrementally, but I don't have the time to do it all and I'd rather not start
if no one on the Fortran side plans to continue it.
>From gcc-bugs-return-450432-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat May 03 10:03:27 2014
Return-Path: <gcc-bugs-return-450432-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30782 invoked by alias); 3 May 2014 10:03:27 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30729 invoked by uid 48); 3 May 2014 10:03:24 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
Date: Sat, 03 May 2014 10:03:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.6.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-44054-4-CXchyU2Sw4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-44054-4@http.gcc.gnu.org/bugzilla/>
References: <bug-44054-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00124.txt.bz2
Content-length: 1086
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #12 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
> > One might handle this in a more clever way, but can't you use in
> > gfc_warning2, gfortran's normal "locus" and use
> > linemap_position_for_column() to map from the offset to the column?
>
> You cannot insert new locations out of order in a line-map. Perhaps one
> could create a dummy line-map, but it would be easier if the diagnostics
> machinery handled arbitrary offsets, so I would favor that. Arbitrary
> offsets are useful also to other FEs for some special cases anyway.
>
> Of course, the two things are not incompatible: 1) gfortran could use the
> full linemaps for tracking column numbers, thus removing another duplication
> of code and 2) for particular cases, the diagnostic machinery could handle
> explicit offsets passed by gfortran.
Or in other words: This PR can be fixed without gfortran tracking
column-numbers using line-maps (just using an explicit offset), but you'll need
that for fixing PR 53934.
>From gcc-bugs-return-450433-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat May 03 11:42:47 2014
Return-Path: <gcc-bugs-return-450433-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12934 invoked by alias); 3 May 2014 11:42:46 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12911 invoked by uid 48); 3 May 2014 11:42:42 -0000
From: "andysem at mail dot ru" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/61043] New: LTO accumulates CPU requirements from all input objects
Date: Sat, 03 May 2014 11:42:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: andysem at mail dot ru
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-61043-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg00125.txt.bz2
Content-length: 1603
http://gcc.gnu.org/bugzilla/show_bug.cgi?ida043
Bug ID: 61043
Summary: LTO accumulates CPU requirements from all input
objects
Product: gcc
Version: 4.8.2
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: lto
Assignee: unassigned at gcc dot gnu.org
Reporter: andysem at mail dot ru
Created attachment 32726
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id2726&actioníit
A test case to reproduce the problem
I have a test case (attached) with several input files. main.cpp contains
generic code that should run on any CPU, and add_sse2.c and add_avx2.c
containing optimized code with SSE2 and AVX2 intrinsics, respectively. main.cpp
detects CPU features in run time and invokes the optimized code when possible.
The problem is when this test is compiled with LTO enabled, the resulting
executable contains add_sse2 function with VEX-encoded instructions (i.e. with
AVX-128 code instead of legacy SSE2). This does not happen when LTO is not
enabled. My guess is that LTO computes the highest required CPU across all
input object files (which is one with AVX2 in this case) and generates code for
it instead of generating code for the CPU that was specified during the
compilation stage. The expected behavior would be to record target-related
compiler options for every function and use these options at LTO stage.
To compile the test you can use compile.sh. To obtain disassembled code you can
use disasm.sh. Look for add_sse2 code in the disassembly.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2014-05-03 9:47 ` manu at gcc dot gnu.org
@ 2014-08-15 15:11 ` manu at gcc dot gnu.org
2014-10-28 22:17 ` manu at gcc dot gnu.org
` (7 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-08-15 15:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #13 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Fri Aug 15 15:10:15 2014
New Revision: 214024
URL: https://gcc.gnu.org/viewcvs?rev=214024&root=gcc&view=rev
Log:
2014-08-15 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
gcc/
* diagnostic.c (build_message_string): Make it extern.
* diagnostic.h (build_message_string): Make it extern.
c-family/
* c-format.c: Handle Fortran flags.
fortran/
* gfortran.h: Define GCC_DIAG_STYLE.
(gfc_diagnostics_init,gfc_warning_cmdline): Declare.
* trans-array.c: Include gfortran.h before diagnostic-core.h.
* trans-expr.c: Likewise.
* trans-openmp.c: Likewise.
* trans-const.c: Likewise.
* trans.c: Likewise.
* trans-types.c: Likewise.
* f95-lang.c: Likewise.
* trans-decl.c: Likewise.
* trans-io.c: Likewise.
* trans-intrinsic.c: Likewise.
* error.c: Include diagnostic.h and diagnostic-color.h.
(gfc_diagnostic_build_prefix): New.
(gfc_diagnostic_starter): New.
(gfc_diagnostic_finalizer): New.
(gfc_warning_cmdline): New.
(gfc_diagnostics_init): New.
* gfc-diagnostic.def: New.
* options.c (gfc_init_options): Call gfc_diagnostics_init.
(gfc_post_options): Use gfc_warning_cmdline.
Added:
trunk/gcc/fortran/gfc-diagnostic.def
Modified:
trunk/gcc/ChangeLog
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c-format.c
trunk/gcc/diagnostic.c
trunk/gcc/diagnostic.h
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/error.c
trunk/gcc/fortran/f95-lang.c
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/options.c
trunk/gcc/fortran/trans-array.c
trunk/gcc/fortran/trans-const.c
trunk/gcc/fortran/trans-decl.c
trunk/gcc/fortran/trans-expr.c
trunk/gcc/fortran/trans-intrinsic.c
trunk/gcc/fortran/trans-io.c
trunk/gcc/fortran/trans-openmp.c
trunk/gcc/fortran/trans-types.c
trunk/gcc/fortran/trans.c
>From gcc-bugs-return-458594-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Aug 15 15:23:20 2014
Return-Path: <gcc-bugs-return-458594-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 8688 invoked by alias); 15 Aug 2014 15:23:20 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 8658 invoked by uid 55); 15 Aug 2014 15:23:16 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/62154] std::throw_with_nested should not require a polymorphic type
Date: Fri, 15 Aug 2014 15:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-62154-4-fMPoEOB93E@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-62154-4@http.gcc.gnu.org/bugzilla/>
References: <bug-62154-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg01091.txt.bz2
Content-length: 628
https://gcc.gnu.org/bugzilla/show_bug.cgi?idb154
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Fri Aug 15 15:22:44 2014
New Revision: 214025
URL: https://gcc.gnu.org/viewcvs?rev!4025&root=gcc&view=rev
Log:
PR libstdc++/62154
* libsupc++/nested_exception.h (throw_with_nested, rethrow_if_nested):
Rewrite to conform to C++11 requirements.
* testsuite/18_support/nested_exception/62154.cc: New.
Added:
trunk/libstdc++-v3/testsuite/18_support/nested_exception/62154.cc
Modified:
trunk/libstdc++-v3/ChangeLog
trunk/libstdc++-v3/libsupc++/nested_exception.h
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2014-08-15 15:11 ` manu at gcc dot gnu.org
@ 2014-10-28 22:17 ` manu at gcc dot gnu.org
2014-11-11 22:51 ` manu at gcc dot gnu.org
` (6 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-10-28 22:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #17 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Tue Oct 28 21:56:24 2014
New Revision: 216812
URL: https://gcc.gnu.org/viewcvs?rev=216812&root=gcc&view=rev
Log:
2014-10-28 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* gfortran.h (gfc_warning_cmdline): Rename as gfc_warning_now_2.
(gfc_error_cmdline): Rename as gfc_error_now_2.
* error.c (gfc_diagnostic_build_locus_prefix): Remove trailing space.
(gfc_diagnostic_starter): Add space between locus and prefix.
(gfc_warning_now_2): Renamed from gfc_warning_cmdline.
(gfc_error_now_2): Renamed from gfc_error_cmdline.
* scanner.c (add_path_to_list): Use gfc_warning_now_2.
(load_line): Likewise.
(load_file): Likewise.
* options.c (gfc_post_options): Update all renamed functions.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/error.c
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/options.c
trunk/gcc/fortran/scanner.c
>From gcc-bugs-return-465187-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 28 22:17:07 2014
Return-Path: <gcc-bugs-return-465187-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22511 invoked by alias); 28 Oct 2014 22:17:07 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 22449 invoked by uid 48); 28 Oct 2014 22:17:01 -0000
From: "wdijkstr at arm dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63503] [AArch64] A57 executes fused multiply-add poorly in some situations
Date: Tue, 28 Oct 2014 22:40:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: wdijkstr at arm dot com
X-Bugzilla-Status: WAITING
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63503-4-rsDNOdUGz9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63503-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63503-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02208.txt.bz2
Content-length: 1204
https://gcc.gnu.org/bugzilla/show_bug.cgi?idc503
--- Comment #22 from Wilco <wdijkstr at arm dot com> ---
(In reply to Evandro from comment #21)
> (In reply to ramana.radhakrishnan@arm.com from comment #20)
> > What's the kind of performance delta you see if you managed to unroll
> > the loop just a wee bit ? Probably not much looking at the code produced
> > here.
>
> Comparing the cycle counts on Juno when running the program from the matrix
> multiplication test above built with -Ofast and unrolling:
>
> -fno-unroll-loops: 592000
> -funroll-loops --param max-unroll-times=2: 594000
> -funroll-loops --param max-unroll-times=4: 592000
> -funroll-loops: 590000 (implies --param max-unroll-times=8)
> -funroll-loops --param max-unroll-times\x16: 581000
>
> It seems to me that without effective iv-opt in place, loops have to be
> unrolled too aggressively to make any difference in this case, greatly
> sacrificing code size.
Unrolling alone isn't good enough in sum reductions. As I mentioned before, GCC
doesn't enable any of the useful loop optimizations by default. So add
-fvariable-expansion-in-unroller to get a good speedup with unrolling. Again
these are all generic GCC issues.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2014-10-28 22:17 ` manu at gcc dot gnu.org
@ 2014-11-11 22:51 ` manu at gcc dot gnu.org
2014-11-23 23:48 ` manu at gcc dot gnu.org
` (5 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-11-11 22:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #18 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Tue Nov 11 22:50:48 2014
New Revision: 217383
URL: https://gcc.gnu.org/viewcvs?rev=217383&root=gcc&view=rev
Log:
libcpp/ChangeLog:
2014-11-11 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* include/line-map.h (linemap_position_for_loc_and_offset):
Declare.
* line-map.c (linemap_position_for_loc_and_offset): New.
gcc/fortran/ChangeLog:
2014-11-11 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* gfortran.h (warn_use_without_only): Remove.
(gfc_diagnostics_finish): Declare.
* error.c: Include tree-diagnostics.h
(gfc_format_decoder): New.
(gfc_diagnostics_init): Use gfc_format_decoder. Set default caret
char.
(gfc_diagnostics_finish): Restore tree diagnostics defaults, but
keep gfc_diagnostics_starter and finalizer. Restore default caret.
* options.c: Remove all uses of warn_use_without_only.
* lang.opt (Wuse-without-only): Add Var.
* f95-lang.c (gfc_be_parse_file): Call gfc_diagnostics_finish.
* module.c (gfc_use_module): Use gfc_warning_now_2.
* parse.c (decode_statement): Likewise.
(decode_gcc_attribute): Likewise.
(next_free): Likewise.
(next_fixed): Likewise.
gcc/testsuite/ChangeLog:
2014-11-11 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* lib/gfortran-dg.exp: Update regexp to match locus and message
without caret.
* gfortran.dg/use_without_only_1.f90: Add column numbers.
* gfortran.dg/warnings_are_errors_1.f: Update.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/error.c
trunk/gcc/fortran/f95-lang.c
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/lang.opt
trunk/gcc/fortran/module.c
trunk/gcc/fortran/options.c
trunk/gcc/fortran/parse.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/use_without_only_1.f90
trunk/gcc/testsuite/gfortran.dg/warnings_are_errors_1.f
trunk/gcc/testsuite/lib/gfortran-dg.exp
trunk/libcpp/ChangeLog
trunk/libcpp/include/line-map.h
trunk/libcpp/line-map.c
>From gcc-bugs-return-466454-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 11 23:34:09 2014
Return-Path: <gcc-bugs-return-466454-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6879 invoked by alias); 11 Nov 2014 23:34:09 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6802 invoked by uid 55); 11 Nov 2014 23:33:59 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/36312] should refuse to overwrite input file with output file
Date: Tue, 11 Nov 2014 23:34:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 4.1.2
X-Bugzilla-Keywords: diagnostic, patch
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: REOPENED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-36312-4-sj0z14g2oU@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-36312-4@http.gcc.gnu.org/bugzilla/>
References: <bug-36312-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg00926.txt.bz2
Content-length: 1956
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36312
--- Comment #13 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Tue Nov 11 23:33:25 2014
New Revision: 217391
URL: https://gcc.gnu.org/viewcvs?rev=217391&root=gcc&view=rev
Log:
gcc/testsuite/ChangeLog:
2014-11-11 Anthony Brandon <anthony.brandon@gmail.com>
Manuel López-Ibáñez <manu@gcc.gnu.org>
PR driver/36312
* gcc.misc-tests/output.exp: New test case for identical input and
output files.
include/ChangeLog:
2014-11-11 Anthony Brandon <anthony.brandon@gmail.com>
Manuel López-Ibáñez <manu@gcc.gnu.org>
PR driver/36312
* filenames.h: Add prototype for canonical_filename_eq.
gcc/ChangeLog:
2014-11-11 Anthony Brandon <anthony.brandon@gmail.com>
Manuel López-Ibáñez <manu@gcc.gnu.org>
PR driver/36312
* diagnostic-core.h: Add prototype for fatal_error.
* diagnostic.c (fatal_error): New function fatal_error.
* gcc.c (store_arg): Remove have_o_argbuf_index.
(process_command): Check if input and output files are the same.
* toplev.c (init_asm_output): Check if input and output files are
the same.
libiberty/ChangeLog:
2014-11-11 Anthony Brandon <anthony.brandon@gmail.com>
Manuel López-Ibáñez <manu@gcc.gnu.org>
PR driver/36312
* filename_cmp.c (canonical_filename_eq): New function to check if
file names are the same.
* functions.texi: Updated with documentation for new function.
Added:
trunk/gcc/testsuite/gcc.misc-tests/output.exp
Modified:
trunk/gcc/ChangeLog
trunk/gcc/diagnostic-core.h
trunk/gcc/diagnostic.c
trunk/gcc/gcc.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/toplev.c
trunk/include/ChangeLog
trunk/include/filenames.h
trunk/libiberty/ChangeLog
trunk/libiberty/filename_cmp.c
trunk/libiberty/functions.texi
>From gcc-bugs-return-466455-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 11 23:38:18 2014
Return-Path: <gcc-bugs-return-466455-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 11891 invoked by alias); 11 Nov 2014 23:38:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 11829 invoked by uid 48); 11 Nov 2014 23:38:13 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/36312] should refuse to overwrite input file with output file
Date: Tue, 11 Nov 2014 23:38:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: driver
X-Bugzilla-Version: 4.1.2
X-Bugzilla-Keywords: diagnostic, patch
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-36312-4-LKOIdOv3Yv@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-36312-4@http.gcc.gnu.org/bugzilla/>
References: <bug-36312-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg00927.txt.bz2
Content-length: 466
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36312
Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #14 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Fixed.
>From gcc-bugs-return-466458-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 11 23:40:42 2014
Return-Path: <gcc-bugs-return-466458-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 18913 invoked by alias); 11 Nov 2014 23:40:42 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18272 invoked by uid 55); 11 Nov 2014 23:40:36 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61997] cc1plus ICE with aarch64 target using PCH and builtin functions
Date: Tue, 11 Nov 2014 23:40:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: major
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61997-4-rY3cJknfOi@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61997-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61997-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg00929.txt.bz2
Content-length: 641
https://gcc.gnu.org/bugzilla/show_bug.cgi?ida997
--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Author: pinskia
Date: Tue Nov 11 23:40:03 2014
New Revision: 217394
URL: https://gcc.gnu.org/viewcvs?rev!7394&root=gcc&view=rev
Log:
2014-11-11 Andrew Pinski <apinski@cavium.com>
Bug target/61997
* config.gcc (aarch64*-*-*): Set target_gtfiles to include
aarch64-builtins.c.
* config/aarch64/aarch64-builtins.c: Include gt-aarch64-builtins.h
at the end of the file.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config.gcc
trunk/gcc/config/aarch64/aarch64-builtins.c
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2014-11-11 22:51 ` manu at gcc dot gnu.org
@ 2014-11-23 23:48 ` manu at gcc dot gnu.org
2014-12-11 15:14 ` manu at gcc dot gnu.org
` (4 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-11-23 23:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #19 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Sun Nov 23 23:47:42 2014
New Revision: 217992
URL: https://gcc.gnu.org/viewcvs?rev=217992&root=gcc&view=rev
Log:
gcc/fortran/ChangeLog:
2014-11-23 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* decl.c (gfc_verify_c_interop_param): Use gfc_error_now_2.
(gfc_set_constant_character_len): Use gfc_warning_now_2.
* resolve.c (resolve_ordinary_assign): Likewise.
* gfortran.h (warn_character_truncation): Do not declare here.
* error.c (gfc_format_decoder): Handle %L.
* lang.opt (Wcharacter-truncation): Add Var and LangEnabledBy.
* options.c (gfc_init_options): Do not handle
warn_character_truncation explicitly.
(set_Wall): Likewise.
(gfc_handle_option): Likewise.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/decl.c
trunk/gcc/fortran/error.c
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/lang.opt
trunk/gcc/fortran/options.c
trunk/gcc/fortran/resolve.c
>From gcc-bugs-return-468171-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Nov 24 00:01:09 2014
Return-Path: <gcc-bugs-return-468171-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12327 invoked by alias); 24 Nov 2014 00:01:08 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12263 invoked by uid 55); 24 Nov 2014 00:01:04 -0000
From: "dave.anglin at bell dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/59708] clang-compatible checked arithmetic builtins
Date: Mon, 24 Nov 2014 00:01:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: dave.anglin at bell dot net
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59708-4-I4cMe33ii7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59708-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59708-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg02643.txt.bz2
Content-length: 290
https://gcc.gnu.org/bugzilla/show_bug.cgi?idY708
--- Comment #21 from dave.anglin at bell dot net ---
On 22-Nov-14, at 2:31 AM, jakub at gcc dot gnu.org wrote:
> Is that with r217946 or later?
This is now fixed on hppa-unknown-linux-gnu.
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2014-11-23 23:48 ` manu at gcc dot gnu.org
@ 2014-12-11 15:14 ` manu at gcc dot gnu.org
2014-12-11 15:38 ` manu at gcc dot gnu.org
` (3 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-12-11 15:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #21 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Thu Dec 11 15:13:33 2014
New Revision: 218627
URL: https://gcc.gnu.org/viewcvs?rev=218627&root=gcc&view=rev
Log:
gcc/ChangeLog:
2014-12-11 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* diagnostic.c (diagnostic_action_after_output): Make it extern.
Take diagnostic_t argument instead of diagnostic_info. Count also
DK_WERROR towards max_errors.
(diagnostic_report_diagnostic): Update call according to the above.
(error_recursion): Likewise.
* diagnostic.h (diagnostic_action_after_output): Declare.
* pretty-print.c (pp_formatted_text_data): Delete.
(pp_append_r): Call output_buffer_append_r.
(pp_formatted_text): Call output_buffer_formatted_text.
(pp_last_position_in_text): Call output_buffer_last_position_in_text.
* pretty-print.h (output_buffer_formatted_text): New.
(output_buffer_append_r): New.
(output_buffer_last_position_in_text): New.
gcc/testsuite/ChangeLog:
2014-12-11 Manuel López-Ibáñez <manu@gcc.gnu.org>
* gfortran.dg/do_iterator.f90: Remove bogus dg-warning.
gcc/fortran/ChangeLog:
2014-12-11 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* error.c (pp_error_buffer): New static variable.
(pp_warning_buffer): Make it a pointer.
(gfc_output_buffer_empty_p): New.
(gfc_error_init_1): Call gfc_buffer_error.
(gfc_buffer_error): Do not use pp_warning_buffer.flush_p as the
buffered_p flag.
(gfc_clear_warning): Likewise.
(gfc_warning_check): Call gfc_clear_warning. Only check the new
pp_warning_buffer if the old warning_buffer was empty. Call
diagnostic_action_after_output.
(gfc_error_1): Renamed from gfc_error.
(gfc_error): New.
(gfc_clear_error): Clear also pp_error_buffer.
(gfc_error_flag_test): Check also pp_error_buffer.
(gfc_error_check): Likewise. Only check the new pp_error_buffer
if the old error_buffer was empty.
(gfc_move_output_buffer_from_to): New.
(gfc_push_error): Use it here. Take also an output_buffer as argument.
(gfc_pop_error): Likewise.
(gfc_free_error): Likewise.
(gfc_diagnostics_init): Use XNEW and placement-new to init
pp_error_buffer and pp_warning_buffer. Set flush_p to false for
both pp_warning_buffer and pp_error_buffer.
* Update gfc_push_error, gfc_pop_error and gfc_free_error calls
according to the above changes.
* Use gfc_error_1 for all gfc_error calls that use multiple
locations.
* Use %qs instead of '%s' for many gfc_error calls.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/diagnostic.c
trunk/gcc/diagnostic.h
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/arith.c
trunk/gcc/fortran/array.c
trunk/gcc/fortran/check.c
trunk/gcc/fortran/class.c
trunk/gcc/fortran/data.c
trunk/gcc/fortran/decl.c
trunk/gcc/fortran/error.c
trunk/gcc/fortran/expr.c
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/interface.c
trunk/gcc/fortran/intrinsic.c
trunk/gcc/fortran/match.c
trunk/gcc/fortran/openmp.c
trunk/gcc/fortran/parse.c
trunk/gcc/fortran/primary.c
trunk/gcc/fortran/resolve.c
trunk/gcc/fortran/scanner.c
trunk/gcc/fortran/symbol.c
trunk/gcc/fortran/trans-common.c
trunk/gcc/pretty-print.c
trunk/gcc/pretty-print.h
trunk/gcc/testsuite/ChangeLog
>From gcc-bugs-return-470286-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Dec 11 15:19:43 2014
Return-Path: <gcc-bugs-return-470286-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22062 invoked by alias); 11 Dec 2014 15:19:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21984 invoked by uid 48); 11 Dec 2014 15:19:37 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/64269] [4.8/4.9/5 Regression] ICE with -O3 enabled on Ubuntu 14.04
Date: Thu, 11 Dec 2014 15:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc cf_known_to_work target_milestone short_desc
Message-ID: <bug-64269-4-SfygnqxpSy@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64269-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64269-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg01293.txt.bz2
Content-length: 962
https://gcc.gnu.org/bugzilla/show_bug.cgi?idd269
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
Known to work| |4.7.4
Target Milestone|--- |4.8.4
Summary|ICE with -O3 enabled on |[4.8/4.9/5 Regression] ICE
|Ubuntu 14.04 |with -O3 enabled on Ubuntu
| |14.04
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Works with 4.7.x.
1395 memset (src_buf + tree_to_uhwi (diff),
1396 tree_to_shwi (val2), tree_to_uhwi (len2));
(gdb) p debug_generic_expr (len2)
18446744073709551615
(that's -1)
function added by Jakub (simplify_builtin_call).
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2014-12-11 15:14 ` manu at gcc dot gnu.org
@ 2014-12-11 15:38 ` manu at gcc dot gnu.org
2014-12-11 16:31 ` burnus at gcc dot gnu.org
` (2 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2014-12-11 15:38 UTC (permalink / raw)
To: gcc-bugs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 6331 bytes --]
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #22 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
I think the two remaining issues are:
1) Multiple locations (%C/%L) in diagnostics
2) Support !GCC$ diagnostic (pragmas)
For (2), I'm not planning to work on it since it seems all the common support
is there, Fortran just needs to parse and handle the pragmas in the same way as
the C/C++ FEs do. There may be some opportunity for code sharing (perhaps the
pragmas are language specific and they should not be), but I haven't looked at
the details.
For (1), my plan is to add location_t location[2] to text_info and make
diagnostic_context directly use those. The common part in diagnostic.c will
need some refactoring to print two caret chars in the same line and to
customize which caret char and which location is printed so that Fortran can
print the second location on a different line with a different caret char when
desired. The most tricky part is how to handle the prefix/locus_prefix
difference when there is zero, one or two caret lines printed, in
gfc_diagnostic_starter(). Handling two locations in gfc_format_decoder is
trivial if one considers that the only way to set text->location[0] in Fortran
is via gfc_format_decoder itself:
--- gcc/fortran/error.c (revision 218628)
+++ gcc/fortran/error.c (working copy)
@@ -1056,25 +1056,26 @@ gfc_format_decoder (pretty_printer *pp,
switch (*spec)
{
case 'C':
case 'L':
{
- static const char *result = "(1)";
+ static const char *result[2] = { "(1)", "(2)" };
locus *loc;
if (*spec == 'C')
loc = &gfc_current_locus;
else
loc = va_arg (*text->args_ptr, locus *);
gcc_assert (loc->nextc - loc->lb->line >= 0);
unsigned int offset = loc->nextc - loc->lb->line;
- gcc_assert (text->locus);
- *text->locus
+ /* If location[0] != UNKNOWN_LOCATION means that we already
+ processed one of %C/%L. */
+ int loc_num = text->location[0] == UNKNOWN_LOCATION ? 0 : 1;
+ text->location[loc_num]
= linemap_position_for_loc_and_offset (line_table,
loc->lb->location,
offset);
- global_dc->caret_char = '1';
- pp_string (pp, result);
+ pp_string (pp, result[loc_num]);
return true;
}
default:
return false;
}
>From gcc-bugs-return-470289-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Dec 11 15:44:26 2014
Return-Path: <gcc-bugs-return-470289-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 13201 invoked by alias); 11 Dec 2014 15:44:25 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 13158 invoked by uid 48); 11 Dec 2014 15:44:22 -0000
From: "kuehro at gmx dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/64271] New: Minimal patches to bootstrap on NetBSD
Date: Thu, 11 Dec 2014 15:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: blocker
X-Bugzilla-Who: kuehro at gmx dot de
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-64271-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg01296.txt.bz2
Content-length: 1999
https://gcc.gnu.org/bugzilla/show_bug.cgi?idd271
Bug ID: 64271
Summary: Minimal patches to bootstrap on NetBSD
Product: gcc
Version: 5.0
Status: UNCONFIRMED
Severity: blocker
Priority: P3
Component: bootstrap
Assignee: unassigned at gcc dot gnu.org
Reporter: kuehro at gmx dot de
Created attachment 34253
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id4253&actioníit
libstdc++-patch1
Bootstrap of 5.0 fails on NetBSD, but with the patches in NetBSD's package
system
pkgsrc it builds a functional gcc. In Bug #48244 I was asked to submit a
minimal set of patches to bootstrap with testresults. So I did a stepwise
bootstrap until failure and used the relevant patches from pkgsrc, precisely
http://pkgsrc-wip.cvs.sourceforge.net/viewvc/pkgsrc-wip/wip/gcc50snapshot/
On NetBSD 7.0 amd64:
/home/kue/build/gcc_patched/gcc-5-20141207/configure --disable-nls
--with-libiconv-prefix=/usr --enable-__cxa_atexit
--with-gxx-include-dir=/home/kue/gcc5install/include/c++/ --enable-languages='c
obj-c++ objc fortran c++' --enable-shared --enable-long-long
--with-local-prefix=/home/kue/gcc5install --enable-libssp
--enable-threads=posix --with-boot-ldflags='-static-libstdc++ -static-libgcc
-Wl,-R/home/kue/local/lib ' --with-gnu-ld --with-ld=/usr/bin/ld --with-gnu-as
--with-as=/usr/bin/as --with-arch=nocona --with-tune=nocona --with-fpmath=sse
--prefix=/home/kue/gcc5install --build=x86_64--netbsd --host=x86_64--netbsd
--infodir=/home/kue/gcc5install/info --mandir=/home/kue/gcc5install/man
ac_cv_func_clock_gettime=yes ac_cv_func_gethostbyname=yes
ac_cv_func_freelocale=no ac_cv_func_newlocale=no ac_cv_func_uselocale=no
env ac_cv_func_clock_gettime=yes ac_cv_func_gethostbyname=yes
ac_cv_func_freelocale=no ac_cv_func_newlocale=no ac_cv_func_uselocale=no gmake
2>&1|tee builderror.log
gmake -k check 2>&1|tee testsuiterun.log
the six attached patches are necessary to bootstrap.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2014-12-11 15:38 ` manu at gcc dot gnu.org
@ 2014-12-11 16:31 ` burnus at gcc dot gnu.org
2015-05-16 12:30 ` manu at gcc dot gnu.org
2015-05-24 10:02 ` manu at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: burnus at gcc dot gnu.org @ 2014-12-11 16:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #23 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #22)
> 2) Support !GCC$ diagnostic (pragmas)
That's now PR64273.
>From gcc-bugs-return-470308-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Dec 11 16:40:49 2014
Return-Path: <gcc-bugs-return-470308-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 1554 invoked by alias); 11 Dec 2014 16:40:48 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1530 invoked by uid 48); 11 Dec 2014 16:40:45 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/64273] Add support for "#pragma warning" or "!GCC$ warning directive"
Date: Thu, 11 Dec 2014 16:40:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-64273-4-hEc4LaxG7j@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64273-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64273-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg01315.txt.bz2
Content-length: 727
https://gcc.gnu.org/bugzilla/show_bug.cgi?idd273
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-12-11
Ever confirmed|0 |1
--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> There are two possibilities, either to use a real
> #pragma warning
> or to make it more Fortran-like and use
> !GCC$ warning directive
Yuck!-(I think there are a lot of really more important things to do. In any
case choose the latter).
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2014-12-11 16:31 ` burnus at gcc dot gnu.org
@ 2015-05-16 12:30 ` manu at gcc dot gnu.org
2015-05-24 10:02 ` manu at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2015-05-16 12:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #24 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Sat May 16 12:30:04 2015
New Revision: 223236
URL: https://gcc.gnu.org/viewcvs?rev=223236&root=gcc&view=rev
Log:
gcc/fortran/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
Replace all calls to gfc_notify_std_1 with gfc_notify_std and
gfc_warning_1 with gfc_warning.
* decl.c (gfc_verify_c_interop_param): Here.
* resolve.c (resolve_branch): Here.
(resolve_fl_derived): Here.
* dependency.c (gfc_check_argument_var_dependency):
* scanner.c (preprocessor_line): Use gfc_warning_now_at. Fix line
counter and locations before and after warning.
* gfortran.h (gfc_warning_1, gfc_warning_now_1, gfc_notify_std_1):
Delete.
(gfc_warning_now_at): Declare.
* error.c (gfc_warning_1): Delete.
(gfc_notify_std_1): Delete.
(gfc_warning_now_1): Delete.
(gfc_format_decoder): Handle two locations.
(gfc_diagnostic_build_prefix): Rename as
gfc_diagnostic_build_kind_prefix.
(gfc_diagnostic_build_locus_prefix): Take an expanded_location
instead of diagnostic_info.
(gfc_diagnostic_build_locus_prefix): Add overload that takes two
expanded_location.
(gfc_diagnostic_starter): Handle two locations.
(gfc_warning_now_at): New.
(gfc_diagnostics_init): Initialize caret_chars array.
(gfc_diagnostics_finish): Reset caret_chars array to default.
gcc/cp/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* error.c (cp_diagnostic_starter): Use diagnostic_location
function.
(cp_print_error_function): Likewise.
(cp_printer): Replace locus pointer with accessor function.
gcc/c/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* c-objc-common.c (c_tree_printer): Replace locus pointer with
accessor function.
gcc/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* tree-pretty-print.c (percent_K_format): Replace locus pointer
with accessor function.
* tree-diagnostic.c (diagnostic_report_current_function): Use
diagnostic_location function.
(maybe_unwind_expanded_macro_loc): Likewise.
(virt_loc_aware_diagnostic_finalizer): Likewise.
(default_tree_printer): Replace locus pointer with accessor function.
* diagnostic.c (diagnostic_initialize): Initialize caret_chars array.
(diagnostic_set_info_translated): Initialize second location.
(diagnostic_build_prefix): Use CARET_LINE_MARGIN.
(diagnostic_show_locus): Handle two locations. Call
diagnostic_print_caret_line.
(diagnostic_print_caret_line): New.
(default_diagnostic_starter): Use diagnostic_location function.
(diagnostic_report_diagnostic): Use diagnostic_location function.
(verbatim): Do not set text.locus.
* diagnostic.h (struct diagnostic_info): Remove location field.
(struct diagnostic_context): Make caret_chars an array of two.
(diagnostic_location): New inline.
(diagnostic_expand_location): Handle two locations.
(diagnostic_same_line): New inline.
(diagnostic_print_caret_line): Declare.
(CARET_LINE_MARGIN): New constant.
* pretty-print.c (pp_printf): Do not set text.locus.
(pp_verbatim): Do not set text.locus.
* pretty-print.h (MAX_LOCATIONS_PER_MESSAGE): New constant.
(struct text_info): Replace locus pointer with locations
array. Add accessor functions.
gcc/testsuite/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* lib/gfortran-dg.exp: Update regex to handle two locations for
the same diagnostic without caret.
* gfortran.dg/badline.f: Test also that line numbers are correct
before and after "left but not entered" warning.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/c/ChangeLog
trunk/gcc/cp/ChangeLog
trunk/gcc/fortran/ChangeLog
trunk/gcc/testsuite/ChangeLog
>From gcc-bugs-return-486433-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat May 16 12:31:36 2015
Return-Path: <gcc-bugs-return-486433-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 432 invoked by alias); 16 May 2015 12:31:36 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 374 invoked by uid 55); 16 May 2015 12:31:32 -0000
From: "manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
Date: Sat, 16 May 2015 12:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.6.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: manu at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-44054-4-kG6vSPveiS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-44054-4@http.gcc.gnu.org/bugzilla/>
References: <bug-44054-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01273.txt.bz2
Content-length: 4776
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #25 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Author: manu
Date: Sat May 16 12:31:00 2015
New Revision: 223237
URL: https://gcc.gnu.org/viewcvs?rev=223237&root=gcc&view=rev
Log:
gcc/fortran/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
Replace all calls to gfc_notify_std_1 with gfc_notify_std and
gfc_warning_1 with gfc_warning.
* decl.c (gfc_verify_c_interop_param): Here.
* resolve.c (resolve_branch): Here.
(resolve_fl_derived): Here.
* dependency.c (gfc_check_argument_var_dependency):
* scanner.c (preprocessor_line): Use gfc_warning_now_at. Fix line
counter and locations before and after warning.
* gfortran.h (gfc_warning_1, gfc_warning_now_1, gfc_notify_std_1):
Delete.
(gfc_warning_now_at): Declare.
* error.c (gfc_warning_1): Delete.
(gfc_notify_std_1): Delete.
(gfc_warning_now_1): Delete.
(gfc_format_decoder): Handle two locations.
(gfc_diagnostic_build_prefix): Rename as
gfc_diagnostic_build_kind_prefix.
(gfc_diagnostic_build_locus_prefix): Take an expanded_location
instead of diagnostic_info.
(gfc_diagnostic_build_locus_prefix): Add overload that takes two
expanded_location.
(gfc_diagnostic_starter): Handle two locations.
(gfc_warning_now_at): New.
(gfc_diagnostics_init): Initialize caret_chars array.
(gfc_diagnostics_finish): Reset caret_chars array to default.
gcc/cp/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* error.c (cp_diagnostic_starter): Use diagnostic_location
function.
(cp_print_error_function): Likewise.
(cp_printer): Replace locus pointer with accessor function.
gcc/c/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* c-objc-common.c (c_tree_printer): Replace locus pointer with
accessor function.
gcc/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* tree-pretty-print.c (percent_K_format): Replace locus pointer
with accessor function.
* tree-diagnostic.c (diagnostic_report_current_function): Use
diagnostic_location function.
(maybe_unwind_expanded_macro_loc): Likewise.
(virt_loc_aware_diagnostic_finalizer): Likewise.
(default_tree_printer): Replace locus pointer with accessor function.
* diagnostic.c (diagnostic_initialize): Initialize caret_chars array.
(diagnostic_set_info_translated): Initialize second location.
(diagnostic_build_prefix): Use CARET_LINE_MARGIN.
(diagnostic_show_locus): Handle two locations. Call
diagnostic_print_caret_line.
(diagnostic_print_caret_line): New.
(default_diagnostic_starter): Use diagnostic_location function.
(diagnostic_report_diagnostic): Use diagnostic_location function.
(verbatim): Do not set text.locus.
* diagnostic.h (struct diagnostic_info): Remove location field.
(struct diagnostic_context): Make caret_chars an array of two.
(diagnostic_location): New inline.
(diagnostic_expand_location): Handle two locations.
(diagnostic_same_line): New inline.
(diagnostic_print_caret_line): Declare.
(CARET_LINE_MARGIN): New constant.
* pretty-print.c (pp_printf): Do not set text.locus.
(pp_verbatim): Do not set text.locus.
* pretty-print.h (MAX_LOCATIONS_PER_MESSAGE): New constant.
(struct text_info): Replace locus pointer with locations
array. Add accessor functions.
gcc/testsuite/ChangeLog:
2015-05-16 Manuel López-Ibáñez <manu@gcc.gnu.org>
PR fortran/44054
* lib/gfortran-dg.exp: Update regex to handle two locations for
the same diagnostic without caret.
* gfortran.dg/badline.f: Test also that line numbers are correct
before and after "left but not entered" warning.
Modified:
trunk/gcc/c/c-objc-common.c
trunk/gcc/cp/error.c
trunk/gcc/diagnostic.c
trunk/gcc/diagnostic.h
trunk/gcc/fortran/decl.c
trunk/gcc/fortran/dependency.c
trunk/gcc/fortran/error.c
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/resolve.c
trunk/gcc/fortran/scanner.c
trunk/gcc/pretty-print.c
trunk/gcc/pretty-print.h
trunk/gcc/testsuite/gfortran.dg/badline.f
trunk/gcc/testsuite/lib/gfortran-dg.exp
trunk/gcc/tree-diagnostic.c
trunk/gcc/tree-pretty-print.c
>From gcc-bugs-return-486434-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat May 16 12:33:37 2015
Return-Path: <gcc-bugs-return-486434-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2737 invoked by alias); 16 May 2015 12:33:37 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2703 invoked by uid 55); 16 May 2015 12:33:33 -0000
From: "tkoenig at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/66113] Variable n cannot appear in the expression with nested blocks
Date: Sat, 16 May 2015 12:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 6.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tkoenig at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66113-4-f5dRAJDNFW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66113-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66113-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg01274.txt.bz2
Content-length: 713
https://gcc.gnu.org/bugzilla/show_bug.cgi?idf113
--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Author: tkoenig
Date: Sat May 16 12:33:01 2015
New Revision: 223238
URL: https://gcc.gnu.org/viewcvs?rev"3238&root=gcc&view=rev
Log:
2015-05-16 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/66113
* expr.c (is_parent_of_current_ns): New function.
(check_restricted): Use it.
2015-05-16 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/66113
* gfortran.dg/block_14.f90: New test.
Added:
trunk/gcc/testsuite/gfortran.dg/block_14.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/expr.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2015-05-16 12:30 ` manu at gcc dot gnu.org
@ 2015-05-24 10:02 ` manu at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: manu at gcc dot gnu.org @ 2015-05-24 10:02 UTC (permalink / raw)
To: gcc-bugs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 2653 bytes --]
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44054
--- Comment #27 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
From my POV, this is FIXED.
The only thing missing is the diagnostic pragmas:
https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Pragmas.html#Diagnostic-Pragmas
I'm not sure how pragmas work in the Fortran FE, but it should be a matter of
following more or less what the C/C++ FE do to interface with diagnostic.c.
I'm not going to work on that. I leave to the Fortran maintainers whether to
track that on a different PR and close this one or leave this one open.
>From gcc-bugs-return-487179-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun May 24 10:03:54 2015
Return-Path: <gcc-bugs-return-487179-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 104466 invoked by alias); 24 May 2015 10:03:53 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 104444 invoked by uid 48); 24 May 2015 10:03:48 -0000
From: "bdeyal at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/66263] Performance regression from gcc-4.8 and up (trivial sudoku program)
Date: Sun, 24 May 2015 10:03:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: bdeyal at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-66263-4-82yYPQfdyu@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66263-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66263-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-05/txt/msg02019.txt.bz2
Content-length: 231
https://gcc.gnu.org/bugzilla/show_bug.cgi?idf263
--- Comment #2 from EyalBD <bdeyal at gmail dot com> ---
Created attachment 35614
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id5614&actioníit
Preprocessed source file
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-05-24 10:02 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-44054-4@http.gcc.gnu.org/bugzilla/>
2014-04-16 19:59 ` [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option manu at gcc dot gnu.org
2014-04-21 15:19 ` [Bug fortran/44054] Handle -Werror, -Werror=, -fdiagnostics-show-option, !GCC$ diagnostic (pragmas) and color manu at gcc dot gnu.org
2014-04-30 23:01 ` manu at gcc dot gnu.org
2014-05-03 8:27 ` burnus at gcc dot gnu.org
2014-05-03 9:47 ` manu at gcc dot gnu.org
2014-08-15 15:11 ` manu at gcc dot gnu.org
2014-10-28 22:17 ` manu at gcc dot gnu.org
2014-11-11 22:51 ` manu at gcc dot gnu.org
2014-11-23 23:48 ` manu at gcc dot gnu.org
2014-12-11 15:14 ` manu at gcc dot gnu.org
2014-12-11 15:38 ` manu at gcc dot gnu.org
2014-12-11 16:31 ` burnus at gcc dot gnu.org
2015-05-16 12:30 ` manu at gcc dot gnu.org
2015-05-24 10:02 ` manu at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).