public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "steven at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/44102] ICE with asm goto + __builtin_unreachable () in C++
Date: Fri, 30 Nov 2012 14:20:00 -0000	[thread overview]
Message-ID: <bug-44102-4-34J1l0kTTy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-44102-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44102

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2012-11-30
                 CC|                            |steven at gcc dot gnu.org
         Resolution|FIXED                       |
     Ever Confirmed|0                           |1

--- Comment #3 from Steven Bosscher <steven at gcc dot gnu.org> 2012-11-30 14:19:29 UTC ---
This fix is wrong.
(http://gcc.gnu.org/viewcvs?view=revision&revision=159495)

There is a check at the start of cleanup_cfg to always set the
CLEANUP_CFGLAYOUT flag whenever we're in cfglayout mode:

120893     steven   /* Set the cfglayout mode flag here.  We could update all
the callers
120893     steven      but that is just inconvenient, especially given that we
eventually
120893     steven      want to have cfglayout mode as the default.  */
120893     steven   if (current_ir_type () == IR_RTL_CFGLAYOUT)
120893     steven     mode |= CLEANUP_CFGLAYOUT;
120893     steven


So this part of your fix:

-          if ((mode & CLEANUP_CFGLAYOUT)
+              if (current_ir_type () == IR_RTL_CFGLAYOUT)

is incorrect.


       reply	other threads:[~2012-11-30 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-44102-4@http.gcc.gnu.org/bugzilla/>
2012-11-30 14:20 ` steven at gcc dot gnu.org [this message]
2024-03-25  4:59 ` pinskia at gcc dot gnu.org
2010-05-12 19:03 [Bug middle-end/44102] New: " jakub at gcc dot gnu dot org
2010-05-17 17:19 ` [Bug middle-end/44102] " jakub at gcc dot gnu dot org
2010-05-17 17:34 ` jakub at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-44102-4-34J1l0kTTy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).