From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 63B173858404; Mon, 25 Mar 2024 04:59:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63B173858404
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1711342798;
	bh=TIIR8URoORd2cXi2XNZISkh0/MJDGiIDmLxDbq17ZVw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=uyMF3Nkonk+EUWV/GisMWOJ+Jsd/G0rvhjFFNd84tYY+Bh6GssPRGnv9PGKreJJE5
	 F0TYsuaO4vnjnSMmAHeZDDNo5UmA//G/L/826b0yi7nDJ76v0LT7XRmMGlPf9W//k+
	 1SeE+t/Xd4vnLsVmOygxPtNOEyhLHLEfEL2pfze0=
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/44102] ICE with asm goto + __builtin_unreachable ()
 in C++
Date: Mon, 25 Mar 2024 04:59:57 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 4.6.0
X-Bugzilla-Keywords: ice-on-valid-code, inline-asm
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: REOPENED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-44102-4-nUsEodrdEw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-44102-4@http.gcc.gnu.org/bugzilla/>
References: <bug-44102-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D44102

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Steven Bosscher from comment #3)
> This fix is wrong.
> (http://gcc.gnu.org/viewcvs?view=3Drevision&revision=3D159495)
>=20
> There is a check at the start of cleanup_cfg to always set the
> CLEANUP_CFGLAYOUT flag whenever we're in cfglayout mode:
>=20
> 120893     steven   /* Set the cfglayout mode flag here.  We could update
> all the callers
> 120893     steven      but that is just inconvenient, especially given th=
at
> we eventually
> 120893     steven      want to have cfglayout mode as the default.  */
> 120893     steven   if (current_ir_type () =3D=3D IR_RTL_CFGLAYOUT)
> 120893     steven     mode |=3D CLEANUP_CFGLAYOUT;
> 120893     steven
>=20
>=20
> So this part of your fix:
>=20
> -		  if ((mode & CLEANUP_CFGLAYOUT)
> +		      if (current_ir_type () =3D=3D IR_RTL_CFGLAYOUT)
>=20
> is incorrect.

So the way I read this is that the fix is not wrong, just it uses the new c=
heck
instead of the old way. Now I am not sure what about the status of always u=
sing
cfglayout because what I remember is that is used all the way until post
reload(RA) now.=