[Bug c++/44128] C++ frontend not warn on type shadowing with -Wshadow

[Bug c++/44128] C++ frontend not warn on type shadowing with -Wshadow

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44128

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|gcc-bugs at gcc dot gnu.org |jason at gcc dot gnu.org,
                   |                            |paolo.carlini at oracle dot
                   |                            |com

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-05 01:25:27 UTC ---
Indeed, the main issue has been fixed a lot of time ago.

Jason, shall we change the second warning to an inform, as suggested by Andrew?

[Bug c++/44128] C++ frontend not warn on type shadowing with -Wshadow

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44128

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0

--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> 2011-11-05 03:44:37 UTC ---
Yes, it was fixed by

2010-07-02  Le-Chun Wu  <lcwu@google.com>

        PR/44128
        * name-lookup.c (pushdecl_maybe_friend): Warn when a local decl
        (variable or type) shadows another type.

Changing the second warning to an inform sounds good.

[Bug c++/44128] New: C++ frontend not warn on type shadowing with -Wshadow

[lcwu at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

This bug is a follow-up to bug c++/44122.

Given the following program:

$ cat t.c

typedef long Py_ssize_t;

void bar() {

 typedef int Py_ssize_t;
 Py_ssize_t pos;
}

When compiled with the C compiler with -Wshadow flag, a shadow warning is
emitted.

$ gcc -c t.c -Wshadow
t.c: In function ‘bar’:
t.c:5:14: warning: declaration of ‘Py_ssize_t’ shadows a global declaration
[-Wshadow]
t.c:1:14: warning: shadowed declaration is here [-Wshadow]

However, when using the C++ compiler with the same flag, no warning is emitted.

$ g++ -c t.c -Wshadow

I think C++ frontend should warn on this case as the C frontend.


-- 
           Summary: C++ frontend not warn on type shadowing with -Wshadow
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: lcwu at gcc dot gnu dot org
 GCC build triplet: x86_64-unknown-linux-gnu
  GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44128

[Bug c++/44128] C++ frontend not warn on type shadowing with -Wshadow

[pinskia at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]



------- Comment #1 from pinskia at gcc dot gnu dot org  2010-07-24 21:28 -------
apinski@apinski-desktop:~/Desktop$ ~/local-gcc/bin/g++ -Wshadow t.c -S
t.c: In function ‘void bar()’:
t.c:5:14: warning: declaration of ‘Py_ssize_t’ shadows a global declaration
[-Wshadow]
t.c:1:14: warning: shadowed declaration is here [-Wshadow]


Hmm, this must have been fixed between May and now, 4.3.2 did not report the
warning either.

Note I think the second warning should really be note.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44128