[Bug fortran/44348] ICE in build_function_decl

[Bug fortran/44348] ICE in build_function_decl

[zeccav at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348

Vittorio Zecca <zeccav at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.5.0                       |4.8.0

--- Comment #5 from Vittorio Zecca <zeccav at gmail dot com> 2013-04-16 08:49:29 UTC ---
I still have the same bug on gfortran 4.8.0.
And a tree check if gfortran built with -fsanitize.

[Bug fortran/44348] ICE in build_function_decl

[zeccav at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348

--- Comment #6 from Vittorio Zecca <zeccav at gmail dot com> ---
Still there in 4.8.2
gfbug5.f: In function ‘ff’:
gfbug5.f:3:0: internal compiler error: in make_decl_rtl, at varasm.c:1140
       subroutine sub(ff)
 ^
0x9fd8c2 make_decl_rtl(tree_node*)
    ../../gcc-4.8.2/gcc/varasm.c:1139
0x5a6ff6 trans_function_start
    ../../gcc-4.8.2/gcc/fortran/trans-decl.c:2293
0x5aee10 gfc_generate_function_code(gfc_namespace*)
    ../../gcc-4.8.2/gcc/fortran/trans-decl.c:5307
0x5af017 gfc_generate_contained_functions
    ../../gcc-4.8.2/gcc/fortran/trans-decl.c:4530
0x5af017 gfc_generate_function_code(gfc_namespace*)
    ../../gcc-4.8.2/gcc/fortran/trans-decl.c:5333
0x552a20 translate_all_program_units
    ../../gcc-4.8.2/gcc/fortran/parse.c:4474
0x552a20 gfc_parse_file()
    ../../gcc-4.8.2/gcc/fortran/parse.c:4688
0x58e195 gfc_be_parse_file
    ../../gcc-4.8.2/gcc/fortran/f95-lang.c:189
>From gcc-bugs-return-432221-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Oct 19 16:54:14 2013
Return-Path: <gcc-bugs-return-432221-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 17757 invoked by alias); 19 Oct 2013 16:54:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 17719 invoked by uid 48); 19 Oct 2013 16:54:11 -0000
From: "zeccav at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/44350] accepts illegal fortran in BLOCK DATA
Date: Sat, 19 Oct 2013 16:54:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords: accepts-invalid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: zeccav at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-44350-4-2Xb9IsjGnN@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-44350-4@http.gcc.gnu.org/bugzilla/>
References: <bug-44350-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg01365.txt.bz2
Content-length: 161

http://gcc.gnu.org/bugzilla/show_bug.cgi?idD350

--- Comment #3 from Vittorio Zecca <zeccav at gmail dot com> ---
I still have the same bug on gfortran 4.8.2

[Bug fortran/44348] ICE in build_function_decl

[bdavis at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348

Bud Davis <bdavis at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdavis at gcc dot gnu.org

--- Comment #7 from Bud Davis <bdavis at gcc dot gnu.org> ---
Current status:

Original report is fixed.

GNU Fortran (GCC) 6.0.0 20150811 (experimental)

[bdavis@linux1 ~/gcc]$ cat a.f
      subroutine sub(ff)
      contains
      subroutine ff
      end subroutine
      end
[bdavis@linux1 ~/gcc]$ ./run/bin/gfortran a.f
a.f:3:72:

Error: internal procedure 'ff' at (1) conflicts with DUMMY argument

>From comment #2, still broken

[bdavis@linux1 ~/gcc]$ cat b.f
       subroutine s
       contains
         SUBROUTINE s  
         END SUBROUTINE
       end subroutine
[bdavis@linux1 ~/gcc]$ ./run/bin/gfortran b.f
b.f:3:0:

          SUBROUTINE s  
1
internal compiler error: in gfc_generate_function_code, at
fortran/trans-decl.c:5781
0x6e7ff0 gfc_generate_function_code(gfc_namespace*)
        ../../current/gcc/fortran/trans-decl.c:5781
0x6e5f37 gfc_generate_contained_functions
        ../../current/gcc/fortran/trans-decl.c:5038
0x6e5f37 gfc_generate_function_code(gfc_namespace*)
        ../../current/gcc/fortran/trans-decl.c:5824
0x673490 translate_all_program_units
        ../../current/gcc/fortran/parse.c:5521
0x673490 gfc_parse_file()
        ../../current/gcc/fortran/parse.c:5726
0x6b4d22 gfc_be_parse_file
        ../../current/gcc/fortran/f95-lang.c:209
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug fortran/44348] ICE in build_function_decl

[zeccav at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348

--- Comment #9 from Vittorio Zecca <zeccav at gmail dot com> ---
No, it is not valid, but gfortran should signal this with an error message.
Not with a crash.

[Bug fortran/44348] New: ICE in build_function_decl

[zeccav at gmail dot com]

The following provokes the summary:

      subroutine sub(ff)
      contains
      subroutine ff
      end subroutine
      end

Best regards
Vittorio Zecca


-- 
           Summary: ICE in build_function_decl
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: zeccav at gmail dot com
  GCC host triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348

[Bug fortran/44348] ICE in build_function_decl

[pault at gcc dot gnu dot org]

------- Comment #1 from pault at gcc dot gnu dot org  2010-06-01 05:02 -------
This is rather easily fixed, I suspect:

if (sym->attr.dummy && sym->attr.if_source == IFSRC_DECL)
  {
    ...error...
  }

in resolve.c should do the job.  Just have to find the right place!

Confirmed

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |ice-on-invalid-code
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-01 05:02:32
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348

[Bug fortran/44348] ICE in build_function_decl

[dfranke at gcc dot gnu dot org]

------- Comment #2 from dfranke at gcc dot gnu dot org  2010-06-10 19:09 -------
The same ICE is triggered by 

subroutine s
contains
  SUBROUTINE s  
  END SUBROUTINE
end subroutine


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348

[Bug fortran/44348] ICE in build_function_decl

[dfranke at gcc dot gnu dot org]

------- Comment #3 from dfranke at gcc dot gnu dot org  2010-06-12 14:43 -------
This goes off at a tangent, but still related to this PR ...

I think this is valid as the RESULT f is in the scope of g only and shadows the
FUNCTION f (Lahey accepts it):

FUNCTION f()
contains
  FUNCTION g() RESULT(f)
  END FUNCTION
END FUNCTION


But what's going on here?
FUNCTION f() RESULT(g)
contains
  FUNCTION g()
  END FUNCTION
END FUNCTION

$ gfortran-svn pr44348.f90 
pr44348.f90: In function 'f':
pr44348.f90:4:0: error: aggregate value used where a float was expected

Lahey says:
1723-S: "SOURCE.F90", line 3, column 12: 'g' already used as a variable name.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348

[Bug fortran/44348] ICE in build_function_decl

[dfranke at gcc dot gnu dot org]

------- Comment #4 from dfranke at gcc dot gnu dot org  2010-06-12 17:47 -------
The patch below fixes the ICE in comment #2, but not the original report.

However, it also message-regresses on
FAIL: gfortran.dg/derived_function_interface_1.f90  -O   (test for errors, line
41)
FAIL: gfortran.dg/derived_function_interface_1.f90  -O   (test for errors, line
42)
FAIL: gfortran.dg/global_references_1.f90  -O  (test for excess errors)


Index: decl.c
===================================================================
--- decl.c      (revision 160638)
+++ decl.c      (working copy)
@@ -863,7 +863,6 @@ get_proc_name (const char *name, gfc_sym
         this is handled using gsymbols to register unique,globally
         accessible names.  */
       if (sym->attr.flavor != 0
-         && sym->attr.proc != 0
          && (sym->attr.subroutine || sym->attr.function)
          && sym->attr.if_source != IFSRC_UNKNOWN)
        gfc_error_now ("Procedure '%s' at %C is already defined at %L",


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44348