[Bug fortran/44359] New: -Wall / -Wconversion: Too verbose warning for DATA BOZ conversions

[Bug fortran/44359] New: -Wall / -Wconversion: Too verbose warning for DATA BOZ conversions

[burnus at gcc dot gnu dot org]

As reported at http://gcc.gnu.org/ml/fortran/2010-05/msg00320.html

For the following program, one gets the warning:
  DATA  a  /  Z'F'  /,  b  /  Z'3'  /
                                  1
Warning: Conversion from INTEGER(16) to INTEGER(4) at (1)


While this is formally correct, the warning is a bit verbose. The warning
itself is not new (-Wconversion) but it is new for -Wall. (Since GCC 4.6, -Wall
implies a less-noisy -Wconversion while -Wconversion-extra is still noisy.)

Expected: Only warn if an overflow occurs.

PROGRAM  test_iand
  INTEGER  ::  a,  b
  DATA  a  /  Z'F'  /,  b  /  Z'3'  /
  WRITE  (*,*)  IAND(a,  b)
END PROGRAM test_iand


-- 
           Summary: -Wall / -Wconversion: Too verbose warning for DATA BOZ
                    conversions
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44359

[Bug fortran/44359] -Wall / -Wconversion: Too verbose warning for DATA BOZ conversions

[dfranke at gcc dot gnu dot org]

------- Comment #1 from dfranke at gcc dot gnu dot org  2010-06-01 19:50 -------
Haven't checked with the testcase from this PR, but it should be handled by:
    http://gcc.gnu.org/ml/fortran/2010-05/msg00229.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44359

[Bug fortran/44359] -Wall / -Wconversion: Too verbose warning for DATA BOZ conversions

[dfranke at gcc dot gnu dot org]

------- Comment #2 from dfranke at gcc dot gnu dot org  2010-06-01 20:43 -------
(In reply to comment #1)
>     http://gcc.gnu.org/ml/fortran/2010-05/msg00229.html

With this patch:

$> gfortran-svn -Wall pr44359.f90
[no warning]

$> gfortran-svn -Wall -fno-range-check pr44359.f90
pr44359.f90:3.34:

  DATA  a  /  Z'F'  /,  b  /  Z'3'  /
                                  1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4)
at (1)
pr44359.f90:3.18:

  DATA  a  /  Z'F'  /,  b  /  Z'3'  /
                  1
Warning: Possible change of value in conversion from INTEGER(8) to INTEGER(4)
at (1)


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-01 20:43:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44359

[Bug fortran/44359] -Wall / -Wconversion: Too verbose warning for DATA BOZ conversions

[dfranke at gcc dot gnu dot org]

------- Comment #3 from dfranke at gcc dot gnu dot org  2010-06-09 19:41 -------
Subject: Bug 44359

Author: dfranke
Date: Wed Jun  9 19:40:58 2010
New Revision: 160505

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=160505
Log:
gcc/fortran/:
2010-06-09  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/44359
        * intrinsic.c (gfc_convert_type_warn): Further improve -Wconversion.

gcc/testsuite/:
2010-06-09  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/44359
        * gfortran.dg/warn_conversion.f90: Removed check for redundant
        warning.
        * gfortran.dg/warn_conversion_2.f90: Use non-constant expression to
        check for warning.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/intrinsic.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/warn_conversion.f90
    trunk/gcc/testsuite/gfortran.dg/warn_conversion_2.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44359

[Bug fortran/44359] -Wall / -Wconversion: Too verbose warning for DATA BOZ conversions

[dfranke at gcc dot gnu dot org]

------- Comment #4 from dfranke at gcc dot gnu dot org  2010-06-09 19:42 -------
Fixed in trunk. Closing.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44359