public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "carrot at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/44374]  New: Hoist same instructions in different branches
Date: Wed, 02 Jun 2010 08:20:00 -0000	[thread overview]
Message-ID: <bug-44374-17659@http.gcc.gnu.org/bugzilla/> (raw)

Compile the attached test case with options -march=armv7-a -mthumb -Os, 
this code snippet 

  if (native)
    dlmalloc_walk_heap(heap_chunk_callback, (void *)&ctx);
  else
    dvmHeapSourceWalk(heap_chunk_callback, (void *)&ctx);

is compiled to:

        cbz     r5, .L2
        ldr     r0, .L4            // A
        mov     r1, sp             // B
        bl      dlmalloc_walk_heap
        b       .L1
.L2:
        ldr     r0, .L4            // C
        mov     r1, sp             // D
        bl      dvmHeapSourceWalk
.L1:
        add     sp, sp, #44
        pop     {r4, r5, pc}
.L5:
        .align  2
.L4:
        .word   heap_chunk_callback

Note that instructions AB are equal to instructions CD, if we move the previous
conditional branch after B, then CD can be removed.

Option -O2 and target arm have the same problem.

Which pass should do this optimization? pass_rtl_hoist?


-- 
           Summary: Hoist same instructions in different branches
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: carrot at google dot com
 GCC build triplet: i686-linux
  GCC host triplet: i686-linux
GCC target triplet: arm-eabi


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44374


             reply	other threads:[~2010-06-02  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02  8:20 carrot at google dot com [this message]
2010-06-02  8:21 ` [Bug rtl-optimization/44374] " carrot at google dot com
2010-06-02  8:54 ` steven at gcc dot gnu dot org
2010-09-23 10:05 ` bernds at gcc dot gnu dot org
2010-09-23 10:08 ` bernds at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-44374-17659@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).