[Bug debug/44375] New: goto_locus lost at -O0 during cfg cleanup

[Bug debug/44375] New: goto_locus lost at -O0 during cfg cleanup

[jakub at gcc dot gnu dot org]

As mentioned in
http://gcc.gnu.org/ml/gcc-patches/2010-06/msg00115.html
for -O0 we sometimes, e.g. for return without value or for C++ NRV optimized
return don't emit any insns with the location of the return stmt, which results
in worse debug experience.


-- 
           Summary: goto_locus lost at -O0 during cfg cleanup
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jakub at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375

[Bug debug/44375] goto_locus lost at -O0 during cfg cleanup

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2010-06-02 10:36 -------
Created an attachment (id=20806)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20806&action=view)
gcc46-pr44375.patch

One possible fix.  Another is to insert GIMPLE_NOP with the location and handle
it during expansion (for -O0 of course).


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375

[Bug debug/44375] goto_locus lost at -O0 during cfg cleanup

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2010-06-02 11:33 -------
Created an attachment (id=20808)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20808&action=view)
gcc46-pr44375.patch

Alternative patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375

Re: [Bug debug/44375] New: goto_locus lost at -O0 during cfg cleanup

[Andrew Pinski]

I think this is a dup of a much older bug.

Sent from my iPhone

On Jun 2, 2010, at 3:30 AM, "jakub at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org 
 > wrote:

> As mentioned in
> http://gcc.gnu.org/ml/gcc-patches/2010-06/msg00115.html
> for -O0 we sometimes, e.g. for return without value or for C++ NRV  
> optimized
> return don't emit any insns with the location of the return stmt,  
> which results
> in worse debug experience.
>
>
> -- 
>           Summary: goto_locus lost at -O0 during cfg cleanup
>           Product: gcc
>           Version: 4.6.0
>            Status: UNCONFIRMED
>          Severity: normal
>          Priority: P3
>         Component: debug
>        AssignedTo: unassigned at gcc dot gnu dot org
>        ReportedBy: jakub at gcc dot gnu dot org
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375
>

[Bug debug/44375] goto_locus lost at -O0 during cfg cleanup

[pinskia at gmail dot com]

------- Comment #3 from pinskia at gmail dot com  2010-06-02 13:33 -------
Subject: Re:   New: goto_locus lost at -O0 during cfg cleanup

I think this is a dup of a much older bug.

Sent from my iPhone

On Jun 2, 2010, at 3:30 AM, "jakub at gcc dot gnu dot org"
<gcc-bugzilla@gcc.gnu.org 
 > wrote:

> As mentioned in
> http://gcc.gnu.org/ml/gcc-patches/2010-06/msg00115.html
> for -O0 we sometimes, e.g. for return without value or for C++ NRV  
> optimized
> return don't emit any insns with the location of the return stmt,  
> which results
> in worse debug experience.
>
>
> -- 
>           Summary: goto_locus lost at -O0 during cfg cleanup
>           Product: gcc
>           Version: 4.6.0
>            Status: UNCONFIRMED
>          Severity: normal
>          Priority: P3
>         Component: debug
>        AssignedTo: unassigned at gcc dot gnu dot org
>        ReportedBy: jakub at gcc dot gnu dot org
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375
>


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375

[Bug debug/44375] goto_locus lost at -O0 during cfg cleanup

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2010-06-02 15:29 -------
I think this is related to PR 12076.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375

[Bug debug/44375] goto_locus lost at -O0 during cfg cleanup

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2010-06-03 12:07 -------
Subject: Bug 44375

Author: jakub
Date: Thu Jun  3 12:07:18 2010
New Revision: 160219

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=160219
Log:
        PR debug/44375
        * tree-cfg.c (gimple_can_merge_blocks_p): For -O0
        return false if merging the bbs would lead to goto_locus
        location being lost from the IL.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-cfg.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375

[Bug debug/44375] goto_locus lost at -O0 during cfg cleanup

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2010-07-27 08:58 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44375