[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|gcc-bugs at gcc dot         |
                   |gnu.org, jason at gcc dot   |
                   |gnu.org, paolo.carlini at   |
                   |oracle dot com              |

--- Comment #10 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-09-28 22:11:33 UTC ---
Gosh, I thought this had been fixed! Any news?

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[janis at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

--- Comment #11 from Janis Johnson <janis at gcc dot gnu.org> 2011-09-28 23:04:13 UTC ---
There's a patch here:

  http://gcc.gnu.org/ml/gcc-patches/2010-12/msg00625.html

approved here:

   http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01208.html

Apparently I never checked it in.  I'll test it and ask on gcc-patches if I can
check it in now.

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

--- Comment #12 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-09-28 23:08:13 UTC ---
Great. Make sure to add Jason in CC for faster feedback.

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

--- Comment #13 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-09-30 09:44:50 UTC ---
By the way, the patch is approved thus we don't need further feedback to commi
it and fix this annoying issue. I'll just do it later today, if nobody beats
me!

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[janis at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

--- Comment #14 from Janis Johnson <janis at gcc dot gnu.org> 2011-09-30 17:33:48 UTC ---
Author: janis
Date: Fri Sep 30 17:33:41 2011
New Revision: 179399

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=179399
Log:
gcc/cp
    PR c++/44473
    * mangle.c (write_type): Handle CV qualifiers for decimal classes.
gcc/testsuite
    PR c++/44473
    * g++.dg/dfp/44473-1.C: New test.
    * g++.dg/dfp/44473-2.C: New test.
    * g++.dg/dfp/mangle-1.C: New test.
    * g++.dg/dfp/mangle-2.C: New test.
    * g++.dg/dfp/mangle-3.C: New test.
    * g++.dg/dfp/mangle-4.C: New test.
    * g++.dg/dfp/mangle-5.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/dfp/44473-1.C
    trunk/gcc/testsuite/g++.dg/dfp/44473-2.C
    trunk/gcc/testsuite/g++.dg/dfp/mangle-1.C
    trunk/gcc/testsuite/g++.dg/dfp/mangle-2.C
    trunk/gcc/testsuite/g++.dg/dfp/mangle-3.C
    trunk/gcc/testsuite/g++.dg/dfp/mangle-4.C
    trunk/gcc/testsuite/g++.dg/dfp/mangle-5.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/mangle.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #15 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-09-30 20:12:53 UTC ---
Confirmed fixed. Thanks!

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

--- Comment #16 from Peter Bergner <bergner at gcc dot gnu.org> 2011-10-11 16:59:09 UTC ---
Author: bergner
Date: Tue Oct 11 16:58:59 2011
New Revision: 179808

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=179808
Log:
gcc/
    PR c++/44473
    * mangle.c (write_type): Handle CV qualifiers for decimal classes.

gcc/testsuite/
    PR c++/44473
    * g++.dg/dfp/44473-1.C: New test.
    * g++.dg/dfp/44473-2.C: New test.
    * g++.dg/dfp/mangle-1.C: New test.
    * g++.dg/dfp/mangle-2.C: New test.
    * g++.dg/dfp/mangle-3.C: New test.
    * g++.dg/dfp/mangle-4.C: New test.
    * g++.dg/dfp/mangle-5.C: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/44473-1.C
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/44473-2.C
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-1.C
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-2.C
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-3.C
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-4.C
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-5.C
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/cp/mangle.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

--- Comment #17 from Peter Bergner <bergner at gcc dot gnu.org> 2011-10-11 17:02:51 UTC ---
Author: bergner
Date: Tue Oct 11 17:02:42 2011
New Revision: 179809

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=179809
Log:
gcc/
    PR c++/44473
    * mangle.c (write_type): Handle CV qualifiers for decimal classes.

gcc/testsuite/
    PR c++/44473
    * g++.dg/dfp/44473-1.C: New test.
    * g++.dg/dfp/44473-2.C: New test.
    * g++.dg/dfp/mangle-1.C: New test.
    * g++.dg/dfp/mangle-2.C: New test.
    * g++.dg/dfp/mangle-3.C: New test.
    * g++.dg/dfp/mangle-4.C: New test.
    * g++.dg/dfp/mangle-5.C: New test.

Added:
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/44473-1.C
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/44473-2.C
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-1.C
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-2.C
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-3.C
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-4.C
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-5.C
Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/cp/mangle.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

--- Comment #18 from Peter Bergner <bergner at gcc dot gnu.org> 2011-10-11 17:17:49 UTC ---
Author: bergner
Date: Tue Oct 11 17:17:43 2011
New Revision: 179810

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=179810
Log:
gcc/
    PR c++/44473
    * mangle.c (write_type): Handle CV qualifiers for decimal classes.

gcc/testsuite/
    PR c++/44473
    * g++.dg/dfp/44473-1.C: New test.
    * g++.dg/dfp/44473-2.C: New test.
    * g++.dg/dfp/mangle-1.C: New test.
    * g++.dg/dfp/mangle-2.C: New test.
    * g++.dg/dfp/mangle-3.C: New test.
    * g++.dg/dfp/mangle-4.C: New test.
    * g++.dg/dfp/mangle-5.C: New test.

Added:
    branches/ibm/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/44473-1.C
    branches/ibm/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/44473-2.C
    branches/ibm/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-1.C
    branches/ibm/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-2.C
    branches/ibm/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-3.C
    branches/ibm/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-4.C
    branches/ibm/gcc-4_5-branch/gcc/testsuite/g++.dg/dfp/mangle-5.C
Modified:
    branches/ibm/gcc-4_5-branch/gcc/ChangeLog.ibm
    branches/ibm/gcc-4_5-branch/gcc/cp/mangle.c
    branches/ibm/gcc-4_5-branch/gcc/testsuite/ChangeLog.ibm

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

--- Comment #19 from Peter Bergner <bergner at gcc dot gnu.org> 2011-10-11 17:24:39 UTC ---
Author: bergner
Date: Tue Oct 11 17:24:27 2011
New Revision: 179811

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=179811
Log:
gcc/
    PR c++/44473
    * mangle.c (write_type): Handle CV qualifiers for decimal classes.

gcc/testsuite/
    PR c++/44473
    * g++.dg/dfp/44473-1.C: New test.
    * g++.dg/dfp/44473-2.C: New test.
    * g++.dg/dfp/mangle-1.C: New test.
    * g++.dg/dfp/mangle-2.C: New test.
    * g++.dg/dfp/mangle-3.C: New test.
    * g++.dg/dfp/mangle-4.C: New test.
    * g++.dg/dfp/mangle-5.C: New test.

Added:
    branches/ibm/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/44473-1.C
    branches/ibm/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/44473-2.C
    branches/ibm/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-1.C
    branches/ibm/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-2.C
    branches/ibm/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-3.C
    branches/ibm/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-4.C
    branches/ibm/gcc-4_6-branch/gcc/testsuite/g++.dg/dfp/mangle-5.C
Modified:
    branches/ibm/gcc-4_6-branch/gcc/ChangeLog.ibm
    branches/ibm/gcc-4_6-branch/gcc/cp/mangle.c
    branches/ibm/gcc-4_6-branch/gcc/testsuite/ChangeLog.ibm

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |db4 at mm dot st

--- Comment #20 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-14 16:21:08 UTC ---
*** Bug 51121 has been marked as a duplicate of this bug. ***

[Bug c++/44473] New: iterators already defined for std::vector when using std::decimal

[rmlong at gmail dot com]

If checking empty then attempting to push back the following errors are
reported:
main.s: Assembler messages:
main.s:2236: Error: symbol
`_ZNK9__gnu_cxx17__normal_iteratorIPDfSt6vectorIDfSaIDfEEE4baseEv' is already
defined
main.s:2542: Error: symbol
`_ZN9__gnu_cxx17__normal_iteratorIPDfSt6vectorIDfSaIDfEEEC2ERKS1_' is already
defined

Preprocessed file: http://dl.dropbox.com/u/2280/main.ii
Example code:
#include <decimal/decimal>
#include <vector>

int main()
{
    std::vector<std::decimal::decimal32> vec;

    if (vec.empty())
    {
        vec.push_back(std::decimal::decimal32(0));
    }

    return 0;
}


-- 
           Summary: iterators already defined for std::vector when using
                    std::decimal
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rmlong at gmail dot com
 GCC build triplet: --with-gmp=/devsandbox/cxp/ext/compiler/gmp/ --with-
                    mpc=/devsand
  GCC host triplet: RHEL5.5
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[rmlong at gmail dot com]

------- Comment #1 from rmlong at gmail dot com  2010-06-09 03:15 -------
Created an attachment (id=20871)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20871&action=view)
Preprocessed file


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[rmlong at gmail dot com]

------- Comment #2 from rmlong at gmail dot com  2010-06-09 03:17 -------
Created an attachment (id=20872)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20872&action=view)
Example code


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo dot carlini at oracle dot com]

------- Comment #3 from paolo dot carlini at oracle dot com  2010-06-09 08:27 -------
Janis, this doesn't make sense to me, and for sure happens only with decimal.
Can you have a look?


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janis187 at us dot ibm dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[redi at gcc dot gnu dot org]

------- Comment #4 from redi at gcc dot gnu dot org  2010-06-09 10:22 -------
(From update of attachment 20871)
attachment's mimetype changed to text/plain


-- 

redi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20871|application/octet-stream    |text/plain
          mime type|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[joseph at codesourcery dot com]

------- Comment #5 from joseph at codesourcery dot com  2010-06-09 20:14 -------
Subject: Re:  iterators already defined for std::vector when
 using std::decimal

On Wed, 9 Jun 2010, paolo dot carlini at oracle dot com wrote:

> Janis, this doesn't make sense to me, and for sure happens only with decimal.
> Can you have a look?
> 
> 
> -- 
> 
> paolo dot carlini at oracle dot com changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |janis187 at us dot ibm dot
>                    |                            |com

Janis is no longer at IBM....

http://gcc.gnu.org/ml/gcc-patches/2010-03/msg01516.html

(her assignment has now come through, according to copyright.list)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo dot carlini at oracle dot com]

------- Comment #6 from paolo dot carlini at oracle dot com  2010-06-09 21:48 -------
Oops, thanks Joseph.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|janis187 at us dot ibm dot  |
                   |com                         |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo dot carlini at oracle dot com]

-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-09 22:02:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[janis at gcc dot gnu dot org]

------- Comment #7 from janis at gcc dot gnu dot org  2010-06-10 21:58 -------
The new decimal* classes are sometimes treated as classes, sometimes as
scalars.  From a first look, something might be going wrong with the use of
__are_same in bits/std_iterator.h so that it needs special casing for these odd
classes.  I'll continue digging slowly, but don't let that stop anyone else
from jumping in here.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo dot carlini at oracle dot com]

------- Comment #8 from paolo dot carlini at oracle dot com  2010-06-10 23:23 -------
Thanks Janis. I think that Jason reviewed your C++ contributions regarding
decimal floating point, thus, once more, I'm adding him in CC hoping for help
on this issue.

In a nutshell, it seems that something is going wrong when templates - in this
specific case, __gnu_cxx::__normal_iterator - are instantiated for
std::decimal: we end up with multiple definitions of member functions - in this
case, the constructor from pointer and base() - in the assembly generated by
GCC.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473

[Bug c++/44473] iterators already defined for std::vector when using std::decimal

[paolo dot carlini at oracle dot com]

------- Comment #9 from paolo dot carlini at oracle dot com  2010-08-29 17:32 -------
Jason, any hint about the best way to attack this?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44473