[Bug c/44515] New: improve message for missing ";"

[Bug c/44515] New: improve message for missing ";"

[manu at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

Testcase:
void bar(void);
void foo(void)
{
  bar()


}

gcc-4.6:

clang-3.c:7:1: error: expected ‘;’ before ‘}’ token

clang:

t.c:4:8: error: expected ';' after expression
    bar()
         ^
         ;


-- 
           Summary: improve message for missing ";"
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44515

[Bug c/44515] improve message for missing ";"

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2010-06-13 17:25 -------
Actually before is more correct than saying after bar().  Because expressions
don't need to end on the same line.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44515

[Bug c/44515] improve message for missing ";"

[manu at gcc dot gnu dot org]

------- Comment #2 from manu at gcc dot gnu dot org  2010-06-13 17:33 -------
(In reply to comment #1)
> Actually before is more correct than saying after bar().  Because expressions
> don't need to end on the same line.

I wonder why people tend to write:

bar();

rather than 

;}

Obviously the second is more correct. ;-)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44515

[Bug c/44515] improve message for missing ";"

[joseph at codesourcery dot com]

------- Comment #3 from joseph at codesourcery dot com  2010-06-13 18:25 -------
Subject: Re:  improve message for missing ";"

Perhaps "between expression and '}' token" would be more precise.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44515

[Bug c/44515] improve message for missing ";"

[manu at gcc dot gnu dot org]

------- Comment #4 from manu at gcc dot gnu dot org  2010-06-13 19:33 -------
Perhaps, but the location should be at the end of the expression, where most
programmers would put the ';'. Then, mentioning '}', which may be in a totally
different line with a lot comments in between, would be confusing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44515