[Bug c++/44641] New: Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[Bug c++/44641] New: Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gmail dot com]

$ cat test.ii
# 1 "bad.h" 1
template <class A> struct MisplacedDbg;
# 1 "good.cc"
struct Arg;
typedef MisplacedDbg<Arg> Typedef;
template<typename T> struct Base  {
  virtual ~Base() {
  }
};
template <class A> struct MisplacedDbg : public Base<int> {
};
static MisplacedDbg<Arg> static_var;
$ g++-4.6svn -c -g test.ii
$ objdump -d -l test.o|grep -B2 'bad.h:1'
0000000000000000 <_ZN12MisplacedDbgI3ArgEC1Ev>:
MisplacedDbg():
/home/jyasskin/tmp/bad.h:1
--
0000000000000000 <_ZN12MisplacedDbgI3ArgED1Ev>:
~MisplacedDbg():
/home/jyasskin/tmp/bad.h:1
$

This causes problems for Gold's ODR violation detector.


-- 
           Summary: Generated constructors and destructors get wrong debug
                    location when a typedef uses a forward declaration of
                    the type before the definition
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jyasskin at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gmail dot com]

------- Comment #1 from jyasskin at gmail dot com  2010-07-15 00:34 -------
My current guess is that the bug is at parser.c:16741, at the end of
cp_parser_class_head():
    DECL_SOURCE_LOCATION (TYPE_NAME (type)) = type_start_token->location;

This updates the template's location, but it doesn't update the locations of
any instantiations that have already been created. I'm going to try to find the
existing instantiations to update them there.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gmail dot com]

------- Comment #2 from jyasskin at gmail dot com  2010-07-20 00:43 -------
Patch at http://gcc.gnu.org/ml/gcc-patches/2010-07/msg01538.html. Please
review.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gcc dot gnu dot org]

------- Comment #3 from jyasskin at gcc dot gnu dot org  2010-07-20 20:17 -------
Subject: Bug 44641

Author: jyasskin
Date: Tue Jul 20 20:16:53 2010
New Revision: 162349

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162349
Log:
PR c++/44641
        * gcc/cp/pt.c (instantiate_class_template): Propagate the
        template's location to its instance.

        * gcc/testsuite/lib/scanasm.exp (dg-function-on-line): Test
        that a function is defined on the current line.
        * gcc/testsuite/g++.dg/debug/dwarf2/lineno-simple1.C: New.
        Line number sanity test.
        * gcc/testsuite/g++.dg/debug/dwarf2/pr44641.C: New.



Added:
    trunk/gcc/testsuite/g++.dg/debug/dwarf2/lineno-simple1.C
    trunk/gcc/testsuite/g++.dg/debug/dwarf2/pr44641.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/pt.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/lib/scanasm.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gcc dot gnu dot org]

------- Comment #4 from jyasskin at gcc dot gnu dot org  2010-07-20 20:22 -------
Fixed by r162349.


-- 

jyasskin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[hjl dot tools at gmail dot com]

------- Comment #5 from hjl dot tools at gmail dot com  2010-07-21 13:30 -------
Those tests failed on Linux/ia64:

FAIL: g++.dg/debug/dwarf2/lineno-simple1.C scan-assembler
_ZN1C3fooEv:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:6\\n
FAIL: g++.dg/debug/dwarf2/lineno-simple1.C scan-assembler
_ZN1CC[12]Ev:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:4\\n
FAIL: g++.dg/debug/dwarf2/lineno-simple1.C scan-assembler
main:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:12\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgI3ArgEC[12]Ev:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:34\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgI3ArgED0Ev:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:34\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgI4FullEC[12]Ev:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:21\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgI4FullED0Ev:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:21\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgIP3ArgEC[12]Ev:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:28\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgIP3ArgED0Ev:[^\\t]*(\\t.file[^\\t]*)?\\t# \\S*:28\\n


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gcc dot gnu dot org]

------- Comment #6 from jyasskin at gcc dot gnu dot org  2010-07-21 16:44 -------
Is the problem a bad mangling or bad line numbers? In a built tree, could you
run:
  $objdir/gcc/cc1plus -g -dA
$srcdir/gcc/testsuite/g++.dg/debug/dwarf2/pr44641.C -o pr44641.s
and send me or attach pr44641.s?

Feel free to xfail this in the mean time, or if you send me your triple I'll do
it, so that it's not polluting your test results.


-- 

jyasskin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl dot tools at gmail dot
                   |                            |com
         AssignedTo|unassigned at gcc dot gnu   |jyasskin at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-07-21 16:44:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[hjl dot tools at gmail dot com]

------- Comment #7 from hjl dot tools at gmail dot com  2010-07-21 16:50 -------
(In reply to comment #6)
> Is the problem a bad mangling or bad line numbers? In a built tree, could you
> run:
>   $objdir/gcc/cc1plus -g -dA
> $srcdir/gcc/testsuite/g++.dg/debug/dwarf2/pr44641.C -o pr44641.s
> and send me or attach pr44641.s?
> 
> Feel free to xfail this in the mean time, or if you send me your triple I'll do
> it, so that it's not polluting your test results.
> 

You can build a cross compiler for ia64-unknown-linux-gnu
to see it for yourself.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gcc dot gnu dot org]

------- Comment #8 from jyasskin at gcc dot gnu dot org  2010-07-21 18:42 -------
Despite your remarkably rude response, I've mailed a fix:
http://gcc.gnu.org/ml/gcc-patches/2010-07/msg01665.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gcc dot gnu dot org]

------- Comment #9 from jyasskin at gcc dot gnu dot org  2010-07-21 18:47 -------
Subject: Bug 44641

Author: jyasskin
Date: Wed Jul 21 18:46:40 2010
New Revision: 162383

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162383
Log:
IA64 uses // instead of # for comments in its assembly file.

        PR c++/44641
        * lib/scanasm.exp (dg-function-on-line): Fix regex for IA64's
        comments.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/lib/scanasm.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[jyasskin at gcc dot gnu dot org]

------- Comment #10 from jyasskin at gcc dot gnu dot org  2010-07-21 18:48 -------
Fixed by r162383.


-- 

jyasskin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[manu at gcc dot gnu dot org]

------- Comment #11 from manu at gcc dot gnu dot org  2010-07-21 19:40 -------
(In reply to comment #8)
> Despite your remarkably rude response, I've mailed a fix:
> http://gcc.gnu.org/ml/gcc-patches/2010-07/msg01665.html

Don't take it personally. Some of us are not native English-speakers, so we
miss some nuances of English languages. On the other hand, others often use a
matter-of-fact tone that is unintentionally rude. Finally, there is for sure
rude people around. Since it is hard to differentiate between these three cases
without starting an argument, just ignore it altogether.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[ubizjak at gmail dot com]

------- Comment #12 from ubizjak at gmail dot com  2010-07-27 09:05 -------
Created an attachment (id=21324)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21324&action=view)
alpha asm dump

This test still fails on alpha with attached asm dump.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[ubizjak at gmail dot com]

------- Comment #13 from ubizjak at gmail dot com  2010-07-28 06:24 -------
Reopened.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[ubizjak at gmail dot com]

------- Comment #14 from ubizjak at gmail dot com  2010-08-04 14:04 -------
Following patch fixes my failures:

Index: lib/scanasm.exp
===================================================================
--- lib/scanasm.exp     (revision 162854)
+++ lib/scanasm.exp     (working copy)
@@ -316,7 +316,7 @@
        }
     }

-    set pattern [format {%s:[^\t]*(\t.file[^\t]*)?\t[^:]+:%d\n} \
+    set pattern [format {%s:[^\t]*(\t.(frame|mask|file)[^\t]*)*\t[^:]+:%d\n} \
                  $symbol $line]

     # The lack of spaces around $pattern is important, since they'd


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[uros at gcc dot gnu dot org]

------- Comment #15 from uros at gcc dot gnu dot org  2010-08-04 14:19 -------
Subject: Bug 44641

Author: uros
Date: Wed Aug  4 14:19:01 2010
New Revision: 162866

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162866
Log:
        PR c++/44641
        * lib/scanasm.exp (dg-function-on-line): Expand regex to also ignore
        .frame and .mask assembler directives.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/lib/scanasm.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[ubizjak at gmail dot com]

------- Comment #16 from ubizjak at gmail dot com  2010-08-04 14:28 -------
Fixed (for alpha) by extending regexp in dg-function-on-line procedure.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[danglin at gcc dot gnu dot org]

------- Comment #17 from danglin at gcc dot gnu dot org  2010-08-09 00:19 -------
The match string doesn't work on hppa-linux:

FAIL: g++.dg/debug/dwarf2/lineno-simple1.C scan-assembler
_ZN1CC[12]Ev:[^\\t]*(\
\t.(frame|mask|file)[^\\t]*)*\\t[^:]+:4\\n
FAIL: g++.dg/debug/dwarf2/lineno-simple1.C scan-assembler
_ZN1C3fooEv:[^\\t]*(\\
t.(frame|mask|file)[^\\t]*)*\\t[^:]+:6\\nFAIL:
g++.dg/debug/dwarf2/lineno-simple1.C scan-assembler main:[^\\t]*(\\t.(fram
e|mask|file)[^\\t]*)*\\t[^:]+:12\\n
FAIL: g++.dg/debug/dwarf2/nested-2.C scan-assembler
[^\n\r]*\\(DIE[^\n\r]*DW_TAG
_structure_type\\)[\n\r]+[^\n\r]*"S\\\\0"[ \t]+(#|//)[
\t]+DW_AT_name[\n\r]+(.*)
?\\(DIE[^\n\r]*DW_TAG_structure_type\\)[\n\r]+[^\n\r]*"T<int>\\\\0"[
\t]+(.*)?\\
(DIE[^\n\r]*DW_TAG_template_type_param\\)[\n\r]+[^\n\r]*[\n\r]+[^\n\r]*[\n\r]+[^
\n\r]*(#|//)[ \t]+end of children of DIE[^\n\r]*[\n\r]+[^\n\r]*end of children
o
f DIE[^\n\r]*
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgI4FullEC[12]
Ev:[^\\t]*(\\t.(frame|mask|file)[^\\t]*)*\\t[^:]+:21\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgI4FullED0Ev:
[^\\t]*(\\t.(frame|mask|file)[^\\t]*)*\\t[^:]+:21\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgIP3ArgEC[12]
Ev:[^\\t]*(\\t.(frame|mask|file)[^\\t]*)*\\t[^:]+:28\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgIP3ArgED0Ev:
[^\\t]*(\\t.(frame|mask|file)[^\\t]*)*\\t[^:]+:28\\nFAIL:
g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgI3ArgEC[12]Ev:[^\\t]*(\\t.(frame|mask|file)[^\\t]*)*\\t[^:]+:34\\n
FAIL: g++.dg/debug/dwarf2/pr44641.C scan-assembler
_ZN12MisplacedDbgI3ArgED0Ev:[^\\t]*(\\t.(frame|mask|file)[^\\t]*)*\\t[^:]+:34\\n


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #18 from dave at hiauly1 dot hia dot nrc dot ca  2010-08-09 00:35 -------
Subject: Re:  Generated constructors and destructors get
        wrong debug location when a typedef uses a forward declaration of
        the type before the definition

On Mon, 09 Aug 2010, danglin at gcc dot gnu dot org wrote:

> FAIL: g++.dg/debug/dwarf2/nested-2.C scan-assembler
> [^\n\r]*\\(DIE[^\n\r]*DW_TAG
> _structure_type\\)[\n\r]+[^\n\r]*"S\\\\0"[ \t]+(#|//)[
> \t]+DW_AT_name[\n\r]+(.*)
> ?\\(DIE[^\n\r]*DW_TAG_structure_type\\)[\n\r]+[^\n\r]*"T<int>\\\\0"[
> \t]+(.*)?\\
> (DIE[^\n\r]*DW_TAG_template_type_param\\)[\n\r]+[^\n\r]*[\n\r]+[^\n\r]*[\n\r]+[^
> \n\r]*(#|//)[ \t]+end of children of DIE[^\n\r]*[\n\r]+[^\n\r]*end of children
> o
> f DIE[^\n\r]*

Sorry, different issue.

Attached .s.

Probably, similar problems are present on hppa64-hp-hpux11.11 but bootstrap
is currently broken.


------- Comment #19 from dave at hiauly1 dot hia dot nrc dot ca  2010-08-09 00:35 -------
Created an attachment (id=21440)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21440&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641

[Bug c++/44641] Generated constructors and destructors get wrong debug location when a typedef uses a forward declaration of the type before the definition

[danglin at gcc dot gnu dot org]

------- Comment #20 from danglin at gcc dot gnu dot org  2010-08-10 22:13 -------
Test still fails on hppa-linux.


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44641