From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id F18BF385DC0B; Thu, 2 Sep 2021 02:07:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F18BF385DC0B From: "pinskia at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug preprocessor/44652] Column numbers in error messages are wrong Date: Thu, 02 Sep 2021 02:07:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: preprocessor X-Bugzilla-Version: 4.6.0 X-Bugzilla-Keywords: diagnostic X-Bugzilla-Severity: normal X-Bugzilla-Who: pinskia at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 02:07:20 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D44652 --- Comment #7 from Andrew Pinski --- where =3D linemap_included_from (map); map =3D linemap_included_from_linemap (line_table, map); bool is_module =3D MAP_MODULE_P (map); s.file =3D LINEMAP_FILE (map); s.line =3D SOURCE_LINE (map, where); int col =3D -1; if (first && context->show_column) { s.column =3D SOURCE_COLUMN (map, where); col =3D diagnostic_converted_column (context, s); } first is true so the column info must be missing from the preprocessor.=