[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hjl dot tools at gmail dot com]

-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] New: [4.6 Regression] Partial inlining breaks C++

[hjl dot tools at gmail dot com]

On Linux/x86-64, revision 161382:

http://gcc.gnu.org/ml/gcc-cvs/2010-06/msg01300.html

caused make-check failure in the libstdc++-v3 dir, during
the final link for testsuite_shared.so, ld spills:

relocation R_X86_64_PC32 against symbol
`__gnu_cxx::__common_pool<__gnu_cxx::__pool, true>::_S_get_pool()' can
not be used when making a shared object; recompile with -fPIC


-- 
           Summary: [4.6 Regression] Partial inlining breaks C++
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hubicka at gcc dot gnu dot org]

------- Comment #1 from hubicka at gcc dot gnu dot org  2010-06-26 11:39 -------
Subject: Bug 44671

Author: hubicka
Date: Sat Jun 26 11:38:57 2010
New Revision: 161428

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=161428
Log:
        PR middle-end/44671
        * cgraphunit.c (cgraph_function_versioning): Remove wrong
cgraph_make_decl_local
        call; fix typo copying RTL data.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraphunit.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hjl dot tools at gmail dot com]

------- Comment #2 from hjl dot tools at gmail dot com  2010-06-26 16:07 -------
On Linux/ia32, I also see:

FAIL: abi_check
FAIL: 23_containers/unordered_map/erase/1.cc execution test
FAIL: 23_containers/unordered_map/erase/24061-map.cc execution test
FAIL: 23_containers/unordered_map/insert/array_syntax.cc execution test
FAIL: 23_containers/unordered_map/insert/map_range.cc execution test
FAIL: 23_containers/unordered_map/insert/map_single.cc execution test
FAIL: 23_containers/unordered_map/requirements/citerators.cc execution test
FAIL: 23_containers/unordered_map/requirements/exception/basic.cc execution
test
FAIL:
23_containers/unordered_map/requirements/exception/generation_prohibited.cc
execution test
FAIL:
23_containers/unordered_map/requirements/exception/propagation_consistent.cc
execution test
FAIL: 23_containers/unordered_multimap/erase/1.cc execution test
FAIL: 23_containers/unordered_multimap/erase/24061-multimap.cc execution test
FAIL: 23_containers/unordered_multimap/insert/multimap_range.cc execution test
FAIL: 23_containers/unordered_multimap/insert/multimap_single.cc execution test
FAIL: 23_containers/unordered_multimap/requirements/citerators.cc execution
test
FAIL: 23_containers/unordered_multimap/requirements/exception/basic.cc
execution test
FAIL:
23_containers/unordered_multimap/requirements/exception/generation_prohibited.cc
execution test
FAIL:
23_containers/unordered_multimap/requirements/exception/propagation_consistent.cc
execution test
FAIL: 23_containers/unordered_multiset/erase/1.cc execution test
FAIL: 23_containers/unordered_multiset/erase/24061-multiset.cc execution test
FAIL: 23_containers/unordered_multiset/insert/multiset_range.cc execution test
FAIL: 23_containers/unordered_multiset/insert/multiset_single.cc execution test
FAIL: 23_containers/unordered_multiset/requirements/citerators.cc execution
test
FAIL: 23_containers/unordered_multiset/requirements/exception/basic.cc
execution test
FAIL:
23_containers/unordered_multiset/requirements/exception/generation_prohibited.cc
execution test
FAIL:
23_containers/unordered_multiset/requirements/exception/propagation_consistent.cc
execution test
FAIL: 23_containers/unordered_set/erase/1.cc execution test
FAIL: 23_containers/unordered_set/erase/24061-set.cc execution test
FAIL: 23_containers/unordered_set/insert/set_range.cc execution test
FAIL: 23_containers/unordered_set/insert/set_single.cc execution test
FAIL: 23_containers/unordered_set/requirements/citerators.cc execution test
FAIL: 23_containers/unordered_set/requirements/exception/basic.cc execution
test
FAIL:
23_containers/unordered_set/requirements/exception/generation_prohibited.cc
execution test
FAIL:
23_containers/unordered_set/requirements/exception/propagation_consistent.cc
execution test
FAIL: ext/pb_ds/example/basic_set.cc execution test
FAIL: ext/pb_ds/example/tree_intervals.cc execution test
FAIL: ext/pb_ds/example/tree_order_statistics.cc execution test
FAIL: ext/pb_ds/regression/tree_data_map_rand.cc execution test
FAIL: ext/pb_ds/regression/tree_no_data_map_rand.cc execution test
FAIL: tr1/6_containers/unordered_map/erase/1.cc execution test
FAIL: tr1/6_containers/unordered_map/erase/24061-map.cc execution test
FAIL: tr1/6_containers/unordered_map/insert/array_syntax.cc execution test
FAIL: tr1/6_containers/unordered_map/insert/map_range.cc execution test
FAIL: tr1/6_containers/unordered_map/insert/map_single.cc execution test
FAIL: tr1/6_containers/unordered_multimap/erase/1.cc execution test
FAIL: tr1/6_containers/unordered_multimap/erase/24061-multimap.cc execution
test
FAIL: tr1/6_containers/unordered_multimap/insert/multimap_range.cc execution
test
FAIL: tr1/6_containers/unordered_multimap/insert/multimap_single.cc execution
test
FAIL: tr1/6_containers/unordered_multiset/erase/1.cc execution test
FAIL: tr1/6_containers/unordered_multiset/erase/24061-multiset.cc execution
test
FAIL: tr1/6_containers/unordered_multiset/insert/multiset_range.cc execution
test
FAIL: tr1/6_containers/unordered_multiset/insert/multiset_single.cc execution
test
FAIL: tr1/6_containers/unordered_set/erase/1.cc execution test
FAIL: tr1/6_containers/unordered_set/erase/24061-set.cc execution test
FAIL: tr1/6_containers/unordered_set/insert/set_range.cc execution test
FAIL: tr1/6_containers/unordered_set/insert/set_single.cc execution test

Revision 161428 doesn't fix them.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hubicka at gcc dot gnu dot org]

------- Comment #3 from hubicka at gcc dot gnu dot org  2010-06-28 00:10 -------
Subject: Bug 44671

Author: hubicka
Date: Mon Jun 28 00:10:34 2010
New Revision: 161476

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=161476
Log:

        PR middle-end/44671
        PR middle-end/44686
        * tree.c (build_function_decl_skip_args): Clear DECL_BUILT_IN on
signature
        change.
        * ipa-split.c (split_function): Always clear DECL_BUILT_IN.
        * ipa-prop.c (ipa_modify_formal_parameters): Likewise.

        * gcc.c-torture/pr44686.c: New file.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr44686.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-prop.c
    trunk/gcc/ipa-split.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hp at gcc dot gnu dot org]

------- Comment #4 from hp at gcc dot gnu dot org  2010-06-28 07:45 -------
(In reply to comment #2)
> On Linux/ia32, I also see:

> FAIL: 23_containers/unordered_map/erase/1.cc execution test
> FAIL: 23_containers/unordered_map/erase/24061-map.cc execution test
> FAIL: 23_containers/unordered_map/insert/array_syntax.cc execution test
> FAIL: 23_containers/unordered_map/insert/map_range.cc execution test
(etc)
> Revision 161428 doesn't fix them.

I see those too, for cris-elf; assert failures (49 of them; regress-5 ->
regress-54).  They are *not* gone as of r161481.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

Re: [Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[Jan Hubicka]

> I see those too, for cris-elf; assert failures (49 of them; regress-5 ->
> regress-54).  They are *not* gone as of r161481.

In that case I guess I really need some way to reproduce them.  If this is glibc
version specific, can I possibly have preprocessed file for one of the testcases
at x86?
Thanks a lot!
Honza

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hubicka at ucw dot cz]

------- Comment #5 from hubicka at ucw dot cz  2010-06-28 08:27 -------
Subject: Re:  [4.6 Regression] Partial inlining
        breaks C++

> I see those too, for cris-elf; assert failures (49 of them; regress-5 ->
> regress-54).  They are *not* gone as of r161481.

In that case I guess I really need some way to reproduce them.  If this is
glibc
version specific, can I possibly have preprocessed file for one of the
testcases
at x86?
Thanks a lot!
Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hjl dot tools at gmail dot com]

------- Comment #6 from hjl dot tools at gmail dot com  2010-06-28 14:43 -------
(In reply to comment #5)
> Subject: Re:  [4.6 Regression] Partial inlining
>         breaks C++
> 
> > I see those too, for cris-elf; assert failures (49 of them; regress-5 ->
> > regress-54).  They are *not* gone as of r161481.
> 
> In that case I guess I really need some way to reproduce them.  If this is
> glibc
> version specific, can I possibly have preprocessed file for one of the
> testcases
> at x86?

I don't know if it is glibc specific. I saw them with
glibc 2.5, 2.11 and 2.12. Which test do you prefer
for preprocessed file?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hjl dot tools at gmail dot com]

------- Comment #7 from hjl dot tools at gmail dot com  2010-06-28 15:33 -------
Created an attachment (id=21029)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21029&action=view)
23_containers/unordered_map/insert/map_single.cc

This is the 32bit preprocessed 23_containers/unordered_map/insert/map_single.cc
with glibc 2.5.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hubicka at gcc dot gnu dot org]

------- Comment #8 from hubicka at gcc dot gnu dot org  2010-06-28 21:16 -------
Subject: Bug 44671

Author: hubicka
Date: Mon Jun 28 21:16:25 2010
New Revision: 161514

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=161514
Log:
        PR middle-end/44671
        * ipa-split.c (test_nonssa_use, mark_nonssa_use): Check also uses of
RESULT_DECL.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-split.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[paolo dot carlini at oracle dot com]

------- Comment #9 from paolo dot carlini at oracle dot com  2010-06-28 22:27 -------
Confirmed fixed, thanks.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671

[Bug middle-end/44671] [4.6 Regression] Partial inlining breaks C++

[hubicka at gcc dot gnu dot org]

------- Comment #10 from hubicka at gcc dot gnu dot org  2010-06-30 22:30 -------
Subject: Bug 44671

Author: hubicka
Date: Wed Jun 30 22:30:12 2010
New Revision: 161646

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=161646
Log:

        Backport from mainline

        2010-06-27  Jan Hubicka  <jh@suse.cz>

        PR middle-end/44671
        PR middle-end/44686
        * tree.c (build_function_decl_skip_args): Clear DECL_BUILT_IN on
        signature change.
        * ipa-split.c (split_function): Always clear DECL_BUILT_IN.
        * ipa-prop.c (ipa_modify_formal_parameters): Likewise.

        2010-06-28  Jan Hubicka  <jh@suse.cz>

        PR tree-optimization/44357
        * ipa-inline.c (add_new_edges_to_heap): Do not add edges to uninlinable
        functions.

Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/ipa-inline.c
    branches/gcc-4_5-branch/gcc/ipa-prop.c
    branches/gcc-4_5-branch/gcc/tree.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44671