[Bug bootstrap/44730] [4.6 Regression] Failed to bootstrap due to uninitialized error

[Bug bootstrap/44730] [4.6 Regression] Failed to bootstrap due to uninitialized error

[hjl dot tools at gmail dot com]

-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44730

[Bug bootstrap/44730] New: [4.6 Regression] Failed to bootstrap due to uninitialized error

[hjl dot tools at gmail dot com]

On Linux/x86-64, revision 161606 gave:

../../src-trunk/gcc/graphite-sese-to-poly.c: In function
'build_scop_drs.isra.110':
../../src-trunk/gcc/graphite-sese-to-poly.c:1784:15: error:
'dr_base_object_set' may be used uninitialized in this function
[-Werror=uninitialized]
../../src-trunk/gcc/graphite-sese-to-poly.c:1765:7: note: 'dr_base_object_set'
was declared here
../../src-trunk/gcc/graphite-sese-to-poly.c:2008:25: error: 'bap' may be used
uninitialized in this function [-Werror=uninitialized]
../../src-trunk/gcc/graphite-sese-to-poly.c:2003:24: note: 'bap' was declared
here
../../src-trunk/gcc/graphite-sese-to-poly.c:1929:22: error: 'bap' may be used
uninitialized in this function [-Werror=uninitialized]
../../src-trunk/gcc/graphite-sese-to-poly.c:1924:24: note: 'bap' was declared
here
cc1: all warnings being treated as errors

I saw

2000   for (i = 0; i < g->n_vertices; i++)
2001     {
2002       data_reference_p dr = VEC_index (data_reference_p, drs, i);
2003       base_alias_pair *bap;
2004 
2005       if (dr->aux)
2006         bap = (base_alias_pair *)(dr->aux);
2007 
2008       bap->base_obj_set = g->vertices[i].component + 1;
2009     }


-- 
           Summary: [4.6 Regression] Failed to bootstrap due to
                    uninitialized error
           Product: gcc
           Version: 4.5.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl dot tools at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44730

[Bug bootstrap/44730] [4.6 Regression] Failed to bootstrap due to uninitialized error

[hjl dot tools at gmail dot com]

------- Comment #1 from hjl dot tools at gmail dot com  2010-06-30 16:15 -------
This makes it to compile:

--
diff --git a/gcc/graphite-sese-to-poly.c b/gcc/graphite-sese-to-poly.c
index b73517d..c3890ec 100644
--- a/gcc/graphite-sese-to-poly.c
+++ b/gcc/graphite-sese-to-poly.c
@@ -1779,10 +1779,12 @@ build_poly_dr (data_reference_p dr, poly_bb_p pbb)
   ppl_delete_Polyhedron (accesses);

   if (dr->aux)
-    dr_base_object_set = ((base_alias_pair *)(dr->aux))->base_obj_set;
-
-  new_poly_dr (pbb, dr_base_object_set, accesses_ps, DR_IS_READ (dr) ?
PDR_READ : PDR_WRITE,
-              dr, DR_NUM_DIMENSIONS (dr));
+    {
+      dr_base_object_set = ((base_alias_pair *)(dr->aux))->base_obj_set;
+      new_poly_dr (pbb, dr_base_object_set, accesses_ps,
+                  DR_IS_READ (dr) ? PDR_READ : PDR_WRITE,
+                  dr, DR_NUM_DIMENSIONS (dr));
+    }
 }

 /* Write to FILE the alias graph of data references in DIMACS format.  */
@@ -1921,13 +1923,12 @@ build_alias_set_optimal_p (VEC (data_reference_p, heap)
*drs)
   for (i = 0; i < g->n_vertices; i++)
     {
       data_reference_p dr = VEC_index (data_reference_p, drs, i);
-      base_alias_pair *bap;
-
       if (dr->aux)
-       bap = (base_alias_pair *)(dr->aux);
-
-      bap->alias_set = XNEW (int);
-      *(bap->alias_set) = g->vertices[i].component + 1;
+       {
+         base_alias_pair *bap = (base_alias_pair *)(dr->aux);
+         bap->alias_set = XNEW (int);
+         *(bap->alias_set) = g->vertices[i].component + 1;
+       }
     }

   /* Verify if the DFS numbering results in optimal solution.  */
@@ -2000,12 +2001,11 @@ build_base_obj_set_for_drs (VEC (data_reference_p,
heap) *drs)
   for (i = 0; i < g->n_vertices; i++)
     {
       data_reference_p dr = VEC_index (data_reference_p, drs, i);
-      base_alias_pair *bap;
-
       if (dr->aux)
-       bap = (base_alias_pair *)(dr->aux);
-
-      bap->base_obj_set = g->vertices[i].component + 1;
+       {
+         base_alias_pair *bap = (base_alias_pair *)(dr->aux);
+         bap->base_obj_set = g->vertices[i].component + 1;
+       }
     }

   free (queue);
---

But I don't know if it is correct.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44730

[Bug bootstrap/44730] [4.6 Regression] Failed to bootstrap due to uninitialized error

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2010-06-30 16:16 -------
This is a duplicate of pr44726.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44730

[Bug bootstrap/44730] [4.6 Regression] Failed to bootstrap due to uninitialized error

[hjl dot tools at gmail dot com]

------- Comment #3 from hjl dot tools at gmail dot com  2010-06-30 16:19 -------


*** This bug has been marked as a duplicate of 44726 ***


-- 

hjl dot tools at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44730