[Bug bootstrap/44768] New: arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[Bug bootstrap/44768] New: arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[laurent at guerby dot net]

OK at rev 160819
KO at rev 160869

/home/guerby/build/./prev-gcc/xgcc -B/home/guerby/build/./prev-gcc/
-B/n/57/guerby/install-trunk-160869/armv5tel-unknown-linux-gnueabi/bin/
-B/n/57/guerby/install-trunk-160869/armv5tel-unknown-linux-gnueabi/bin/
-B/n/57/guerby/install-t\
runk-160869/armv5tel-unknown-linux-gnueabi/lib/ -isystem
/n/57/guerby/install-trunk-160869/armv5tel-unknown-linux-gnueabi/include
-isystem
/n/57/guerby/install-trunk-160869/armv5tel-unknown-linux-gnueabi/sys-include   
-c   -g -O2 -DIN_\
GCC   -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Werror -Wold-style-definition
-Wc++-compat -fno-common\
 -Wno-error -DHAVE_CONFIG_H -I. -I. -I../../trunk/gcc -I../../trunk/gcc/.
-I../../trunk/gcc/../include -I../../trunk/gcc/../libcpp/include 
-I../../trunk/gcc/../libdecnumber -I../../trunk/gcc/../libdecnumber/dpd
-I../libdecnumber     ..\
/../trunk/gcc/expmed.c -o expmed.o
../../trunk/gcc/expmed.c: In function 'init_expmed':
../../trunk/gcc/expmed.c:157:3: warning: array subscript is above array bounds
[-Warray-bounds]
xgcc: internal compiler error: Segmentation fault (program cc1)
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[3]: *** [expmed.o] Error 4
make[3]: Leaving directory `/home/guerby/build/gcc'
make[2]: *** [all-stage3-gcc] Error 2
make[2]: Leaving directory `/home/guerby/build'
make[1]: *** [stage3-bubble] Error 2
make[1]: Leaving directory `/home/guerby/build'
make: *** [bootstrap] Error 2

Might be caused by:

2010-06-16  DJ Delorie  <dj@redhat.com>

        * common.opt (-fstrict-volatile-bitfields): new.
        * doc/invoke.texi: Document it.
        * fold-const.c (optimize_bit_field_compare): For volatile
        bitfields, use the field's type to determine the mode, not the
        field's size.
        * expr.c (expand_assignment): Likewise.
        (get_inner_reference): Likewise.
        (expand_expr_real_1): Likewise.
        * expmed.c (store_fixed_bit_field): Likewise.
        (extract_bit_field_1): Likewise.
        (extract_fixed_bit_field): Likewise.


-- 
           Summary: arm-linux bootstrap broken on expmed.c:157:3: warning
                    ICE
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: laurent at guerby dot net
 GCC build triplet: arm-linux-gnueabi
  GCC host triplet: arm-linux-gnueabi
GCC target triplet: arm-linux-gnueabi


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2010-07-01 21:37 -------
Please attach preprocessed source so people can reproduce this with a cross


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[laurent at guerby dot net]

------- Comment #2 from laurent at guerby dot net  2010-07-02 06:46 -------
Created an attachment (id=21059)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21059&action=view)
expmed.i

expmed.i


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[laurent at guerby dot net]

------- Comment #3 from laurent at guerby dot net  2010-07-02 06:50 -------
Non debug baktrace:

(gdb) r -fpreprocessed expmed.i -quiet -dumpbase expmed.i -auxbase expmed -g
-O2 -O2 -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Wold-style-definition
-Wc++-compat -Wno-error -version -fno-common 
Starting program: /home/guerby/build/prev-gcc/cc1 -fpreprocessed expmed.i
-quiet -dumpbase expmed.i -auxbase expmed -g -O2 -O2 -W -Wall -Wwrite-strings
-Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wmissing-format-attribute
-pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings
-Wold-style-definition -Wc++-compat -Wno-error -version -fno-common
GNU C (GCC) version 4.6.0 20100701 (experimental) [trunk revision 161675]
(armv5tel-unknown-linux-gnueabi)
        compiled by GNU C version 4.6.0 20100701 (experimental) [trunk revision
161675], GMP version 4.3.2, MPFR version 2.4.2-p1, MPC version 0.8.2
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU C (GCC) version 4.6.0 20100701 (experimental) [trunk revision 161675]
(armv5tel-unknown-linux-gnueabi)
        compiled by GNU C version 4.6.0 20100701 (experimental) [trunk revision
161675], GMP version 4.3.2, MPFR version 2.4.2-p1, MPC version 0.8.2
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: df212a125ed9147cba1a3603b92d8232
../../trunk/gcc/expmed.c: In function 'init_expmed':
../../trunk/gcc/expmed.c:157:23: warning: array subscript is above array bounds
[-Warray-bounds]

Program received signal SIGSEGV, Segmentation fault.
0x00338700 in pp_base_format ()
(gdb) bt
#0  0x00338700 in pp_base_format ()
#1  0x0019fdac in diagnostic_report_diagnostic ()
#2  0x622d7960 in ?? ()
#3  0x622d7960 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[laurent at guerby dot net]

-- 

laurent at guerby dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|2010-07-02 13:50:59         |2010-07-02 13:51:22
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[ramana at gcc dot gnu dot org]

------- Comment #4 from ramana at gcc dot gnu dot org  2010-07-02 16:15 -------
I'm getting this failure in stage3 thus just attaching the expmed.i
pre-processed file isn't enough to reproduce this with a cross. 

Doing a bisect I find that 

rev: 160827 - builds expmed.o in stage3 .
rev: 160833 - Segfaults while building expmed.o 

rev:160832 was this commit .


Author: jamborm <jamborm@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Jun 16 12:21:56 2010 +0000

    2010-06-16  Martin Jambor  <mjambor@suse.cz>

        PR tree-optimization/43905
        * tree-sra.c: Include tree-inline.h.
        (create_abstract_origin): Removed.
        (modify_function): Version the call graph node instead of creating
        abstract origins and dealing with same_body aliases.
        * tree-sra.c (ipa_sra_preliminary_function_checks): Check whether the
        function is versionable.
        * Makefile.in (tree-sra.o): Add TREE_INLINE_H to dependencies.

        * testsuite/g++.dg/torture/pr43905.C: New test.



    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@160832 


while 160833 touches only libstdc++



I think there is a case of memory corruption or miscompilation somewhere
because of which global_dc->printer changes value between 2 calls to
diagnostic_report_diagnostic. Still digging to find out what's gone wrong here
- might well be a latent bug exposed from elsewhere.



Cheers
Ramana


-- 

ramana at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamborm at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[ramana at gcc dot gnu dot org]

------- Comment #5 from ramana at gcc dot gnu dot org  2010-07-06 22:29 -------
The problem essentially is a miscompilation of diagnostic_action_after_output
in this case .


Attached is a testcase that demonstrates this problem with a cross compiler. 

Configure just the compiler with arm-linux-gnueabi  and you can see the
problem. 

diagnostic_action_after_output.isra.1:
        @ Volatile: function does not return.  ---> There we go ! Treating this
function as a NORETURN function when it clearly is *not* .
        @ args = 0, pretend = 0, frame = 0
        @ frame_needed = 0, uses_anonymous_args = 0
        sub     r1, r1, #2
        stmfd   sp!, {r3, lr} --> Not saved in the set of callee saved
registers ... 
        mov     r4, r0   --> r4 is clobbered and is a callee saved register. 
        cmp     r1, #7
        ldrls   pc, [pc, r1, asl #2]
        b       .L69
.L74:
        .word   .L70
        .word   .L71
        .word   .L72
        .word   .L72
        .word   .L68
        .word   .L68
        .word   .L68
        .word   .L68
.L72:
        ldrb    r3, [r0, #65]   @ zero_extendqisi2
        cmp     r3, #0


>From a session in gdb. As you can see the call to arm_compute_func_type is the
one that causes the problems here. arm_compute_func_type decides whether a
function is volatile or not depending on the value of TREE_THIS_VOLATILE for
current_function_decl. This allows the compiler to do optimizations that remove
the save of callee save registers in such volatile functions.


#0  arm_compute_func_type () at
/work/fsfwork/svn/trunk/gcc/config/arm/arm.c:1949
#1  0x000000000094a764 in arm_current_func_type () at
/work/fsfwork/svn/trunk/gcc/config/arm/arm.c:1993
#2  0x000000000094a787 in arm_allocate_stack_slots_for_args () at
/work/fsfwork/svn/trunk/gcc/config/arm/arm.c:2002
#3  0x000000000060da5e in use_register_for_decl (decl=0x2b5ae7029960) at
/work/fsfwork/svn/trunk/gcc/function.c:2015
#4  0x00000000004e5251 in expand_one_var (var=0x2b5ae7029960, toplevel=1
'\001', really_expand=0 '\0') at /work/fsfwork/svn/trunk/gcc/cfgexpand.c:983
#5  0x00000000004e5fcb in estimated_stack_frame_size () at
/work/fsfwork/svn/trunk/gcc/cfgexpand.c:1276
#6  0x000000000098d855 in compute_inline_parameters (node=0x2b5ae6f2cc18) at
/work/fsfwork/svn/trunk/gcc/ipa-inline.c:2022
#7  0x000000000080b631 in convert_callers (node=0x2b5ae6d89158,
old_decl=0x2b5ae6f1ff00, adjustments=0x4384680) at
/work/fsfwork/svn/trunk/gcc/tree-sra.c:4212
#8  0x000000000080b96c in modify_function (node=0x2b5ae6f2c560,
adjustments=0x4384680) at /work/fsfwork/svn/trunk/gcc/tree-sra.c:4276
#9  0x000000000080be6f in ipa_early_sra () at
/work/fsfwork/svn/trunk/gcc/tree-sra.c:4395
#10 0x00000000006ca396 in execute_one_pass (pass=0x1118480) at
/work/fsfwork/svn/trunk/gcc/passes.c:1565
#11 0x00000000006ca4ec in execute_pass_list (pass=0x1118480) at
/work/fsfwork/svn/trunk/gcc/passes.c:1620
#12 0x00000000006ca505 in execute_pass_list (pass=0x11181e0) at
/work/fsfwork/svn/trunk/gcc/passes.c:1621
#13 0x00000000006c998b in do_per_function_toporder (callback=0x6ca4d0
<execute_pass_list>, data=0x11180c0) at
/work/fsfwork/svn/trunk/gcc/passes.c:1158
#14 0x00000000006cad17 in execute_ipa_pass_list (pass=0x1118240) at
/work/fsfwork/svn/trunk/gcc/passes.c:1920
#15 0x0000000000982269 in cgraph_optimize () at
/work/fsfwork/svn/trunk/gcc/cgraphunit.c:1851
#16 0x00000000009824ea in cgraph_finalize_compilation_unit () at
/work/fsfwork/svn/trunk/gcc/cgraphunit.c:1171
#17 0x0000000000418b34 in c_write_global_declarations () at
/work/fsfwork/svn/trunk/gcc/c-decl.c:9698
#18 0x000000000076ee64 in toplev_main (argc=4, argv=0x7fffc3eda328) at
/work/fsfwork/svn/trunk/gcc/toplev.c:997


(gdb) p current_function_name ()
$3 = 0x2b5ae7024bb8 "diagnostic_action_after_output.isra.1"
(gdb) p current_function_decl
$4 = (tree) 0x2b5ae6f1fe00
(gdb) pct

error_recursion


(gdb) p cfun->decl
$5 = (tree) 0x2b5ae703c500
(gdb) pct
diagnostic_action_after_output.isra.1

Notice that cfun->decl and current_function_decl are different here because the
context hasn't been set up correctly in tree-sra.c . The following patch
appears to fix it by correctly not setting the function to be non-volatile. 




Index: tree-sra.c
===================================================================
--- tree-sra.c  (revision 161870)
+++ tree-sra.c  (working copy)
@@ -4209,8 +4209,11 @@ convert_callers (struct cgraph_node *nod
   for (cs = node->callers; cs; cs = cs->next_caller)
     if (!bitmap_bit_p (recomputed_callers, cs->caller->uid))
       {
+       current_function_decl = cs->caller->decl;
+       push_cfun (DECL_STRUCT_FUNCTION (cs->caller->decl));
        compute_inline_parameters (cs->caller);
        bitmap_set_bit (recomputed_callers, cs->caller->uid);
+       pop_cfun ();
       }
   BITMAP_FREE (recomputed_callers);





After the patch was applied on a cross-compiler 

diagnostic_action_after_output.isra.1:
        @ args = 0, pretend = 0, frame = 0
        @ frame_needed = 0, uses_anonymous_args = 0

        sub     r1, r1, #2
        stmfd   sp!, {r4, lr}  -> Notice the save of r4 on the stack. 
        mov     r4, r0 

Now bootstrapping on arm-linux-gnueabi.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[ramana at gcc dot gnu dot org]

------- Comment #6 from ramana at gcc dot gnu dot org  2010-07-06 22:39 -------
Created an attachment (id=21116)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21116&action=view)
Actual testcase . 

Attached testcase. Configure cross compiler with 

 --target=arm-eabi or --target=arm-linux-gnueabi and 
 --enable-languages=c



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[ramana at gcc dot gnu dot org]

------- Comment #7 from ramana at gcc dot gnu dot org  2010-07-09 16:19 -------
Should be fixed by this commit.

http://gcc.gnu.org/ml/gcc-cvs/2010-07/msg00301.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768

[Bug bootstrap/44768] arm-linux bootstrap broken on expmed.c:157:3: warning ICE

[ramana at gcc dot gnu dot org]

------- Comment #8 from ramana at gcc dot gnu dot org  2010-07-27 13:37 -------
Fixed.


-- 

ramana at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44768