public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "paul.richard.thomas at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/44945] [4.6 Regression] Wrong decl for module vars / FAIL: gfortran.dg/char_array_structure_constructor.f90 Date: Sat, 19 Feb 2011 15:12:00 -0000 [thread overview] Message-ID: <bug-44945-4-CJLnGVMu79@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-44945-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44945 --- Comment #32 from paul.richard.thomas at gmail dot com <paul.richard.thomas at gmail dot com> 2011-02-19 15:07:03 UTC --- Dear Tobias, > > Aha, you have taken the simple route of modifying trans-decl.c and not the > whole module reading apparatus :-) Of course - otherwise, we stand no chance of getting rid of the regression. It's only a small addition to the existing section of code, so I thought that it had the advantage of being very clean too. The revamp of module.c can wait until we have nothing to do :-) > > I think the patch is OK, though I would do some reordering, e.g. "sym->module" > is not needed as the whole block is enclosed in such a check. > > I also would move the block down into > if (gsym && gsym->ns && gsym->type == GSYM_MODULE) > which could be changed into > if (!gsym || (gsym && gsym->ns && gsym->type == GSYM_MODULE)) > > And > - gfc_find_symbol (sym->name, gsym->ns, 0, &s); > + if (gsym) > + gfc_find_symbol (sym->name, gsym->ns, 0, &s); > > And then placing the "if (gsym == NULL)" in the > + else if (s == NULL) > block. All done. > (In reply to comment #30) >> The bus error reported in comment #21 has disappeared from my scope between >> revisions 167584 and 167726;-( > > Ditto here, but looking at the dump, I see that the underlying issue is still > present - and it is fixed by the patch. > > * * * > > I will do some more tests. Let me know when you have done them. What about a testcase? I guess that since it was a testsuite failure we do not need one? > > Related to those whole-file DECL issues: I wonder why there are still > differences between -flto and -fno-lto on Polyhedron (result is correct but > runtimes are different) and for Jack (-O3 miscompilation of xplor-nih's slink.f > and tenso.f, unless -fno-whole-file is used; -fno-inline-functions does not > help). Is there a PR for Jack's problem. Thanks for looking at the patch Paul
next prev parent reply other threads:[~2011-02-19 15:07 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-44945-4@http.gcc.gnu.org/bugzilla/> 2011-02-19 12:27 ` pault at gcc dot gnu.org 2011-02-19 13:46 ` dominiq at lps dot ens.fr 2011-02-19 13:55 ` burnus at gcc dot gnu.org 2011-02-19 15:12 ` paul.richard.thomas at gmail dot com [this message] 2011-02-20 16:28 ` pault at gcc dot gnu.org 2011-02-20 16:37 ` pault at gcc dot gnu.org 2010-07-15 8:32 [Bug middle-end/44945] New: [4.6 Regression] " dominiq at lps dot ens dot fr 2010-07-16 9:12 ` [Bug fortran/44945] [4.6 Regression] Wrong decl for module vars / " burnus at gcc dot gnu dot org 2010-07-16 10:08 ` jakub at gcc dot gnu dot org 2010-07-16 12:08 ` burnus at gcc dot gnu dot org 2010-07-16 12:09 ` burnus at gcc dot gnu dot org 2010-07-16 12:33 ` jakub at gcc dot gnu dot org 2010-07-16 14:22 ` burnus at gcc dot gnu dot org 2010-07-16 14:38 ` paul dot richard dot thomas at gmail dot com 2010-07-16 14:47 ` burnus at gcc dot gnu dot org 2010-07-23 20:13 ` burnus at gcc dot gnu dot org 2010-07-23 20:16 ` burnus at gcc dot gnu dot org 2010-07-24 5:38 ` dominiq at lps dot ens dot fr 2010-07-24 6:52 ` burnus at gcc dot gnu dot org 2010-07-24 7:50 ` dominiq at lps dot ens dot fr 2010-07-24 13:44 ` rguenther at suse dot de 2010-07-24 18:14 ` burnus at gcc dot gnu dot org 2010-07-28 7:41 ` burnus at gcc dot gnu dot org 2010-08-17 9:42 ` pault at gcc dot gnu dot org 2010-08-18 14:41 ` mikael at gcc dot gnu dot org 2010-09-21 13:16 ` rguenth at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-44945-4-CJLnGVMu79@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).