[Bug middle-end/44982] [4.3/4.4/4.5/4.6 Regression] ICE in get_narrower, at tree.c:7832

[Bug middle-end/44982] [4.3/4.4/4.5/4.6 Regression] ICE in get_narrower, at tree.c:7832

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu.org

--- Comment #3 from Steven Bosscher <steven at gcc dot gnu.org> 2010-12-17 21:26:45 UTC ---
I see no reason to cgraph_finalize_compilation_unit if there were parse errors.
Richi, what do you think?


Index: toplev.c
===================================================================
--- toplev.c    (revision 167996)
+++ toplev.c    (working copy)
@@ -582,7 +582,12 @@
      what's left of the symbol table output.  */
   timevar_pop (TV_PARSE);

-  if (flag_syntax_only || flag_wpa)
+  /* If all we have to do is syntax checking, or if there were parse
+     errors, stop here.  */
+  if (flag_syntax_only || seen_error)
+    return;
+
+  if (flag_wpa)
     return;

   ggc_protect_identifiers = false;
@@ -590,9 +595,6 @@
   /* This must also call cgraph_finalize_compilation_unit.  */
   lang_hooks.decls.final_write_globals ();

-  if (seen_error ())
-    return;
-
   varpool_assemble_pending_decls ();
   finish_aliases_2 ();

[Bug middle-end/44982] [4.3/4.4/4.5/4.6 Regression] ICE in get_narrower, at tree.c:7832

[rguenther at suse dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

--- Comment #4 from rguenther at suse dot de <rguenther at suse dot de> 2010-12-18 20:22:18 UTC ---
On Fri, 17 Dec 2010, steven at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982
> 
> Steven Bosscher <steven at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |rguenth at gcc dot gnu.org
> 
> --- Comment #3 from Steven Bosscher <steven at gcc dot gnu.org> 2010-12-17 21:26:45 UTC ---
> I see no reason to cgraph_finalize_compilation_unit if there were parse errors.
> Richi, what do you think?

I think the idea was we want to preserve warnings and errors we generate
from the middle-end.  But the patch looks sensible to me anyway, maybe
post it up for disscussion, as it would affect all frontends.

Richard.

> 
> Index: toplev.c
> ===================================================================
> --- toplev.c    (revision 167996)
> +++ toplev.c    (working copy)
> @@ -582,7 +582,12 @@
>       what's left of the symbol table output.  */
>    timevar_pop (TV_PARSE);
> 
> -  if (flag_syntax_only || flag_wpa)
> +  /* If all we have to do is syntax checking, or if there were parse
> +     errors, stop here.  */
> +  if (flag_syntax_only || seen_error)
> +    return;
> +
> +  if (flag_wpa)
>      return;
> 
>    ggc_protect_identifiers = false;
> @@ -590,9 +595,6 @@
>    /* This must also call cgraph_finalize_compilation_unit.  */
>    lang_hooks.decls.final_write_globals ();
> 
> -  if (seen_error ())
> -    return;
> -
>    varpool_assemble_pending_decls ();
>    finish_aliases_2 ();
> 
>

[Bug middle-end/44982] [4.3/4.4/4.5/4.6/4.7 Regression] ICE in get_narrower, at tree.c:7832

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.6                       |4.4.7

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-27 12:13:37 UTC ---
4.3 branch is being closed, moving to 4.4.7 target.

[Bug middle-end/44982] [4.5/4.6/4.7/4.8 Regression] ICE in get_narrower, at tree.c:7832

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.4.7                       |4.5.4

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-03-13 12:46:36 UTC ---
4.4 branch is being closed, moving to 4.5.4 target.

[Bug middle-end/44982] [4.6/4.7/4.8 Regression] ICE in get_narrower, at tree.c:7832

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.4                       |4.6.4

[Bug middle-end/44982] [4.7/4.8/4.9 Regression] ICE in get_narrower, at tree.c:7832

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.6.4                       |4.7.4

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-12 15:16:29 UTC ---
GCC 4.6.4 has been released and the branch has been closed.

[Bug middle-end/44982] [4.7/4.8/4.9/4.10 Regression] ICE in get_narrower, at tree.c:7832

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.4                       |4.8.4

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
The 4.7 branch is being closed, moving target milestone to 4.8.4.

[Bug middle-end/44982] [4.8/4.9/5 Regression] ICE in get_narrower, at tree.c:7832

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug middle-end/44982] [4.8/4.9/5 Regression] ICE in get_narrower, at tree.c:7832

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

tbsaunde at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tbsaunde at gcc dot gnu.org

--- Comment #10 from tbsaunde at gcc dot gnu.org ---
(In reply to Richard Biener from comment #1)
> Confirmed.

hm, wfm, but it looks like the patch in comment 3 wasn't applied.  Is there
something to do here?

[Bug middle-end/44982] [4.8/4.9/5 Regression] ICE in get_narrower, at tree.c:7832

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

--- Comment #11 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 15 Jan 2015, tbsaunde at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982
> 
> tbsaunde at gcc dot gnu.org changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |tbsaunde at gcc dot gnu.org
> 
> --- Comment #10 from tbsaunde at gcc dot gnu.org ---
> (In reply to Richard Biener from comment #1)
> > Confirmed.
> 
> hm, wfm, but it looks like the patch in comment 3 wasn't applied.  Is there
> something to do here?

Not sure if it was posted or tested - so maybe just do a bootstrap & 
regtest with all languages and if that succeeds the patch  (with the
testcase) is preapproved.

[Bug middle-end/44982] [4.8/4.9/5 Regression] ICE in get_narrower, at tree.c:7832

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

--- Comment #12 from tbsaunde at gcc dot gnu.org ---
(In reply to rguenther@suse.de from comment #11)
> On Thu, 15 Jan 2015, tbsaunde at gcc dot gnu.org wrote:
> 
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982
> > 
> > tbsaunde at gcc dot gnu.org changed:
> > 
> >            What    |Removed                     |Added
> > ----------------------------------------------------------------------------
> >                  CC|                            |tbsaunde at gcc dot gnu.org
> > 
> > --- Comment #10 from tbsaunde at gcc dot gnu.org ---
> > (In reply to Richard Biener from comment #1)
> > > Confirmed.
> > 
> > hm, wfm, but it looks like the patch in comment 3 wasn't applied.  Is there
> > something to do here?
> 
> Not sure if it was posted or tested - so maybe just do a bootstrap & 
> regtest with all languages and if that succeeds the patch  (with the
> testcase) is preapproved.

there is at least a large number of c++ test cases that fail with the patch. 
They all seem to be what you'd expect a file has errors before the new check,
and more errors or warnings are expected to be emitted after the new check.  It
seems like some part of this setup is crazy, but I'm not really sure what to do
about it at this point.

[Bug middle-end/44982] [4.8/4.9/5/6 Regression] ICE in get_narrower, at tree.c:7832

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.5                       |4.9.3

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
The gcc-4_8-branch is being closed, re-targeting regressions to 4.9.3.

[Bug middle-end/44982] [4.9/5/6 Regression] ICE in get_narrower, at tree.c:7832

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug middle-end/44982] [4.9/5/6 Regression] ICE in get_narrower, at tree.c:7832

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4