From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-341163-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4053 invoked by alias); 17 Dec 2010 21:26:52 -0000
Received: (qmail 4006 invoked by uid 22791); 17 Dec 2010 21:26:52 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Dec 2010 21:26:47 +0000
From: "steven at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/44982] [4.3/4.4/4.5/4.6 Regression] ICE in get_narrower, at tree.c:7832
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Keywords: error-recovery, ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: steven at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P5
X-Bugzilla-Assigned-To: steven at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.3.6
X-Bugzilla-Changed-Fields: CC
Message-ID: <bug-44982-4-twaDnNEw5x@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-44982-4@http.gcc.gnu.org/bugzilla/>
References: <bug-44982-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Fri, 17 Dec 2010 21:26:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2010-12/txt/msg02146.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44982

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu.org

--- Comment #3 from Steven Bosscher <steven at gcc dot gnu.org> 2010-12-17 21:26:45 UTC ---
I see no reason to cgraph_finalize_compilation_unit if there were parse errors.
Richi, what do you think?


Index: toplev.c
===================================================================
--- toplev.c    (revision 167996)
+++ toplev.c    (working copy)
@@ -582,7 +582,12 @@
      what's left of the symbol table output.  */
   timevar_pop (TV_PARSE);

-  if (flag_syntax_only || flag_wpa)
+  /* If all we have to do is syntax checking, or if there were parse
+     errors, stop here.  */
+  if (flag_syntax_only || seen_error)
+    return;
+
+  if (flag_wpa)
     return;

   ggc_protect_identifiers = false;
@@ -590,9 +595,6 @@
   /* This must also call cgraph_finalize_compilation_unit.  */
   lang_hooks.decls.final_write_globals ();

-  if (seen_error ())
-    return;
-
   varpool_assemble_pending_decls ();
   finish_aliases_2 ();