[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[pault at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

--- Comment #13 from Paul Thomas <pault at gcc dot gnu.org> 2010-09-26 09:04:38 UTC ---
I'll do 4.4 and 4.3 when I get back to Barcelona on Tuesday night.

Paul

[Bug fortran/45081] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[pault at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
            Summary|[4.3/4.4/4.5/4.6            |[4.3/4.4 Regression] ICE in
                   |Regression] ICE in          |gfc_conv_array_initializer,
                   |gfc_conv_array_initializer, |at
                   |at                          |fortran/trans-array.c:4208
                   |fortran/trans-array.c:4208  |

--- Comment #14 from Paul Thomas <pault at gcc dot gnu.org> 2010-10-08 04:46:57 UTC ---
(In reply to comment #13)
> I'll do 4.4 and 4.3 when I get back to Barcelona on Tuesday night.
> 
> Paul

I tried, produced a working patch (only one intrinsic affected in 4.4) but the
testcase fails with:

FAIL: gfortran.dg/derived_array_intrinisics_1.f90  -O  (test for excess errors)
FAIL: gfortran.dg/derived_array_intrinisics_1.f90  -O  scan-tree-dump-times
original "j = 10" 1: dump file does not exist

Why should the dump file not exist?  I am very loath to have an execute test
for this.

Paul

[Bug fortran/45081] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

--- Comment #15 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-10-08 06:01:44 UTC ---
(In reply to comment #14)
> FAIL: gfortran.dg/derived_array_intrinisics_1.f90  -O  (test for excess errors)
> FAIL: gfortran.dg/derived_array_intrinisics_1.f90  -O  scan-tree-dump-times
> original "j = 10" 1: dump file does not exist
> 
> Why should the dump file not exist?

Because of the first line: Seemingly, you get some (excess) error(s) and thus
the compiler aborts before it can dump the tree.

Run the test with
  cd $GCCBUILD/gcc
  make check-gfortran RUNTESTFLAGS='dg.exp=derived_array_intrinisics_1.f90'
and search for the "excess error" in testsuite/gfortran/gfortran.log.

[Bug fortran/45081] [4.3/4.4 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

--- Comment #16 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-09 08:09:59 UTC ---
Author: burnus
Date: Thu Dec  9 08:09:52 2010
New Revision: 167627

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167627
Log:
2010-12-09  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/45081
        * simplify.c (is_constant_array_expr): Allow structure array
        elements as well as constants.
        (gfc_simplify_reshape): Copy the derived type of source to
        the result.

2010-12-09  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/45081
        * gfortran.dg/derived_array_intrinsics_1.f90 : New test.


Added:
   
branches/gcc-4_4-branch/gcc/testsuite/gfortran.dg/derived_array_intrinisics_1.f90
Modified:
    branches/gcc-4_4-branch/gcc/fortran/ChangeLog
    branches/gcc-4_4-branch/gcc/fortran/simplify.c
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog

[Bug fortran/45081] [4.3 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.2                       |4.3.6
            Summary|[4.3/4.4 Regression] ICE in |[4.3 Regression] ICE in
                   |gfc_conv_array_initializer, |gfc_conv_array_initializer,
                   |at                          |at
                   |fortran/trans-array.c:4208  |fortran/trans-array.c:4208

--- Comment #17 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-09 08:11:58 UTC ---
Regarding the backport to 4.4: It only handles RESHAPE; as the simplification
for SPREAD, TRANSPOSE and (UN)PACK is not implemented in 4.4.

TODO: Backport to 4.3.

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[4.3 Regression] ICE in     |[4.3/4.4/4.5/4.6
                   |gfc_conv_array_initializer, |Regression] ICE in
                   |at                          |gfc_conv_array_initializer,
                   |fortran/trans-array.c:4208  |at
                   |                            |fortran/trans-array.c:4208

--- Comment #19 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-09 13:31:38 UTC ---
CLOSE as FIXED as the patch has been committed for 4.3, 4.4, 4.5 and 4.6.

Thanks Thorsten for the report - and thanks Paul for the patch!

(Note: For GCC 4.3 I get test suite failures for
gfortran.dg/elemental_subroutine_7.f90; those are unrelated to the patch and
are probably no regression. Here, they only show up either with GLIBC's
MALLOC_PERTURB_ or in valgrind. As the issue does not occur on 4.4 to 4.6, I
tacitly move on.)

[Bug fortran/45081] [4.3 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

--- Comment #18 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-09 13:31:02 UTC ---
Author: burnus
Date: Thu Dec  9 13:30:59 2010
New Revision: 167637

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167637
Log:
2010-12-09  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/45081
        * simplify.c (is_constant_array_expr): Allow structure array
        elements as well as constants.
        (gfc_simplify_reshape): Copy the derived type of source to
        the result.

2010-12-09  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/45081
        * gfortran.dg/derived_array_intrinsics_1.f90 : New test.


Added:
   
branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/derived_array_intrinisics_1.f90
Modified:
    branches/gcc-4_3-branch/gcc/fortran/ChangeLog
    branches/gcc-4_3-branch/gcc/fortran/simplify.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog