[Bug middle-end/45231] gcc.c-torture/compile/941014-2.c ICEs with -fgraphite-identity

[Bug middle-end/45231] gcc.c-torture/compile/941014-2.c ICEs with -fgraphite-identity

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45231

--- Comment #2 from Jack Howarth <howarth at nitro dot med.uc.edu> 2010-12-08 02:23:45 UTC ---
This issue doesn't seem to be present at r167573 with
http://gcc.gnu.org/ml/gcc-patches/2010-12/msg00629.html and

Index: opts.c
===================================================================
--- opts.c      (revision 167318)
+++ opts.c      (working copy)
@@ -462,6 +462,9 @@
     { OPT_LEVELS_1_PLUS, OPT_fcombine_stack_adjustments, NULL, 1 },

     /* -O2 optimizations.  */
+#ifdef HAVE_cloog
+    { OPT_LEVELS_2_PLUS, OPT_fgraphite_identity, NULL, 1 },
+#endif
     { OPT_LEVELS_2_PLUS, OPT_finline_small_functions, NULL, 1 },
     { OPT_LEVELS_2_PLUS, OPT_findirect_inlining, NULL, 1 },
     { OPT_LEVELS_2_PLUS, OPT_fpartial_inlining, NULL, 1 },

[Bug middle-end/45231] gcc.c-torture/compile/941014-2.c ICEs with -fgraphite-identity

[spop at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45231

Sebastian Pop <spop at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.12.08 06:29:51
         AssignedTo|unassigned at gcc dot       |spop at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #3 from Sebastian Pop <spop at gcc dot gnu.org> 2010-12-08 06:29:51 UTC ---
Mine.  Thanks Jack for letting me know that the posted patch
also fixes this one.  I added the testcase of this bug to the patch.

[Bug middle-end/45231] gcc.c-torture/compile/941014-2.c ICEs with -fgraphite-identity

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45231

--- Comment #4 from Jack Howarth <howarth at nitro dot med.uc.edu> 2010-12-08 14:07:15 UTC ---
(In reply to comment #3)
> Mine.  Thanks Jack for letting me know that the posted patch
> also fixes this one.  I added the testcase of this bug to the patch.

Yes. This patch resolves this PR on x86_64-apple-darwin10...

http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg00666.html

[Bug middle-end/45231] gcc.c-torture/compile/941014-2.c ICEs with -fgraphite-identity

[spop at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45231

--- Comment #5 from Sebastian Pop <spop at gcc dot gnu.org> 2010-12-08 23:01:46 UTC ---
Author: spop
Date: Wed Dec  8 23:01:40 2010
New Revision: 167609

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167609
Log:
Fix PR45230, PR45231, and PR45370: fold_stmt_inplace after replace_exp.

2010-12-08  Richard Guenther  <rguenther@suse.de>
        Sebastian Pop  <sebastian.pop@amd.com>

    PR tree-optimization/45230
    PR tree-optimization/45231
    PR tree-optimization/45370
    * sese.c (rename_uses): Returns a bool.  Call
    recompute_tree_invariant_for_addr_expr only on the RHS of a
    GIMPLE_ASSIGN.
    (graphite_copy_stmts_from_block): Call fold_stmt_inplace when
    rename_uses returns true.
    * tree-ssa-copy.c (replace_exp): Add a comment about calling
    fold_stmt_inplace after replace_exp.

    * gcc.dg/graphite/id-pr45230-1.c: New.
    * gcc.dg/graphite/id-pr45231.c: New.
    * gfortran.dg/graphite/id-pr45370.f90: New.

Added:
    trunk/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c
    trunk/gcc/testsuite/gcc.dg/graphite/id-pr45231.c
    trunk/gcc/testsuite/gfortran.dg/graphite/id-pr45370.f90
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/sese.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-copy.c

[Bug middle-end/45231] gcc.c-torture/compile/941014-2.c ICEs with -fgraphite-identity

[spop at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45231

Sebastian Pop <spop at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Sebastian Pop <spop at gcc dot gnu.org> 2010-12-08 23:04:22 UTC ---
Fixed.

[Bug middle-end/45231] gcc.c-torture/compile/941014-2.c ICEs with -fgraphite-identity

[zsojka at seznam dot cz]

------- Comment #1 from zsojka at seznam dot cz  2010-08-15 23:09 -------
Created an attachment (id=21485)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21485&action=view)
reduced testcase

Testcase crashes at x86_64-linux as well.
Valgrind output (r163261):

$ valgrind --trace-children=yes -q
/mnt/svn/gcc-trunk/binary-163261-lto-fortran-checking-yes-rtl-df/bin/gcc -O1
-funswitch-loops -fgraphite-identity testcase.c
==1230== Invalid read of size 1
==1230==    at 0x716434: gsi_for_stmt (gimple.h:245)
==1230==    by 0xF4404F: insert_out_of_ssa_copy (graphite-sese-to-poly.c:2130)
==1230==    by 0xF4486B: rewrite_phi_out_of_ssa (graphite-sese-to-poly.c:2328)
==1230==    by 0xF4A1C1: rewrite_reductions_out_of_ssa
(graphite-sese-to-poly.c:2403)
==1230==    by 0xF35A8C: graphite_transform_loops (graphite.c:290)
==1230==    by 0x984326: graphite_transforms (tree-ssa-loop.c:296)
==1230==    by 0x7BF13B: execute_one_pass (passes.c:1567)
==1230==    by 0x7BF3D4: execute_pass_list (passes.c:1622)
==1230==    by 0x7BF3E6: execute_pass_list (passes.c:1623)
==1230==    by 0x7BF3E6: execute_pass_list (passes.c:1623)
==1230==    by 0x7BF3E6: execute_pass_list (passes.c:1623)
==1230==    by 0x901335: tree_rest_of_compilation (tree-optimize.c:452)
==1230==  Address 0x61 is not stack'd, malloc'd or (recently) free'd
==1230== 
testcase.c: In function 'f':
testcase.c:2:1: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45231