[Bug tree-optimization/45241] New: CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[Bug tree-optimization/45241] New: CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[changpeng dot fang at amd dot com]

With gcc 4.6:
gfortran  -c -o diis.fppized.o -O3 -fno-tree-pre -march=amdfam10 -m64
diis.fppized.f90

diis.fppized.f90: In function 'extrapolate':
diis.fppized.f90:882:0: internal compiler error: vector VEC(vec_void_p,base)
index domain error, in vinfo_for_stmt at tree-vectorizer.h:595
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions

This is invoked in "vect_recog_dot_prod_pattern":
stmt_vinfo = vinfo_for_stmt (stmt);

Where "stmt" is not inside the loop, and thus stmt_vinfo was not set up.


-- 
           Summary: CPU2006 465.tonto ICE in the vectorizer with -fno-tree-
                    pre
           Product: gcc
           Version: tree-ssa
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: changpeng dot fang at amd dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[changpeng dot fang at amd dot com]

------- Comment #1 from changpeng dot fang at amd dot com  2010-08-09 17:52 -------
This patch should be a valid fix, because the recognition of the dot_prod
pattern is known to be fail at this point if the stmt is outside the loop.
(I am not sure whether we should not see this case in the vectorizer at this
point -- should previous analysis already filter out?):

diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c
index 19f0ae6..5f81a73 100644
--- a/gcc/tree-vect-patterns.c
+++ b/gcc/tree-vect-patterns.c
@@ -259,6 +259,10 @@ vect_recog_dot_prod_pattern (gimple last_stmt, tree
*type_in, tree *type_out)
      inside the loop (in case we are analyzing an outer-loop).  */
   if (!is_gimple_assign (stmt))
     return NULL;
+
+  if (!flow_bb_inside_loop_p (loop, gimple_bb (stmt)))
+    return NULL;
+
   stmt_vinfo = vinfo_for_stmt (stmt);
   gcc_assert (stmt_vinfo);
   if (STMT_VINFO_DEF_TYPE (stmt_vinfo) != vect_internal_def)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2010-08-10 08:58 -------
Can you attach a testcase please?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2010-08-10 08:58 -------
*** Bug 45239 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[irar at il dot ibm dot com]

------- Comment #4 from irar at il dot ibm dot com  2010-08-10 09:06 -------
I am testing the same patch as in comment #1.

Testcase that shows the problem:

int
foo(short x)
{
  short i, y;
  int sum;

  for (i = 0; i < x; i++)
    y = x * i;

  for (i = x; i > 0; i--)
    sum += y;

  return sum;
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[irar at il dot ibm dot com]

------- Comment #5 from irar at il dot ibm dot com  2010-08-10 10:23 -------
(In reply to comment #1)
> This patch should be a valid fix, because the recognition of the dot_prod
> pattern is known to be fail at this point if the stmt is outside the loop.
> (I am not sure whether we should not see this case in the vectorizer at this
> point -- should previous analysis already filter out?):
> 

I don't understand this. Where do we check if the stmt (which one?) is outside
the loop? 


> diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c
> index 19f0ae6..5f81a73 100644
> --- a/gcc/tree-vect-patterns.c
> +++ b/gcc/tree-vect-patterns.c
> @@ -259,6 +259,10 @@ vect_recog_dot_prod_pattern (gimple last_stmt, tree
> *type_in, tree *type_out)
>       inside the loop (in case we are analyzing an outer-loop).  */
>    if (!is_gimple_assign (stmt))
>      return NULL;
> +
> +  if (!flow_bb_inside_loop_p (loop, gimple_bb (stmt)))
> +    return NULL;
> +
>    stmt_vinfo = vinfo_for_stmt (stmt);
>    gcc_assert (stmt_vinfo);
>    if (STMT_VINFO_DEF_TYPE (stmt_vinfo) != vect_internal_def)
> 

I was looking at PR 45239 and didn't notice that there is another PR and didn't
see this comment. So I tested the same fix (successfully on x86_64-suse-linux).
You can commit it if you like (just please notice, that the bug exists on 4.5
as well). 

Thanks,
Ira


-- 

irar at il dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-08-10 10:24:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[dominiq at lps dot ens dot fr]

------- Comment #6 from dominiq at lps dot ens dot fr  2010-08-10 12:04 -------
This is a [4.5/4.6 Regression]: the test in comment #4 compiles with gcc
version 4.4.4 (GCC).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] [4.5/4.6 Regression] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[changpeng dot fang at amd dot com]

------- Comment #7 from changpeng dot fang at amd dot com  2010-08-10 21:44 -------
(In reply to comment #5)
> (In reply to comment #1)
> > This patch should be a valid fix, because the recognition of the dot_prod
> > pattern is known to be fail at this point if the stmt is outside the loop.
> > (I am not sure whether we should not see this case in the vectorizer at this
> > point -- should previous analysis already filter out?):
> > 
> 
> I don't understand this. Where do we check if the stmt (which one?) is outside
> the loop? 

Forget about this part of the comment (The vectorization analysis is correct,
and it is just that the pattern recognition traces the chain outside the loop). 

> I was looking at PR 45239 and didn't notice that there is another PR and didn't
> see this comment. So I tested the same fix (successfully on x86_64-suse-linux).
> You can commit it if you like (just please notice, that the bug exists on 4.5
> as well). 
> 

I am going to add your testcase (in comment #4), and doing bootstraping, and
then commit to the trunk and gcc 4.5 branch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] [4.5/4.6 Regression] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] [4.5/4.6 Regression] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2010-08-30 15:54 -------
ISTR a review of a patch?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] [4.5/4.6 Regression] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[changpeng dot fang at amd dot com]

------- Comment #9 from changpeng dot fang at amd dot com  2010-08-30 16:37 -------
Review approval for the trunk:
http://gcc.gnu.org/ml/gcc-patches/2010-08/msg00931.html

Review Approval for 4.5 branch:
http://gcc.gnu.org/ml/gcc-patches/2010-08/msg02112.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] [4.5/4.6 Regression] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[changpeng dot fang at amd dot com]

------- Comment #10 from changpeng dot fang at amd dot com  2010-08-30 16:39 -------
r163207 - in /trunk/gcc: ChangeLog testsuite/Ch...

    * From: cfang at gcc dot gnu dot org
    * To: gcc-cvs at gcc dot gnu dot org
    * Date: Thu, 12 Aug 2010 22:18:34 -0000
    * Subject: r163207 - in /trunk/gcc: ChangeLog testsuite/Ch...

Author: cfang
Date: Thu Aug 12 22:18:32 2010
New Revision: 163207

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=163207
Log:
pr45241 give up dot_prod pattern searching if stmt is outside the loop.

        * tree-vect-patterns.c (vect_recog_dot_prod_pattern): Give
        up dot_prod pattern searching if a stmt is outside the loop.

        * gcc.dg/vect/no-tree-pre-pr45241.c: New.

Added:
    trunk/gcc/testsuite/gcc.dg/vect/no-tree-pre-pr45241.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-vect-patterns.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] [4.5/4.6 Regression] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[changpeng dot fang at amd dot com]

------- Comment #11 from changpeng dot fang at amd dot com  2010-08-30 16:40 -------
r163286 - in /branches/gcc-4_5-branch/gcc: Chan...

    * From: cfang at gcc dot gnu dot org
    * To: gcc-cvs at gcc dot gnu dot org
    * Date: Mon, 16 Aug 2010 21:02:30 -0000
    * Subject: r163286 - in /branches/gcc-4_5-branch/gcc: Chan...

Author: cfang
Date: Mon Aug 16 21:02:29 2010
New Revision: 163286

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=163286
Log:
pr45241 give up dot_prod pattern searching if stmt is outside the loop.

        * tree-vect-patterns.c (vect_recog_dot_prod_pattern): Give
        up dot_prod pattern searching if a stmt is outside the loop.

        * gcc.dg/vect/no-tree-pre-pr45241.c: New.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/vect/no-tree-pre-pr45241.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/gcc/tree-vect-patterns.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241

[Bug tree-optimization/45241] [4.5/4.6 Regression] CPU2006 465.tonto ICE in the vectorizer with -fno-tree-pre

[changpeng dot fang at amd dot com]

------- Comment #12 from changpeng dot fang at amd dot com  2010-08-30 16:41 -------
Fixed!


-- 

changpeng dot fang at amd dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45241