[Bug c/45261] New: Doesn't indicate failure status when it doesn't support (attiny2313A)

[Bug c/45261] New: Doesn't indicate failure status when it doesn't support (attiny2313A)

[rootolini at gmail dot com]

When configuration script of avr-libc tries to check if gcc has support for
Attiny2313A it doesn't indicate any failure even if it really doesn't support
it. I found about that trying to build avr toolchain using this version of gcc.

Here is a part of config.log:

configure:5374: checking if avr-gcc has support for attiny2313a
configure:5390: avr-gcc -c -mmcu=attiny2313a  conftest.c >&5
unknown MCU 'attiny2313a' specified 
...
configure:5397: $? = 0
configure:5416: result: yes (which should indicate NO)

this bug doesn't allow to build avr-libc-1.7.0 because it doesn't let 'make' to
build the code.


-- 
           Summary: Doesn't indicate failure status when it doesn't support
                    (attiny2313A)
           Product: gcc
           Version: 4.5.1
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rootolini at gmail dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: avr
GCC target triplet: avr


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2010-08-11 22:54 -------
      fprintf (stderr, "unknown MCU '%s' specified\nKnown MCU names:\n",
               avr_mcu_name);

That should most likely be an error instead of just a fprintf.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-08-11 22:54:49
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[rootolini at gmail dot com]

------- Comment #2 from rootolini at gmail dot com  2010-08-11 23:17 -------
(In reply to comment #1)
>       fprintf (stderr, "unknown MCU '%s' specified\nKnown MCU names:\n",
>                avr_mcu_name);
> 
> That should most likely be an error instead of just a fprintf.
> 

You're right, the fprintf function should be correct. Moreover, no only the
attiny2313A is indicated as "result: yes" and is not supported.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2010-08-11 23:20 -------
(In reply to comment #2)
> You're right, the fprintf function should be correct. Moreover, no only the
> attiny2313A is indicated as "result: yes" and is not supported.

What I am trying to say that fprintf function call should be a call to error
which causes the return value of the compiler to change to be 1 instead 0.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[j at uriah dot heep dot sax dot de]

------- Comment #4 from j at uriah dot heep dot sax dot de  2010-08-12 09:54 -------
(In replay to comment #1)
> That should most likely be an error instead of just a fprintf.

Agreed.  What surprises me a bit that I've been under the impression
this used to work in previous releases:

[part of avr-libc's config.log]
  configure:6074: checking if avr-gcc has support for attiny461a
  configure:6090: avr-gcc -c -mmcu=attiny461a  conftest.c >&5
  Known MCU names:
    avr1 avr2 avr25 avr3 avr31 avr35 avr4 avr5 avr51 avr6 avrxmega1
  [...]
  Assembler messages:
  Fatal error: unknown MCU: attiny461a

  configure:6097: $? = 1
  configure: failed program was:
  | /* confdefs.h.  */
  | #define PACKAGE_NAME "avr-libc"
  | #define PACKAGE_TARNAME "avr-libc"
  | #define PACKAGE_VERSION "1.6.8"
  | #define PACKAGE_STRING "avr-libc 1.6.8"
  | #define PACKAGE_BUGREPORT "avr-libc-dev@nongnu.org"
  | #define PACKAGE "avr-libc"
  | #define VERSION "1.6.8"
  | /* end confdefs.h.  */
  | 
  configure:6116: result: no
[/config.log]

However, if I parse these messages correctly, GCC probably never
really rejected the unknown -mmcu option, instead it has only
incidentally been rejected because in turn, the assembler eventually
cmoplained.

I agree that it should already be the compiler's business to cause an
error exit status (by turning the fprintf() into an error()).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261