[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[ian.rees at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

--- Comment #5 from Ian Rees <ian.rees at gmail dot com> 2010-11-22 04:57:57 UTC ---
Created attachment 22480
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22480
Simple fix for bug #45621

Simple patch against gcc-4.5.1 - just adds a call to Error(), which is more
appropriate than the current implementation.

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[ian.rees at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Ian Rees <ian.rees at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian.rees at gmail dot com

--- Comment #6 from Ian Rees <ian.rees at gmail dot com> 2010-11-22 05:00:05 UTC ---
Here's a patch to implement change suggested above - added call to error().  I
left in the existing fprintf() thinking that the list of supported MCUs is
useful.

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[j at uriah dot heep.sax.de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Joerg Wunsch <j at uriah dot heep.sax.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j at uriah dot heep.sax.de

--- Comment #7 from Joerg Wunsch <j at uriah dot heep.sax.de> 2010-11-22 10:23:53 UTC ---
(In reply to comment #6)
> Here's a patch to implement change suggested above - added call to error().  I
> left in the existing fprintf() thinking that the list of supported MCUs is
> useful.

I think just replacing the fprintf() by error() is fine.  If anyone wants
to know the list of supported MCUs, they can always use the --target-help
option.

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[ian.rees at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Ian Rees <ian.rees at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22480|0                           |1
        is obsolete|                            |

--- Comment #8 from Ian Rees <ian.rees at gmail dot com> 2010-11-22 16:19:44 UTC ---
Created attachment 22484
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22484
Updated fix for bug #45261 - error() rather than fprintf(), and suggests
--target-help instead of printing supported MCUs

(In reply to comment #7)
>(In reply to comment #6)
>> Here's a patch to implement change suggested above - added call to error().  I
>> left in the existing fprintf() thinking that the list of supported MCUs is
>> useful.
>
>I think just replacing the fprintf() by error() is fine.  If anyone wants
>to know the list of supported MCUs, they can always use the --target-help
>option.

Good point - I wasn't familiar with --target-help, so this one just suggests
using --target-help and errors out.  Thanks!  -Ian-

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[atstivalet at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

ats <atstivalet at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |atstivalet at gmail dot com

--- Comment #9 from ats <atstivalet at gmail dot com> 2010-12-15 06:21:55 UTC ---
I can confirm Ian's patch works. Thanks guys.

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[guanx.bac at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Guan Xin <guanx.bac at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guanx.bac at gmail dot com

--- Comment #10 from Guan Xin <guanx.bac at gmail dot com> 2010-12-20 09:18:26 UTC ---
request to add version 4.5.2

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |choudary.omar at gmail dot
                   |                            |com

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-01-20 20:11:48 UTC ---
*** Bug 47384 has been marked as a duplicate of this bug. ***

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

--- Comment #12 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-01-20 20:16:11 UTC ---
*** Bug 47384 has been marked as a duplicate of this bug. ***

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[choudary.omar at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

--- Comment #13 from Omar Choudary <choudary.omar at gmail dot com> 2011-01-20 20:20:31 UTC ---
Created attachment 23050
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23050
Patch for gcc version 4.5.2 since the original patch only works for 4.5.1

This patch should be used for gcc version 4.5.2, since the original file will
try to patch version 4.5.1.

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[lars at ibp dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Lars Immisch <lars at ibp dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lars at ibp dot de

--- Comment #14 from Lars Immisch <lars at ibp dot de> 2011-01-24 23:05:36 UTC ---
I can confirm that the patch works as described and I'd really like to see it
in the next version of gcc. 

I am using the patch in a patch for MacPorts avr-gcc, see MacPorts ticket
17524: http://trac.macports.org/ticket/17524

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[brawrf at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

--- Comment #15 from brawrf at gmail dot com 2011-02-26 18:32:29 UTC ---
I can confirm the patch for GCC 4.5.2 works as expected and that I have
compiled several programs with it.

Please merge this into GCC.

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[denisc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

--- Comment #16 from denisc at gcc dot gnu.org 2011-02-27 12:23:22 UTC ---
Author: denisc
Date: Sun Feb 27 12:23:14 2011
New Revision: 170536

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170536
Log:
2011-02-23  Georg-Johann Lay  <avr@gjlay.de>

    PR target/45261
    * config/avr/avr.c (avr_option_override): Use error on bad options.
    (avr_help): New function.
    (TARGET_HELP): Define.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/avr/avr.c

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[denisc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

--- Comment #17 from denisc at gcc dot gnu.org 2011-02-28 17:13:16 UTC ---
Author: denisc
Date: Mon Feb 28 17:13:13 2011
New Revision: 170569

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170569
Log:
2011-02-28  Georg-Johann Lay  <avr@gjlay.de>

       PR target/45261
       * config/avr/avr.c (avr_option_override): Use error on bad options.
       (avr_help): New function.
       (TARGET_HELP): Define.



Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/config/avr/avr.c

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |gjl at gcc dot gnu.org
      Known to work|                            |4.5.3, 4.6.0, 4.7.0
         Resolution|                            |FIXED
      Known to fail|                            |4.5.2

--- Comment #18 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-04-14 15:21:25 UTC ---
Closing as resolved+fixed in 4.5.3, 4.6.0, 4.7.0

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[j at uriah dot heep dot sax dot de]

------- Comment #4 from j at uriah dot heep dot sax dot de  2010-08-12 09:54 -------
(In replay to comment #1)
> That should most likely be an error instead of just a fprintf.

Agreed.  What surprises me a bit that I've been under the impression
this used to work in previous releases:

[part of avr-libc's config.log]
  configure:6074: checking if avr-gcc has support for attiny461a
  configure:6090: avr-gcc -c -mmcu=attiny461a  conftest.c >&5
  Known MCU names:
    avr1 avr2 avr25 avr3 avr31 avr35 avr4 avr5 avr51 avr6 avrxmega1
  [...]
  Assembler messages:
  Fatal error: unknown MCU: attiny461a

  configure:6097: $? = 1
  configure: failed program was:
  | /* confdefs.h.  */
  | #define PACKAGE_NAME "avr-libc"
  | #define PACKAGE_TARNAME "avr-libc"
  | #define PACKAGE_VERSION "1.6.8"
  | #define PACKAGE_STRING "avr-libc 1.6.8"
  | #define PACKAGE_BUGREPORT "avr-libc-dev@nongnu.org"
  | #define PACKAGE "avr-libc"
  | #define VERSION "1.6.8"
  | /* end confdefs.h.  */
  | 
  configure:6116: result: no
[/config.log]

However, if I parse these messages correctly, GCC probably never
really rejected the unknown -mmcu option, instead it has only
incidentally been rejected because in turn, the assembler eventually
cmoplained.

I agree that it should already be the compiler's business to cause an
error exit status (by turning the fprintf() into an error()).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2010-08-11 23:20 -------
(In reply to comment #2)
> You're right, the fprintf function should be correct. Moreover, no only the
> attiny2313A is indicated as "result: yes" and is not supported.

What I am trying to say that fprintf function call should be a call to error
which causes the return value of the compiler to change to be 1 instead 0.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[rootolini at gmail dot com]

------- Comment #2 from rootolini at gmail dot com  2010-08-11 23:17 -------
(In reply to comment #1)
>       fprintf (stderr, "unknown MCU '%s' specified\nKnown MCU names:\n",
>                avr_mcu_name);
> 
> That should most likely be an error instead of just a fprintf.
> 

You're right, the fprintf function should be correct. Moreover, no only the
attiny2313A is indicated as "result: yes" and is not supported.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261

[Bug target/45261] Doesn't indicate failure status when it doesn't support (attiny2313A)

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2010-08-11 22:54 -------
      fprintf (stderr, "unknown MCU '%s' specified\nKnown MCU names:\n",
               avr_mcu_name);

That should most likely be an error instead of just a fprintf.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-08-11 22:54:49
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45261