public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
@ 2010-11-05 12:29 ` jakub at gcc dot gnu.org
2010-11-05 15:30 ` bero at arklinux dot org
` (8 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: jakub at gcc dot gnu.org @ 2010-11-05 12:29 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
Known to fail| |
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-05 12:28:58 UTC ---
Can't reproduce with current trunk,
./cc1plus -m32 -O2 pr45314.ii -quiet -floop-interchange
is fine.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
2010-11-05 12:29 ` [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange jakub at gcc dot gnu.org
@ 2010-11-05 15:30 ` bero at arklinux dot org
2010-11-05 16:26 ` hjl.tools at gmail dot com
` (7 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: bero at arklinux dot org @ 2010-11-05 15:30 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
--- Comment #5 from bero at arklinux dot org 2010-11-05 15:30:20 UTC ---
Still happens on current 4.5 branch
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
2010-11-05 12:29 ` [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange jakub at gcc dot gnu.org
2010-11-05 15:30 ` bero at arklinux dot org
@ 2010-11-05 16:26 ` hjl.tools at gmail dot com
2010-11-05 16:51 ` Sebastian Pop
2010-11-05 16:51 ` sebpop at gmail dot com
` (6 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: hjl.tools at gmail dot com @ 2010-11-05 16:26 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-05 16:26:44 UTC ---
On trunk, it was fixed by revision 163123:
http://gcc.gnu.org/ml/gcc-cvs/2010-08/msg00334.html
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2010-11-05 16:26 ` hjl.tools at gmail dot com
@ 2010-11-05 16:51 ` sebpop at gmail dot com
2010-11-05 17:17 ` [Bug tree-optimization/45314] [4.5 " spop at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: sebpop at gmail dot com @ 2010-11-05 16:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
--- Comment #7 from sebpop at gmail dot com <sebpop at gmail dot com> 2010-11-05 16:51:22 UTC ---
On Fri, Nov 5, 2010 at 11:26, hjl.tools at gmail dot com
<gcc-bugzilla@gcc.gnu.org> wrote:
> On trunk, it was fixed by revision 163123:
>
> http://gcc.gnu.org/ml/gcc-cvs/2010-08/msg00334.html
>
Thanks HJ for reducing this.
I looked at this change and it looks simple enough to backport it to 4.5.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
2010-11-05 16:26 ` hjl.tools at gmail dot com
@ 2010-11-05 16:51 ` Sebastian Pop
0 siblings, 0 replies; 15+ messages in thread
From: Sebastian Pop @ 2010-11-05 16:51 UTC (permalink / raw)
To: hjl.tools at gmail dot com; +Cc: gcc-bugs
On Fri, Nov 5, 2010 at 11:26, hjl.tools at gmail dot com
<gcc-bugzilla@gcc.gnu.org> wrote:
> On trunk, it was fixed by revision 163123:
>
> http://gcc.gnu.org/ml/gcc-cvs/2010-08/msg00334.html
>
Thanks HJ for reducing this.
I looked at this change and it looks simple enough to backport it to 4.5.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2010-11-05 16:51 ` sebpop at gmail dot com
@ 2010-11-05 17:17 ` spop at gcc dot gnu.org
2010-11-05 18:05 ` hjl.tools at gmail dot com
` (4 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: spop at gcc dot gnu.org @ 2010-11-05 17:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
Sebastian Pop <spop at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Known to work| |4.6.0
AssignedTo|unassigned at gcc dot |spop at gcc dot gnu.org
|gnu.org |
Summary|[4.5/4.6 Regression] ICE: |[4.5 Regression] ICE:
|error: in |error: in
|remove_unreachable_handlers |remove_unreachable_handlers
|, at tree-sh.c:3294 with |, at tree-sh.c:3294 with
|-O2 -floop-interchange |-O2 -floop-interchange
Known to fail|4.6.0 |
--- Comment #8 from Sebastian Pop <spop at gcc dot gnu.org> 2010-11-05 17:16:48 UTC ---
Mine.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2010-11-05 17:17 ` [Bug tree-optimization/45314] [4.5 " spop at gcc dot gnu.org
@ 2010-11-05 18:05 ` hjl.tools at gmail dot com
2010-11-05 18:16 ` Sebastian Pop
2010-11-05 18:17 ` sebpop at gmail dot com
` (3 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: hjl.tools at gmail dot com @ 2010-11-05 18:05 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
--- Comment #9 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-05 18:04:46 UTC ---
Just for the record, this is introduced by revision 155739:
http://gcc.gnu.org/ml/gcc-cvs/2010-01/msg00200.html
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Bug tree-optimization/45314] [4.5 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
2010-11-05 18:05 ` hjl.tools at gmail dot com
@ 2010-11-05 18:16 ` Sebastian Pop
0 siblings, 0 replies; 15+ messages in thread
From: Sebastian Pop @ 2010-11-05 18:16 UTC (permalink / raw)
To: hjl.tools at gmail dot com; +Cc: gcc-bugs
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
Here is the backported patch that fixes the ICE.
I will further test this and will post to gcc-patches.
Sebastian
[-- Attachment #2: 0001-Fix-PR45314-backport-revision-163123.patch --]
[-- Type: text/x-patch, Size: 2478 bytes --]
From 8f0cc975c09d2e0779f7e25a82a295f3deb9de46 Mon Sep 17 00:00:00 2001
From: Sebastian Pop <sebpop@gmail.com>
Date: Fri, 5 Nov 2010 13:15:25 -0500
Subject: [PATCH] Fix PR45314: backport revision 163123.
---
gcc/graphite-sese-to-poly.c | 56 ++++--------------------------------------
1 files changed, 6 insertions(+), 50 deletions(-)
diff --git a/gcc/graphite-sese-to-poly.c b/gcc/graphite-sese-to-poly.c
index d4bb8a3..b12210b 100644
--- a/gcc/graphite-sese-to-poly.c
+++ b/gcc/graphite-sese-to-poly.c
@@ -2231,58 +2231,14 @@ rewrite_phi_out_of_ssa (gimple_stmt_iterator *psi)
for (i = 0; i < gimple_phi_num_args (phi); i++)
{
tree arg = gimple_phi_arg_def (phi, i);
+ edge e = gimple_phi_arg_edge (phi, i);
- /* Try to avoid the insertion on edges as much as possible: this
- would avoid the insertion of code on loop latch edges, making
- the pattern matching of the vectorizer happy, or it would
- avoid the insertion of useless basic blocks. Note that it is
- incorrect to insert out of SSA copies close by their
- definition when they are more than two loop levels apart:
- for example, starting from a double nested loop
-
- | a = ...
- | loop_1
- | loop_2
- | b = phi (a, c)
- | c = ...
- | end_2
- | end_1
-
- the following transform is incorrect
-
- | a = ...
- | Red[0] = a
- | loop_1
- | loop_2
- | b = Red[0]
- | c = ...
- | Red[0] = c
- | end_2
- | end_1
-
- whereas inserting the copy on the incoming edge is correct
-
- | a = ...
- | loop_1
- | Red[0] = a
- | loop_2
- | b = Red[0]
- | c = ...
- | Red[0] = c
- | end_2
- | end_1
- */
- if (TREE_CODE (arg) == SSA_NAME
- && is_gimple_reg (arg)
- && gimple_bb (SSA_NAME_DEF_STMT (arg))
- && (flow_bb_inside_loop_p (bb->loop_father,
- gimple_bb (SSA_NAME_DEF_STMT (arg)))
- || flow_bb_inside_loop_p (loop_outer (bb->loop_father),
- gimple_bb (SSA_NAME_DEF_STMT (arg)))))
- insert_out_of_ssa_copy (zero_dim_array, arg);
+ /* Avoid the insertion of code in the loop latch to please the
+ pattern matching of the vectorizer. */
+ if (e->src == bb->loop_father->latch)
+ insert_out_of_ssa_copy (zero_dim_array, arg);
else
- insert_out_of_ssa_copy_on_edge (gimple_phi_arg_edge (phi, i),
- zero_dim_array, arg);
+ insert_out_of_ssa_copy_on_edge (e, zero_dim_array, arg);
}
var = force_gimple_operand (zero_dim_array, &stmts, true, NULL_TREE);
--
1.7.0.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2010-11-05 18:05 ` hjl.tools at gmail dot com
@ 2010-11-05 18:17 ` sebpop at gmail dot com
2010-11-09 19:15 ` spop at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: sebpop at gmail dot com @ 2010-11-05 18:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
--- Comment #10 from sebpop at gmail dot com <sebpop at gmail dot com> 2010-11-05 18:17:01 UTC ---
Here is the backported patch that fixes the ICE.
I will further test this and will post to gcc-patches.
Sebastian
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2010-11-05 18:17 ` sebpop at gmail dot com
@ 2010-11-09 19:15 ` spop at gcc dot gnu.org
2010-11-09 19:15 ` spop at gcc dot gnu.org
2010-11-09 19:16 ` spop at gcc dot gnu.org
9 siblings, 0 replies; 15+ messages in thread
From: spop at gcc dot gnu.org @ 2010-11-09 19:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
--- Comment #11 from Sebastian Pop <spop at gcc dot gnu.org> 2010-11-09 19:15:19 UTC ---
The patch fixing this has been committed with the wrong PR number on:
Author: spop
Date: Tue Nov 9 19:08:57 2010
New Revision: 166506
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166506
Log:
Fix PR45314: backport revision 163123.
2010-11-09 Sebastian Pop <sebastian.pop@amd.com>
PR tree-optimization/45902
Backport of revision 163132.
* graphite-sese-to-poly.c (rewrite_phi_out_of_ssa): Always insert out
of SSA copies on edges except for loop->latch.
Modified:
branches/gcc-4_5-branch/gcc/ChangeLog
branches/gcc-4_5-branch/gcc/graphite-sese-to-poly.c
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2010-11-09 19:15 ` spop at gcc dot gnu.org
@ 2010-11-09 19:15 ` spop at gcc dot gnu.org
2010-11-09 19:16 ` spop at gcc dot gnu.org
9 siblings, 0 replies; 15+ messages in thread
From: spop at gcc dot gnu.org @ 2010-11-09 19:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
--- Comment #12 from Sebastian Pop <spop at gcc dot gnu.org> 2010-11-09 19:15:39 UTC ---
Author: spop
Date: Tue Nov 9 19:15:36 2010
New Revision: 166507
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166507
Log:
Fix Changelog entry.
2010-11-09 Sebastian Pop <sebastian.pop@amd.com>
PR tree-optimization/45314
Backport of revision 163132.
* graphite-sese-to-poly.c (rewrite_phi_out_of_ssa): Always insert out
of SSA copies on edges except for loop->latch.
Modified:
branches/gcc-4_5-branch/gcc/ChangeLog
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2010-11-09 19:15 ` spop at gcc dot gnu.org
@ 2010-11-09 19:16 ` spop at gcc dot gnu.org
9 siblings, 0 replies; 15+ messages in thread
From: spop at gcc dot gnu.org @ 2010-11-09 19:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
Sebastian Pop <spop at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #13 from Sebastian Pop <spop at gcc dot gnu.org> 2010-11-09 19:16:37 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
2010-08-17 22:24 [Bug middle-end/45314] New: " bero at arklinux dot org
2010-08-18 9:16 ` [Bug tree-optimization/45314] [4.5/4.6 Regression] " rguenth at gcc dot gnu dot org
2010-08-30 15:58 ` rguenth at gcc dot gnu dot org
@ 2010-08-31 18:49 ` bero at arklinux dot org
2 siblings, 0 replies; 15+ messages in thread
From: bero at arklinux dot org @ 2010-08-31 18:49 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from bero at arklinux dot org 2010-08-31 18:48 -------
Created an attachment (id=21611)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21611&action=view)
(fairly stupid) Workaround
Attaching workaround for people coming across this bug report when googling the
error message.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
2010-08-17 22:24 [Bug middle-end/45314] New: " bero at arklinux dot org
2010-08-18 9:16 ` [Bug tree-optimization/45314] [4.5/4.6 Regression] " rguenth at gcc dot gnu dot org
@ 2010-08-30 15:58 ` rguenth at gcc dot gnu dot org
2010-08-31 18:49 ` bero at arklinux dot org
2 siblings, 0 replies; 15+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2010-08-30 15:58 UTC (permalink / raw)
To: gcc-bugs
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange
2010-08-17 22:24 [Bug middle-end/45314] New: " bero at arklinux dot org
@ 2010-08-18 9:16 ` rguenth at gcc dot gnu dot org
2010-08-30 15:58 ` rguenth at gcc dot gnu dot org
2010-08-31 18:49 ` bero at arklinux dot org
2 siblings, 0 replies; 15+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2010-08-18 9:16 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from rguenth at gcc dot gnu dot org 2010-08-18 09:16 -------
With 4.5.1 I get (checking enabled)
VM.cpp: In member function 'gnash::VM::RNG& gnash::VM::randomNumberGenerator()
const':
VM.cpp:126:1: error: statement marked for throw in middle of block
# .MEM_19 = VDEF <.MEM_18>
D.294844_12 = OBJ_TYPE_REF(D.294843_10;D.294841_8->0) (D.294841_8);
VM.cpp:126:1: internal compiler error: verify_stmts failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
and with trunk I get
VM.cpp: In member function 'gnash::VM::RNG& gnash::VM::randomNumberGenerator()
const':
VM.cpp:126:1: internal compiler error: in create_linear_expr_from_tree, at
graphite-sese-to-poly.c:1207
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
4.4.4 works.
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |spop at gcc dot gnu dot org
Status|UNCONFIRMED |NEW
Component|middle-end |tree-optimization
Ever Confirmed|0 |1
Keywords| |ice-on-valid-code
Known to fail| |4.5.1 4.6.0
Known to work| |4.4.4
Last reconfirmed|0000-00-00 00:00:00 |2010-08-18 09:16:16
date| |
Summary|ICE: error: in |[4.5/4.6 Regression] ICE:
|remove_unreachable_handlers,|error: in
|at tree-sh.c:3294 with -O2 -|remove_unreachable_handlers,
|floop-interchange |at tree-sh.c:3294 with -O2 -
| |floop-interchange
Target Milestone|--- |4.5.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45314
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2010-11-09 19:16 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-45314-4@http.gcc.gnu.org/bugzilla/>
2010-11-05 12:29 ` [Bug tree-optimization/45314] [4.5/4.6 Regression] ICE: error: in remove_unreachable_handlers, at tree-sh.c:3294 with -O2 -floop-interchange jakub at gcc dot gnu.org
2010-11-05 15:30 ` bero at arklinux dot org
2010-11-05 16:26 ` hjl.tools at gmail dot com
2010-11-05 16:51 ` Sebastian Pop
2010-11-05 16:51 ` sebpop at gmail dot com
2010-11-05 17:17 ` [Bug tree-optimization/45314] [4.5 " spop at gcc dot gnu.org
2010-11-05 18:05 ` hjl.tools at gmail dot com
2010-11-05 18:16 ` Sebastian Pop
2010-11-05 18:17 ` sebpop at gmail dot com
2010-11-09 19:15 ` spop at gcc dot gnu.org
2010-11-09 19:15 ` spop at gcc dot gnu.org
2010-11-09 19:16 ` spop at gcc dot gnu.org
2010-08-17 22:24 [Bug middle-end/45314] New: " bero at arklinux dot org
2010-08-18 9:16 ` [Bug tree-optimization/45314] [4.5/4.6 Regression] " rguenth at gcc dot gnu dot org
2010-08-30 15:58 ` rguenth at gcc dot gnu dot org
2010-08-31 18:49 ` bero at arklinux dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).