[Bug c++/45385] missing -Wconversion for method calls

[Bug c++/45385] missing -Wconversion for method calls

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45385

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|gcc-bugs at gcc dot         |lopezibanez at gmail dot
                   |gnu.org, mendola at gmail   |com
                   |dot com                     |

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-10-20 01:25:23 UTC ---
Manuel, I seem to remember you did some work in this area?!?

[Bug c++/45385] missing -Wconversion for method calls

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45385

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #3 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2011-10-20 08:19:05 UTC ---
There is a check in c-common.c:conversion_warning that tests for things
generated by the compiler by looking for artificial operands. The implicit
*this pointer is probably triggering here. One could test for *this or perhaps
there is a better way to check for compiler-generated expressions (if you
remove the check, you should trigger a regression in the testsuite).

[Bug c++/45385] missing -Wconversion for method calls

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45385

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-10-20 08:27:38 UTC ---
Thanks a lot. If I understand correctly this is a regression affecting a very
sensible warning which we want to fix for 4.7, at least. We should mark it as
such.

[Bug c++/45385] [4.4/4.5/4.6/4.7 Regression] missing -Wconversion for method calls

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45385

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|lopezibanez at gmail dot    |
                   |com, paolo.carlini at       |
                   |oracle dot com              |
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com

[Bug c++/45385] [4.4/4.5/4.6/4.7 Regression] missing -Wconversion for method calls

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45385

--- Comment #5 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-10-21 20:01:34 UTC ---
Author: paolo
Date: Fri Oct 21 20:01:31 2011
New Revision: 180312

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=180312
Log:
/cp
2011-10-21  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/45385
    * init.c (build_vec_init): Early return error_mark_node if
    maxindex is -1.

/c-family
2011-10-21  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/45385
    * c-common.c (conversion_warning): Remove code looking for
    artificial operands.

/testsuite
2011-10-21  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/45385
    * g++.dg/warn/Wconversion4.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/warn/Wconversion4.C
Modified:
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-common.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/init.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/45385] [4.4/4.5/4.6 Regression] missing -Wconversion for method calls

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45385

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.4/4.5/4.6/4.7            |[4.4/4.5/4.6 Regression]
                   |Regression] missing         |missing -Wconversion for
                   |-Wconversion for method     |method calls
                   |calls                       |

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-10-21 20:02:53 UTC ---
Fixed for 4.7.0 so far.

[Bug c++/45385] [4.4/4.5/4.6 Regression] missing -Wconversion for method calls

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45385

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-13 16:36:53 UTC ---
Fixed for 4.7.0.