[Bug plugins/45787] New: r164531 breaks plugin support on x86_64-apple-darwin10

[Bug plugins/45787] New: r164531 breaks plugin support on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45787

           Summary: r164531 breaks plugin support on x86_64-apple-darwin10
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: plugins
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: howarth@nitro.med.uc.edu
              Host: x86_64-apple-darwin10
            Target: x86_64-apple-darwin10
             Build: x86_64-apple-darwin10


Author: jsm28
Date: Wed Sep 22 20:12:06 2010
New Revision: 164531

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164531
Log:
    * common.opt (-assemble, -compile, -coverage, -debug, -dump,
    -dump=, -dumpbase, -dumpdir, -entry, -entry=, -extra-warnings,
    -for-assembler, -for-assembler=, -for-linker, -for-linker=,
    -force-link, -force-link=, -language, -language=,
    -library-directory, -library-directory=, -no-canonical-prefixes,
    -no-standard-libraries, -no-warnings, -optimize, -output,
    -output=, -pass-exit-codes, -pedantic, -pedantic-errors, -pie,
    -pipe, -prefix, -prefix=, -preprocess, -print-file-name,
    -print-file-name=, -print-libgcc-file-name,
    -print-multi-directory, -print-multi-lib,
    -print-multi-os-directory, -print-prog-name, -print-prog-name=,
    -print-search-dirs, -print-sysroot, -print-sysroot-headers-suffix,
    -profile, -save-temps, -shared, -specs, -specs=, -static,
    -symbolic, -time, -verbose, -param=, -sysroot, coverage, e, u,
    symbolic): New.
    (fhelp, fhelp=, ftarget-help, fversion): Make into aliases.
    * gcc.c (A Short Introduction to Adding a Command-Line Option):
    Remove comment.
    (cc1_options): Correct specs for passing down --help,
    --target-help and --help=*.  Add spec for passing down --version.
    (struct option_map, option_map, target_option_translations,
    translate_options): Remove.
    (driver_handle_option): Handle OPT__version, OPT__help, OPT__help_
    and OPT__target_help instead of OPT_fversion, OPT_fhelp,
    OPT_fhelp_ and OPT_ftarget_help.
    (process_command): Don't call translate_options.  Call
    decode_cmdline_options_to_array before checking for
    -no-canonical-prefixes using decoded options.
    * opts-common.c (tm.h): Update comment on #include.
    (find_opt): Allow abbreviations of long options.
    (struct option_map, option_map): New.
    (decode_cmdline_option): Use them instead of hardcoding -Wno, -fno
    and -mno handling.
    (target_option_translations): New.
    (decode_cmdline_options_to_array): Handle
    TARGET_OPTION_TRANSLATE_TABLE in driver.
    * opts.c (common_handle_option): Don't handle OPT_fhelp,
    OPT_ftarget_help, OPT_fhelp_ or OPT_fversion.

ada:
    * gcc-interface/lang.opt (-all-warnings, -include-barrier,
    -include-directory, -include-directory=, -no-standard-includes,
    -no-standard-libraries): New.

c-family:
    * c.opt (-all-warnings, -ansi, -assert, -assert=, -comments,
    -comments-in-macros, -define-macro, -define-macro=, -dependencies,
    -dump, -dump=, -imacros, -imacros=, -include, -include=,
    -include-barrier, -include-directory, -include-directory=,
    -include-directory-after, -include-directory-after=,
    -include-prefix, -include-prefix=, -include-with-prefix,
    -include-with-prefix=, -include-with-prefix-after,
    -include-with-prefix-after=, -include-with-prefix-before,
    -include-with-prefix-before=, -no-integrated-cpp,
    -no-line-commands, -no-standard-includes, -no-warnings, -output,
    -output=, -pedantic, -pedantic-errors, -preprocess,
    -print-missing-file-dependencies, -trace-includes, -traditional,
    -traditional-cpp, -trigraphs, -undefine-macro, -undefine-macro=,
    -user-dependencies, -verbose, -write-dependencies,
    -write-user-dependencies, no-integrated-cpp, traditional): New.

fortran:
    * gfortranspec.c (lang_specific_driver): Handle OPT__version and
    OPT__help instead of OPT_fversion and OPT_fhelp.
    * lang.opt (-all-warnings, -assert, -assert=, -comments,
    -comments-in-macros, -define-macro, -define-macro=, -dependencies,
    -dump, -dump=, -include-barrier, -include-directory,
    -include-directory=, -include-directory-after,
    -include-directory-after=, -include-prefix, -include-prefix=,
    -no-line-commands, -no-standard-includes, -output, -output=,
    -preprocess, -print-missing-file-dependencies, -trace-includes,
    -undefine-macro, -undefine-macro=, -user-dependencies, -verbose,
    -write-dependencies, -write-user-dependencies): New.

java:
    * jvspec.c (lang_specific_driver): Handle OPT__help instead of
    OPT_fhelp.
    * lang.opt (-CLASSPATH, -all-warnings, -bootclasspath, -classpath,
    -dependencies, -encoding, -extdirs, -include-directory,
    -include-directory=, -output-class-directory,
    -output-class-directory=, -resource, -resource=,
    -user-dependencies): New.

breaks plugin support on x86_64-apple-darwin10. The auto-host.h generated for
stage1-gcc contains the expected...


/* Define to enable plugin support. */
#ifndef USED_FOR_TARGET
#define ENABLE_PLUGIN 1
#endif

but the auto-host.h generated for prev-gcc contains...


/* Define to enable plugin support. */
#ifndef USED_FOR_TARGET
/* #undef ENABLE_PLUGIN */
#endif

There is no such problem at r164530 where x86_64-apple-darwin10 properly builds
plugin support.

-- 
Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug plugins/45787] r164531 breaks plugin support on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45787

--- Comment #1 from Jack Howarth <howarth at nitro dot med.uc.edu> 2010-09-25 00:35:32 UTC ---
Oddly at both r164530 and r164531, stage3 does build plugin.o in gcc despite
the fact that autohost.h has ENABLE_PLUGIN undefined in the second case.
However this inhibits the installation of the plugin header directory in
lib/gcc/x86_64-apple-darwin10.4.0/4.6.0 at r164531 and later.

-- 
Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug plugins/45787] r164531 breaks plugin support on x86_64-apple-darwin10

[joseph at codesourcery dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45787

--- Comment #3 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2010-09-25 17:28:29 UTC ---
Try adding an option entry

undefined
Driver Separate

to darwin.opt.

[Bug plugins/45787] r164531 breaks plugin support on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45787

--- Comment #4 from Jack Howarth <howarth at nitro dot med.uc.edu> 2010-09-25 19:06:18 UTC ---
Thanks! Adding...

Index: gcc/config/darwin.opt
===================================================================
--- gcc/config/darwin.opt    (revision 164620)
+++ gcc/config/darwin.opt    (working copy)
@@ -45,3 +45,6 @@
 iframework
 Target RejectNegative C ObjC C++ ObjC++ Joined Separate 
 -iframework <dir>    Add <dir> to the end of the system framework include path
+
+undefined
+Driver Separate

...eliminates issue with the autohost.h in all stages of the gcc build now
reporting...

/* Define to enable plugin support. */
#ifndef USED_FOR_TARGET
#define ENABLE_PLUGIN 1
#endif

...as expected and the plugin directory is once again installed in
lib/gcc/x86_64-apple-darwin10.4.0/4.6.0.

[Bug plugins/45787] r164531 breaks plugin support on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45787

--- Comment #5 from Jack Howarth <howarth at nitro dot med.uc.edu> 2010-09-26 14:11:34 UTC ---
Patch posted at http://gcc.gnu.org/ml/gcc-patches/2010-09/msg02037.html and
test results at http://gcc.gnu.org/ml/gcc-testresults/2010-09/msg02343.html.

[Bug target/45787] r164531 breaks plugin support on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45787

--- Comment #6 from Jack Howarth <howarth at nitro dot med.uc.edu> 2010-09-26 15:12:36 UTC ---
Revised patch with corrected changelog at
http://gcc.gnu.org/ml/gcc-patches/2010-09/msg02054.html.

[Bug target/45787] r164531 breaks plugin support on x86_64-apple-darwin10

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45787

Jack Howarth <howarth at nitro dot med.uc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jack Howarth <howarth at nitro dot med.uc.edu> 2010-10-01 00:45:37 UTC ---
Fixed on gcc trunk with...

Author: mrs
Date: Wed Sep 29 17:28:19 2010
New Revision: 164726

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164726
Log:
Joseph Myers  <joseph@codesourcery.com>
Jack Howarth <howarth@bromo.med.uc.edu>

    * config/darwin.opt (undefined): Add.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin.opt