public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/45837] New: Global options changes on Sept. 29th, breaks powerpc linux64 build
@ 2010-09-30  8:30 meissner at gcc dot gnu.org
  2010-09-30 19:39 ` [Bug target/45837] [4.6 Regression] " pinskia at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: meissner at gcc dot gnu.org @ 2010-09-30  8:30 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45837

           Summary: Global options changes on Sept. 29th, breaks powerpc
                    linux64 build
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: critical
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: meissner@gcc.gnu.org


Moving target_flags into a structure breaks the ppc linux64 build.

The file config/rs6000/options-default.h contains the lines:
#if TARGET_AIX
#define OPT_64 "maix64"
#define OPT_32 "maix32"
#else
#define OPT_64 "m64"
#define OPT_32 "m32"
#endif

The file config/rs6000/linux64.h contains this redefinition:
#undef    TARGET_AIX
#define    TARGET_AIX TARGET_64BIT

In the past, options.h was generated as:
extern int target_flags;
    /* ... */
#define TARGET_64BIT ((target_flags & MASK_64BIT) != 0)

Now it generates:
#define target_flags global_options.x_target_flags
    /* ... */
#define TARGET_64BIT ((target_flags & MASK_64BIT) != 0)

This means that anything that includes tm.h will get an error, stating that '.'
is not allowed in preprocessing tokens.  In the past it was relying on
target_flags being considered 0 by the preprocessor since it wasn't defined.


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Bug target/45837] [4.6 Regression] Global options changes on Sept. 29th, breaks powerpc linux64 build
  2010-09-30  8:30 [Bug target/45837] New: Global options changes on Sept. 29th, breaks powerpc linux64 build meissner at gcc dot gnu.org
@ 2010-09-30 19:39 ` pinskia at gcc dot gnu.org
  2010-09-30 23:02 ` meissner at gcc dot gnu.org
  2010-10-26  4:04 ` jakub at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2010-09-30 19:39 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45837

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0
            Summary|Global options changes on   |[4.6 Regression] Global
                   |Sept. 29th, breaks powerpc  |options changes on Sept.
                   |linux64 build               |29th, breaks powerpc
                   |                            |linux64 build


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Bug target/45837] [4.6 Regression] Global options changes on Sept. 29th, breaks powerpc linux64 build
  2010-09-30  8:30 [Bug target/45837] New: Global options changes on Sept. 29th, breaks powerpc linux64 build meissner at gcc dot gnu.org
  2010-09-30 19:39 ` [Bug target/45837] [4.6 Regression] " pinskia at gcc dot gnu.org
@ 2010-09-30 23:02 ` meissner at gcc dot gnu.org
  2010-10-26  4:04 ` jakub at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: meissner at gcc dot gnu.org @ 2010-09-30 23:02 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45837

--- Comment #2 from Michael Meissner <meissner at gcc dot gnu.org> 2010-09-30 19:53:01 UTC ---
Author: meissner
Date: Thu Sep 30 19:52:57 2010
New Revision: 164764

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164764
Log:
PR target/45837: Make powerpc build again

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/aix.h
    trunk/gcc/config/rs6000/option-defaults.h
    trunk/gcc/config/rs6000/rs6000.h


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Bug target/45837] [4.6 Regression] Global options changes on Sept. 29th, breaks powerpc linux64 build
  2010-09-30  8:30 [Bug target/45837] New: Global options changes on Sept. 29th, breaks powerpc linux64 build meissner at gcc dot gnu.org
  2010-09-30 19:39 ` [Bug target/45837] [4.6 Regression] " pinskia at gcc dot gnu.org
  2010-09-30 23:02 ` meissner at gcc dot gnu.org
@ 2010-10-26  4:04 ` jakub at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: jakub at gcc dot gnu.org @ 2010-10-26  4:04 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45837

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |jakub at gcc dot gnu.org
         Resolution|                            |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-10-26 04:04:16 UTC ---
Fixed.


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-26  4:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-30  8:30 [Bug target/45837] New: Global options changes on Sept. 29th, breaks powerpc linux64 build meissner at gcc dot gnu.org
2010-09-30 19:39 ` [Bug target/45837] [4.6 Regression] " pinskia at gcc dot gnu.org
2010-09-30 23:02 ` meissner at gcc dot gnu.org
2010-10-26  4:04 ` jakub at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).