public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
Date: Tue, 21 Dec 2010 18:21:00 -0000	[thread overview]
Message-ID: <bug-45989-4-Ira5aux5Y1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-45989-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dave.anglin@nrc-cnrc.gc.ca,
                   |                            |iains at gcc dot gnu.org,
                   |                            |pthaugen at us dot ibm.com

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2010-12-21 18:20:40 UTC ---
> Some of the objc.dg-struct-layout-encoding-1 test currently XPASS on several
> platforms:
>
> * i386-pc-solaris2.*, 32 and 64-bit:
>
> XPASS: objc.dg-struct-layout-encoding-1/t026_main.m execution test

This is the case for all the platforms I have looked at.

> * sparc-sun-solaris2.*, 32 and 64-bit, alpha-dec-osf5.1b, mips-sgi-irix6.5:
>
> XPASS: objc.dg-struct-layout-encoding-1/t025_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t026_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t027_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t028_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t029_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t030_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t031_main.m execution test

This is also the case for

hppa2.0w-hp-hpux11.11 (default mode), see
http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg01891.html

powerpc64-unknown-linux-gnu (-m32/65) see
http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg01488.html

> This just adds noise to the testsuite reports, so the xfails need to be
> adjusted.

Since I shared this feeling, I have the following darwin-centric patch in my
trees:

---
../../_gcc_clean/gcc/testsuite/objc.dg/gnu-encoding/struct-layout-encoding-1_generate.c
   2010-12-13 10:50:10.000000000 +0100
+++
../../gcc-4.6-work/gcc/testsuite/objc.dg/gnu-encoding/struct-layout-encoding-1_generate.c
   2010-12-18 12:14:33.000000000 +0100
@@ -243,10 +243,16 @@ switchfiles (int fields)
      of bugs in libobjc and the objc front-end.  25 is because
      vectors are not encoded.  The rest are because or zero sized
      arrays are encoded as pointers.  */
-  else if (filecnt >= 25)
+  else if (filecnt == 25 || (filecnt >= 27 && filecnt <= 29))
     {
       fprintf (outfile, "\
-/* { dg-do run { xfail *-*-* } } */\n\
+/* { dg-do run { xfail { { ! powerpc-apple-darwin9 } || ilp32 } } } */\n\
+/* { dg-options \"-w -I%s -fgnu-runtime\" } */\n", srcdir);
+    }
+  else if (filecnt >= 30)
+    {
+      fprintf (outfile, "\
+/* { dg-do run { xfail { ! powerpc-apple-darwin9 } } } */\n\
 /* { dg-options \"-w -I%s -fgnu-runtime\" } */\n", srcdir);
     }
   else

I have no way to test an extension to non-darwin platforms nor commit rights,
but it could be a starting point. It would also be nice to have a pointer to
"bugs in libobjc and the objc front-end" in the FIXME (if there is any
available).


  parent reply	other threads:[~2010-12-21 18:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-12 18:11 [Bug objc/45989] New: " ro at gcc dot gnu.org
2010-11-23 10:01 ` [Bug objc/45989] " nicola at gcc dot gnu.org
2010-12-21 18:21 ` dominiq at lps dot ens.fr [this message]
2010-12-22 15:47 ` dominiq at lps dot ens.fr
2011-01-05 14:05 ` dominiq at lps dot ens.fr
2011-01-05 19:17 ` ro at gcc dot gnu.org
2011-01-05 19:31 ` ro at gcc dot gnu.org
2011-01-05 22:51 ` dominiq at lps dot ens.fr
2011-01-07 19:39 ` ro at CeBiTec dot Uni-Bielefeld.DE
2011-01-09 12:34 ` dominiq at lps dot ens.fr
2011-01-14 17:37 ` ro at gcc dot gnu.org
2011-01-14 18:55 ` ro at gcc dot gnu.org
2011-01-14 19:05 ` ro at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-45989-4-Ira5aux5Y1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).