* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
@ 2010-11-23 10:01 ` nicola at gcc dot gnu.org
2010-12-21 18:21 ` dominiq at lps dot ens.fr
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: nicola at gcc dot gnu.org @ 2010-11-23 10:01 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
Nicola Pero <nicola at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2010.11.23 09:48:54
CC| |nicola at gcc dot gnu.org
Ever Confirmed|0 |1
--- Comment #1 from Nicola Pero <nicola at gcc dot gnu.org> 2010-11-23 09:48:54 UTC ---
Confirmed.
Thanks
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
2010-11-23 10:01 ` [Bug objc/45989] " nicola at gcc dot gnu.org
@ 2010-12-21 18:21 ` dominiq at lps dot ens.fr
2010-12-22 15:47 ` dominiq at lps dot ens.fr
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2010-12-21 18:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dave.anglin@nrc-cnrc.gc.ca,
| |iains at gcc dot gnu.org,
| |pthaugen at us dot ibm.com
--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2010-12-21 18:20:40 UTC ---
> Some of the objc.dg-struct-layout-encoding-1 test currently XPASS on several
> platforms:
>
> * i386-pc-solaris2.*, 32 and 64-bit:
>
> XPASS: objc.dg-struct-layout-encoding-1/t026_main.m execution test
This is the case for all the platforms I have looked at.
> * sparc-sun-solaris2.*, 32 and 64-bit, alpha-dec-osf5.1b, mips-sgi-irix6.5:
>
> XPASS: objc.dg-struct-layout-encoding-1/t025_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t026_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t027_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t028_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t029_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t030_main.m execution test
> XPASS: objc.dg-struct-layout-encoding-1/t031_main.m execution test
This is also the case for
hppa2.0w-hp-hpux11.11 (default mode), see
http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg01891.html
powerpc64-unknown-linux-gnu (-m32/65) see
http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg01488.html
> This just adds noise to the testsuite reports, so the xfails need to be
> adjusted.
Since I shared this feeling, I have the following darwin-centric patch in my
trees:
---
../../_gcc_clean/gcc/testsuite/objc.dg/gnu-encoding/struct-layout-encoding-1_generate.c
2010-12-13 10:50:10.000000000 +0100
+++
../../gcc-4.6-work/gcc/testsuite/objc.dg/gnu-encoding/struct-layout-encoding-1_generate.c
2010-12-18 12:14:33.000000000 +0100
@@ -243,10 +243,16 @@ switchfiles (int fields)
of bugs in libobjc and the objc front-end. 25 is because
vectors are not encoded. The rest are because or zero sized
arrays are encoded as pointers. */
- else if (filecnt >= 25)
+ else if (filecnt == 25 || (filecnt >= 27 && filecnt <= 29))
{
fprintf (outfile, "\
-/* { dg-do run { xfail *-*-* } } */\n\
+/* { dg-do run { xfail { { ! powerpc-apple-darwin9 } || ilp32 } } } */\n\
+/* { dg-options \"-w -I%s -fgnu-runtime\" } */\n", srcdir);
+ }
+ else if (filecnt >= 30)
+ {
+ fprintf (outfile, "\
+/* { dg-do run { xfail { ! powerpc-apple-darwin9 } } } */\n\
/* { dg-options \"-w -I%s -fgnu-runtime\" } */\n", srcdir);
}
else
I have no way to test an extension to non-darwin platforms nor commit rights,
but it could be a starting point. It would also be nice to have a pointer to
"bugs in libobjc and the objc front-end" in the FIXME (if there is any
available).
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
2010-11-23 10:01 ` [Bug objc/45989] " nicola at gcc dot gnu.org
2010-12-21 18:21 ` dominiq at lps dot ens.fr
@ 2010-12-22 15:47 ` dominiq at lps dot ens.fr
2011-01-05 14:05 ` dominiq at lps dot ens.fr
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2010-12-22 15:47 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kkojima at rr dot
| |iij4u.or.jp,
| |schwab@linux-m68k.org
--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2010-12-22 15:47:33 UTC ---
t025 to t031 XPASS also on
sh4-unknown-linux-gnu (default) see
http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg01979.html
ia64-suse-linux-gnu (default) see
http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg01903.html
On powerpc-apple-darwin9 and -m32 only t026, t030, and t031 XPASS, see
http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg01959.html
I have tested on powerpc-apple-darwin9 and x86_64-apple-darwin10 the following
more general patch:
---
/opt/gcc/_gcc_clean/gcc/testsuite/objc.dg/gnu-encoding/struct-layout-encoding-1_generate.c
2010-12-13 10:50:10.000000000 +0100
+++
/opt/gcc/gcc-4.6-work/gcc/testsuite/objc.dg/gnu-encoding/struct-layout-encoding-1_generate.c
2010-12-22 14:47:33.000000000 +0100
@@ -243,10 +243,16 @@ switchfiles (int fields)
of bugs in libobjc and the objc front-end. 25 is because
vectors are not encoded. The rest are because or zero sized
arrays are encoded as pointers. */
- else if (filecnt >= 25)
+ else if (filecnt == 25 || (filecnt >= 27 && filecnt <= 29))
{
fprintf (outfile, "\
-/* { dg-do run { xfail *-*-* } } */\n\
+/* { dg-do run { xfail { *86*-*-* || { powerpc*-apple-darwin* && ilp32 } } } }
*/\n\
+/* { dg-options \"-w -I%s -fgnu-runtime\" } */\n", srcdir);
+ }
+ else if (filecnt >= 30)
+ {
+ fprintf (outfile, "\
+/* { dg-do run { xfail *86*-*-* } } */\n\
/* { dg-options \"-w -I%s -fgnu-runtime\" } */\n", srcdir);
}
else
It should work on all the platforms listed above, could you test it?
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (2 preceding siblings ...)
2010-12-22 15:47 ` dominiq at lps dot ens.fr
@ 2011-01-05 14:05 ` dominiq at lps dot ens.fr
2011-01-05 19:17 ` ro at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2011-01-05 14:05 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-01-05 14:02:15 UTC ---
Did somebody test the patch in comment #3?
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (3 preceding siblings ...)
2011-01-05 14:05 ` dominiq at lps dot ens.fr
@ 2011-01-05 19:17 ` ro at gcc dot gnu.org
2011-01-05 19:31 ` ro at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ro at gcc dot gnu.org @ 2011-01-05 19:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> 2011-01-05 19:10:41 UTC ---
I successfully did on i386-pc-solaris2.11. I'd suggest a slightly updated
version
(attached), with two changes
* We should use i?86*-*-* (or perhaps just i?86-*-*, I see no reason for the
first
*).
* The comment should be updated (perhaps with PR #s) to provide documentation
for the XFAILed changes.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (4 preceding siblings ...)
2011-01-05 19:17 ` ro at gcc dot gnu.org
@ 2011-01-05 19:31 ` ro at gcc dot gnu.org
2011-01-05 22:51 ` dominiq at lps dot ens.fr
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ro at gcc dot gnu.org @ 2011-01-05 19:31 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> 2011-01-05 19:17:42 UTC ---
Created attachment 22909
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22909
slightly revised patch
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (5 preceding siblings ...)
2011-01-05 19:31 ` ro at gcc dot gnu.org
@ 2011-01-05 22:51 ` dominiq at lps dot ens.fr
2011-01-07 19:39 ` ro at CeBiTec dot Uni-Bielefeld.DE
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2011-01-05 22:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-01-05 22:31:14 UTC ---
> * We should use i?86*-*-* (or perhaps just i?86-*-*, I see no reason for the
> first *).
I don't think this cover x86_64-*-*, this is why I have tested *86*-*-*
> * The comment should be updated (perhaps with PR #s) to provide documentation
> for the XFAILed changes.
See the end of comment #2. This should probably addressed by the objc
maintainers.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (6 preceding siblings ...)
2011-01-05 22:51 ` dominiq at lps dot ens.fr
@ 2011-01-07 19:39 ` ro at CeBiTec dot Uni-Bielefeld.DE
2011-01-09 12:34 ` dominiq at lps dot ens.fr
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2011-01-07 19:39 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2011-01-07 19:16:42 UTC ---
> --- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-01-05 22:31:14 UTC ---
>> * We should use i?86*-*-* (or perhaps just i?86-*-*, I see no reason for the
>> first *).
>
> I don't think this cover x86_64-*-*, this is why I have tested *86*-*-*
Indeed, had forgotten about that. In that case, we should do as
everywhere else in the testsuite and explicitly list i?86-*-* and
x86_64-*-*. Just *86*-*-* is too general (there was a sparcle86 or
something, I think :-).
>> * The comment should be updated (perhaps with PR #s) to provide documentation
>> for the XFAILed changes.
>
> See the end of comment #2. This should probably addressed by the objc
> maintainers.
Probably, and hopefully the will do so once we finally propose the patch
and get approval.
With the exception of x86_64 handling above, we're good to go, I think.
Rainer
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (7 preceding siblings ...)
2011-01-07 19:39 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2011-01-09 12:34 ` dominiq at lps dot ens.fr
2011-01-14 17:37 ` ro at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2011-01-09 12:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
--- Comment #9 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-01-09 11:24:59 UTC ---
Created attachment 22934
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22934
updated patch
> Indeed, had forgotten about that. In that case, we should do as
> everywhere else in the testsuite and explicitly list i?86-*-* and
> x86_64-*-*.
I am attaching an updated patch using a more canonical list for *86*-*-* and
references to pr25361 and this one. I have tested it on powerpc-apple-darwin9
and x86_64-apple-darwin10.6.0 (further testing welcome;-). Please feel free to
do the change you deem suitable and to commit it.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (8 preceding siblings ...)
2011-01-09 12:34 ` dominiq at lps dot ens.fr
@ 2011-01-14 17:37 ` ro at gcc dot gnu.org
2011-01-14 18:55 ` ro at gcc dot gnu.org
2011-01-14 19:05 ` ro at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: ro at gcc dot gnu.org @ 2011-01-14 17:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
URL| |http://gcc.gnu.org/ml/gcc-p
| |atches/2011-01/msg00996.htm
| |l
AssignedTo|unassigned at gcc dot |ro at gcc dot gnu.org
|gnu.org |
Target Milestone|--- |4.6.0
--- Comment #10 from Rainer Orth <ro at gcc dot gnu.org> 2011-01-14 17:15:41 UTC ---
Mine, patch submitted.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (9 preceding siblings ...)
2011-01-14 17:37 ` ro at gcc dot gnu.org
@ 2011-01-14 18:55 ` ro at gcc dot gnu.org
2011-01-14 19:05 ` ro at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: ro at gcc dot gnu.org @ 2011-01-14 18:55 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
--- Comment #11 from Rainer Orth <ro at gcc dot gnu.org> 2011-01-14 18:47:53 UTC ---
Author: ro
Date: Fri Jan 14 18:47:50 2011
New Revision: 168806
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168806
Log:
2011-01-08 Dominique d'Humieres <dominiq@lps.ens.fr>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
PR objc/45989
* objc.dg/gnu-encoding/struct-layout-encoding-1_generate.c
(switchfiles): XFAIL
objc.dg-struct-layout-encoding-1/t02[57-9]_main.m execution tests
on i?86-*-*, x86_64-*-*, and powerpc*-apple-darwin* && ilp32.
XFAIL objc.dg-struct-layout-encoding-1/t03[01]_main.m execution
tests on i?86-*-* and x86_64-*-*.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/objc.dg/gnu-encoding/struct-layout-encoding-1_generate.c
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug objc/45989] Some objc.dg-struct-layout-encoding-1 tests XPASS
2010-10-12 18:11 [Bug objc/45989] New: Some objc.dg-struct-layout-encoding-1 tests XPASS ro at gcc dot gnu.org
` (10 preceding siblings ...)
2011-01-14 18:55 ` ro at gcc dot gnu.org
@ 2011-01-14 19:05 ` ro at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: ro at gcc dot gnu.org @ 2011-01-14 19:05 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45989
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #12 from Rainer Orth <ro at gcc dot gnu.org> 2011-01-14 18:51:06 UTC ---
Fixed for 4.6.0.
^ permalink raw reply [flat|nested] 13+ messages in thread