[Bug tree-optimization/46099] New: [4.5/4.6 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[Bug tree-optimization/46099] New: [4.5/4.6 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

           Summary: [4.5/4.6 Regression] ICE: in replace_ssa_name, at
                    tree-cfg.c:5643 with -ftree-parallelize-loops -g
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz


Created attachment 22096
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22096
reduced testcase

Compiler output:
$ gcc -ftree-parallelize-loops=2 -g -O pr46099.c 
pr46099.c: In function 'foo':
pr46099.c:7:1: internal compiler error: in replace_ssa_name, at tree-cfg.c:5643
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Tested revisions:
r165719 - crash
r158095 - crash
r153685 - OK
4.5 r163761 - crash
4.4 r160770 - OK

[Bug tree-optimization/46099] [4.5/4.6 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.2

[Bug tree-optimization/46099] [4.5/4.6 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.10.20 20:37:15
                 CC|                            |hjl.tools at gmail dot com,
                   |                            |jakub at redhat dot com
     Ever Confirmed|0                           |1

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2010-10-20 20:37:15 UTC ---
It is caused by revision 157402:

http://gcc.gnu.org/ml/gcc-cvs/2010-03/msg00239.html

[Bug tree-optimization/46099] [4.5/4.6 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu.org,
                   |                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-10-22 19:06:27 UTC ---
The problem is that eliminate_local_variables{,_1} calls take_address_of on
ADDR_EXPR etc. in debug stmt expressions.  That affects code generation, so
definitely must not be done.  Either we need to first eliminate local variables
in normal stmts and then do separate processing on debug stmts, where those for
which take_address_of did something would use it, but it wouldn't create new
hash entries and otherwise just reset debug stmts or something, or we need to
reset them right away.

[Bug tree-optimization/46099] [4.5/4.6 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug tree-optimization/46099] [4.5/4.6 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-04 15:26:49 UTC ---
Created attachment 22283
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22283
gcc46-pr46099.patch

Untested fix.

[Bug tree-optimization/46099] [4.5/4.6 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-05 11:15:32 UTC ---
Author: jakub
Date: Fri Nov  5 11:15:28 2010
New Revision: 166355

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166355
Log:
    PR tree-optimization/46099
    * tree-parloops.c (take_address_of): Add GSI argument.  Return NULL
    if it is NULL and uid wasn't found in the hash table.  Just fold the
    result if it is NULL otherwise.  Insert other potentially needed
    stmts right before current stmt instead of on the entry edge.
    (struct elv_data): Add gsi and reset fields.
    (eliminate_local_variables_1): Adjust caller.  If take_address_of
    failed for debug stmt, set dta->reset and return.
    (eliminate_local_variables_stmt): Change STMT argument for GSI,
    pass GSI through to the callback, handle resetting of debug stmts.
    (eliminate_local_variables): Adjust caller.  Process debug stmts
    in second phase.

    * gcc.dg/autopar/pr46099.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/autopar/pr46099.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-parloops.c

[Bug tree-optimization/46099] [4.5 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.6.0
            Summary|[4.5/4.6 Regression] ICE:   |[4.5 Regression] ICE: in
                   |in replace_ssa_name, at     |replace_ssa_name, at
                   |tree-cfg.c:5643 with        |tree-cfg.c:5643 with
                   |-ftree-parallelize-loops -g |-ftree-parallelize-loops -g
      Known to fail|4.6.0                       |

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-05 11:33:48 UTC ---
Fixed on the trunk.

[Bug tree-optimization/46099] [4.5 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-11 20:38:15 UTC ---
Author: jakub
Date: Thu Nov 11 20:38:12 2010
New Revision: 166618

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166618
Log:
    Backport from mainline
    2010-11-05  Jakub Jelinek  <jakub@redhat.com>

    PR tree-optimization/46099
    * tree-parloops.c (take_address_of): Add GSI argument.  Return NULL
    if it is NULL and uid wasn't found in the hash table.  Just fold the
    result if it is NULL otherwise.  Insert other potentially needed
    stmts right before current stmt instead of on the entry edge.
    (struct elv_data): Add gsi and reset fields.
    (eliminate_local_variables_1): Adjust caller.  If take_address_of
    failed for debug stmt, set dta->reset and return.
    (eliminate_local_variables_stmt): Change STMT argument for GSI,
    pass GSI through to the callback, handle resetting of debug stmts.
    (eliminate_local_variables): Adjust caller.  Process debug stmts
    in second phase.

    * gcc.dg/autopar/pr46099.c: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/autopar/pr46099.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/gcc/tree-parloops.c

[Bug tree-optimization/46099] [4.5 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-11 22:12:22 UTC ---
Fixed.

[Bug tree-optimization/46099] [4.5 Regression] ICE: in replace_ssa_name, at tree-cfg.c:5643 with -ftree-parallelize-loops -g

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46099

--- Comment #8 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2010-11-17 06:43:31 UTC ---
*** Bug 46118 has been marked as a duplicate of this bug. ***