[Bug tree-optimization/46177] New: [4.5/4.6 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[Bug tree-optimization/46177] New: [4.5/4.6 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

           Summary: [4.5/4.6 Regression] ICE: in prop_phis, at
                    tree-loop-distribution.c:327 with -fno-tree-copy-prop
                    -ftree-loop-distribution
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz


Created attachment 22155
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22155
reduced testcase

Compiler output:
$ gcc -O -fno-tree-copy-prop -ftree-loop-distribution pr46177.c 
pr46177.c: In function 'foo':
pr46177.c:5:1: internal compiler error: in prop_phis, at
tree-loop-distribution.c:327
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Fails with -O3 -fno-tree-copy-prop as well as it implies
-ftree-loop-distribute-patterns

Tested revisions:
r165915 - crash
r153685 - crash
4.5 r165781 - crash
4.4 r165754 - OK

[Bug tree-optimization/46177] [4.5/4.6 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.10.26 07:06:29
                 CC|                            |rguenth at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2010-10-26 07:06:29 UTC ---
It is caused by revision 145494:

http://gcc.gnu.org/ml/gcc-cvs/2009-04/msg00115.html

[Bug tree-optimization/46177] [4.5/4.6 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.5.2

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-10-26 13:57:20 UTC ---
Mine.

[Bug tree-optimization/46177] [4.5/4.6 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
                 CC|                            |jakub at gcc dot gnu.org

[Bug tree-optimization/46177] [4.5/4.6 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-02 13:38:21 UTC ---
I have a patch.

[Bug tree-optimization/46177] [4.5/4.6 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-02 15:45:31 UTC ---
Author: rguenth
Date: Tue Nov  2 15:45:26 2010
New Revision: 166193

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166193
Log:
2010-11-02  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/46177
    * tree-loop-distribution.c (prop_phis): Use
    mark_virtual_phi_result_for_renaming.

    * gcc.dg/pr46177.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/pr46177.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-loop-distribution.c

[Bug tree-optimization/46177] [4.5 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.6.0
            Summary|[4.5/4.6 Regression] ICE:   |[4.5 Regression] ICE: in
                   |in prop_phis, at            |prop_phis, at
                   |tree-loop-distribution.c:32 |tree-loop-distribution.c:32
                   |7 with -fno-tree-copy-prop  |7 with -fno-tree-copy-prop
                   |-ftree-loop-distribution    |-ftree-loop-distribution
      Known to fail|4.6.0                       |

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-02 15:48:41 UTC ---
Fixed on trunk sofar.

[Bug tree-optimization/46177] [4.5 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

--- Comment #6 from Zdenek Sojka <zsojka at seznam dot cz> 2010-11-05 21:37:28 UTC ---
Created attachment 22298
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22298
another testcase

Thank you for having a look at this issue! The original testcase
testsuite/gcc.dg/tree-ssa/pr38385.c is still failing, attached is another
testcase that fails in r166306. Should I open separate PR for this? Thanks!

$ gcc -O -fno-tree-copy-prop -ftree-loop-distribution pr46177-2.c        
pr46177-2.c: In function 'foo':
pr46177-2.c:4:1: internal compiler error: in prop_phis, at
tree-loop-distribution.c:331
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug tree-optimization/46177] [4.5 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenther at suse dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

--- Comment #7 from rguenther at suse dot de <rguenther at suse dot de> 2010-11-05 22:38:18 UTC ---
On Fri, 5 Nov 2010, zsojka at seznam dot cz wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177
> 
> --- Comment #6 from Zdenek Sojka <zsojka at seznam dot cz> 2010-11-05 21:37:28 UTC ---
> Created attachment 22298
>   --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22298
> another testcase
> 
> Thank you for having a look at this issue! The original testcase
> testsuite/gcc.dg/tree-ssa/pr38385.c is still failing, attached is another
> testcase that fails in r166306. Should I open separate PR for this? Thanks!

No, it's probably still the same bug, just re-open this PR.

[Bug tree-optimization/46177] [4.5/4.6 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-09 15:01:51 UTC ---
Author: rguenth
Date: Tue Nov  9 15:01:41 2010
New Revision: 166492

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166492
Log:
2010-11-09  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/46177
    * tree-loop-distribution.c (prop_phis): Remove.
    (generate_builtin): Re-use the old loop exit edge to avoid
    needing to update PHI nodes.

    * gcc.dg/pr46177-2.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/pr46177-2.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-loop-distribution.c

[Bug tree-optimization/46177] [4.5 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.6.0
            Summary|[4.5/4.6 Regression] ICE:   |[4.5 Regression] ICE: in
                   |in prop_phis, at            |prop_phis, at
                   |tree-loop-distribution.c:32 |tree-loop-distribution.c:32
                   |7 with -fno-tree-copy-prop  |7 with -fno-tree-copy-prop
                   |-ftree-loop-distribution    |-ftree-loop-distribution
      Known to fail|4.6.0                       |

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-09 15:02:31 UTC ---
Fixed on trunk again.

[Bug tree-optimization/46177] [4.5 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-12 14:43:49 UTC ---
Fixed.

[Bug tree-optimization/46177] [4.5 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

--- Comment #10 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-12 14:43:25 UTC ---
Author: rguenth
Date: Fri Nov 12 14:43:19 2010
New Revision: 166652

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166652
Log:
2010-11-12  Richard Guenther  <rguenther@suse.de>

    Backport from mainline
    2010-11-09  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/46355
    * tree-loop-distribution.c (tree_loop_distribution): Do not
    distribute loops without a single exit.

    * gcc.dg/pr46355.c: New testcase.

    2010-11-02  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/46177
    * tree-loop-distribution.c (prop_phis): Use
    mark_virtual_phi_result_for_renaming.

    * gcc.dg/pr46177.c: New testcase.

    2010-11-09  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/46177
    * tree-loop-distribution.c (prop_phis): Remove.
    (generate_builtin): Re-use the old loop exit edge to avoid
    needing to update PHI nodes.

    * gcc.dg/pr46177-2.c: New testcase.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46177-2.c
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46177.c
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46355.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/gcc/tree-loop-distribution.c

[Bug tree-optimization/46177] [4.5 Regression] ICE: in prop_phis, at tree-loop-distribution.c:327 with -fno-tree-copy-prop -ftree-loop-distribution

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46177

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-12 21:54:53 UTC ---
Author: jakub
Date: Fri Nov 12 21:54:47 2010
New Revision: 166679

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166679
Log:
    PR tree-optimization/46177
    * gcc.dg/pr46177.c: Fix dg-options.

Modified:
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46177.c